From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] i915/gem_workarounds: Require GPU resets
Date: Mon, 28 Jan 2019 11:03:30 +0000 [thread overview]
Message-ID: <a2aec896-234e-2c6a-ef1e-1e2be53f1492@linux.intel.com> (raw)
In-Reply-To: <20190127130615.12917-1-chris@chris-wilson.co.uk>
On 27/01/2019 13:06, Chris Wilson wrote:
> Check that we are allowed to reset the GPU prior to execution.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/i915/gem_workarounds.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_workarounds.c b/tests/i915/gem_workarounds.c
> index 78478ad2c..0e9ab2386 100644
> --- a/tests/i915/gem_workarounds.c
> +++ b/tests/i915/gem_workarounds.c
> @@ -192,7 +192,11 @@ static void check_workarounds(int fd, enum operation op, unsigned int flags)
>
> switch (op) {
> case GPU_RESET:
> - igt_force_gpu_reset(fd);
> + {
> + igt_hang_t hang = igt_allow_hang(fd, ctx, 0);
> + igt_force_gpu_reset(fd);
> + igt_disallow_hang(fd, hang);
> + }
> break;
>
> case SUSPEND_RESUME:
>
If it doesn't make sense to add the checks into igt_force_gpu_reset (so
force means force), should we have igt_try_gpu_reset to avoid having to
wrap it everywhere?
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-01-28 11:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 13:06 [igt-dev] [PATCH i-g-t] i915/gem_workarounds: Require GPU resets Chris Wilson
2019-01-27 13:50 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-27 15:46 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-01-28 11:03 ` Tvrtko Ursulin [this message]
2019-01-28 11:07 ` [igt-dev] [Intel-gfx] [PATCH i-g-t] " Chris Wilson
2019-01-28 11:12 ` Chris Wilson
2019-01-28 13:44 ` Tvrtko Ursulin
2019-01-28 13:47 ` Chris Wilson
2019-01-28 11:23 ` [igt-dev] " Chris Wilson
2019-01-28 13:47 ` Tvrtko Ursulin
2019-01-29 18:57 ` [Intel-gfx] " Chris Wilson
2019-01-30 8:11 ` [igt-dev] " Tvrtko Ursulin
2019-01-30 9:49 ` Chris Wilson
2019-01-28 11:58 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_workarounds: Require GPU resets (rev2) Patchwork
2019-01-28 15:21 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2aec896-234e-2c6a-ef1e-1e2be53f1492@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox