igt-dev.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Martin Peres <martin.peres@linux.intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/psr: Add a few PSR tests to fastfeedback test list for some coverage
Date: Thu, 19 Jul 2018 11:23:08 +0300	[thread overview]
Message-ID: <a2b6244c-bc6d-a9f6-7448-ee3e6716ad6e@linux.intel.com> (raw)
In-Reply-To: <20180717194109.GJ7043@intel.com>



On 17/07/18 22:41, Rodrigo Vivi wrote:
> On Tue, Jul 17, 2018 at 11:58:51AM -0700, Dhinakaran Pandiyan wrote:
>> PSR tests are primarily executed on shards machines that do not have the
>> required panels, the only test in fastfeedback does not do much. So add
>> these tests to provide some meaningful coverage.
>>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Martin Peres <martin.peres@linux.intel.com>
>> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>> ---
>>  tests/intel-ci/fast-feedback.testlist | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
>> index 4b405e36..2e1abf23 100644
>> --- a/tests/intel-ci/fast-feedback.testlist
>> +++ b/tests/intel-ci/fast-feedback.testlist
>> @@ -243,7 +243,10 @@ igt@kms_pipe_crc_basic@read-crc-pipe-c-frame-sequence
>>  igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a
>>  igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b
>>  igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c
>> -igt@kms_psr@basic
> 
> we should probably now delete this basic test...
> since it's only reason was this list...

So, adding ~13 seconds and removing 3 seconds. I think we can spend an
extra 10s on PSR testing :)

Thanks for this!

Acked-by: Martin Peres <martin.peres@linux.intel.com>

> 
>> +igt@kms_psr@primary_page_flip
>> +igt@kms_psr@cursor_plane_move
>> +igt@kms_psr@sprite_plane_onoff
>> +igt@kms_psr@primary_mmap_gtt
> 
> 
> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>


> 
> 
> 
>>  igt@kms_setmode@basic-clone-single-crtc
>>  igt@pm_backlight@basic-brightness
>>  igt@pm_rpm@basic-pci-d3-state
>> -- 
>> 2.17.1
>>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2018-07-19  8:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-17 18:58 [igt-dev] [PATCH i-g-t] tests/psr: Add a few PSR tests to fastfeedback test list for some coverage Dhinakaran Pandiyan
2018-07-17 19:41 ` Rodrigo Vivi
2018-07-17 20:10   ` Dhinakaran Pandiyan
2018-07-19  8:23   ` Martin Peres [this message]
2018-07-17 20:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-07-18  3:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2b6244c-bc6d-a9f6-7448-ee3e6716ad6e@linux.intel.com \
    --to=martin.peres@linux.intel.com \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).