* [igt-dev] [PATCH i-g-t] tests/psr: Add a few PSR tests to fastfeedback test list for some coverage
@ 2018-07-17 18:58 Dhinakaran Pandiyan
2018-07-17 19:41 ` Rodrigo Vivi
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Dhinakaran Pandiyan @ 2018-07-17 18:58 UTC (permalink / raw)
To: igt-dev; +Cc: Martin Peres, Dhinakaran Pandiyan, Rodrigo Vivi
PSR tests are primarily executed on shards machines that do not have the
required panels, the only test in fastfeedback does not do much. So add
these tests to provide some meaningful coverage.
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Martin Peres <martin.peres@linux.intel.com>
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
tests/intel-ci/fast-feedback.testlist | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index 4b405e36..2e1abf23 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -243,7 +243,10 @@ igt@kms_pipe_crc_basic@read-crc-pipe-c-frame-sequence
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c
-igt@kms_psr@basic
+igt@kms_psr@primary_page_flip
+igt@kms_psr@cursor_plane_move
+igt@kms_psr@sprite_plane_onoff
+igt@kms_psr@primary_mmap_gtt
igt@kms_setmode@basic-clone-single-crtc
igt@pm_backlight@basic-brightness
igt@pm_rpm@basic-pci-d3-state
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [igt-dev] [PATCH i-g-t] tests/psr: Add a few PSR tests to fastfeedback test list for some coverage
2018-07-17 18:58 [igt-dev] [PATCH i-g-t] tests/psr: Add a few PSR tests to fastfeedback test list for some coverage Dhinakaran Pandiyan
@ 2018-07-17 19:41 ` Rodrigo Vivi
2018-07-17 20:10 ` Dhinakaran Pandiyan
2018-07-19 8:23 ` Martin Peres
2018-07-17 20:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-07-18 3:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 2 replies; 6+ messages in thread
From: Rodrigo Vivi @ 2018-07-17 19:41 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: igt-dev, Martin Peres
On Tue, Jul 17, 2018 at 11:58:51AM -0700, Dhinakaran Pandiyan wrote:
> PSR tests are primarily executed on shards machines that do not have the
> required panels, the only test in fastfeedback does not do much. So add
> these tests to provide some meaningful coverage.
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Martin Peres <martin.peres@linux.intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
> tests/intel-ci/fast-feedback.testlist | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index 4b405e36..2e1abf23 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -243,7 +243,10 @@ igt@kms_pipe_crc_basic@read-crc-pipe-c-frame-sequence
> igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a
> igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b
> igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c
> -igt@kms_psr@basic
we should probably now delete this basic test...
since it's only reason was this list...
> +igt@kms_psr@primary_page_flip
> +igt@kms_psr@cursor_plane_move
> +igt@kms_psr@sprite_plane_onoff
> +igt@kms_psr@primary_mmap_gtt
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> igt@kms_setmode@basic-clone-single-crtc
> igt@pm_backlight@basic-brightness
> igt@pm_rpm@basic-pci-d3-state
> --
> 2.17.1
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/psr: Add a few PSR tests to fastfeedback test list for some coverage
2018-07-17 19:41 ` Rodrigo Vivi
@ 2018-07-17 20:10 ` Dhinakaran Pandiyan
2018-07-19 8:23 ` Martin Peres
1 sibling, 0 replies; 6+ messages in thread
From: Dhinakaran Pandiyan @ 2018-07-17 20:10 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: igt-dev, Martin Peres
On Tue, 2018-07-17 at 12:41 -0700, Rodrigo Vivi wrote:
> On Tue, Jul 17, 2018 at 11:58:51AM -0700, Dhinakaran Pandiyan wrote:
> >
> > PSR tests are primarily executed on shards machines that do not
> > have the
> > required panels, the only test in fastfeedback does not do much. So
> > add
> > these tests to provide some meaningful coverage.
> >
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Martin Peres <martin.peres@linux.intel.com>
> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > ---
> > tests/intel-ci/fast-feedback.testlist | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-
> > ci/fast-feedback.testlist
> > index 4b405e36..2e1abf23 100644
> > --- a/tests/intel-ci/fast-feedback.testlist
> > +++ b/tests/intel-ci/fast-feedback.testlist
> > @@ -243,7 +243,10 @@ igt@kms_pipe_crc_basic@read-crc-pipe-c-frame-s
> > equence
> > igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a
> > igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b
> > igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c
> > -igt@kms_psr@basic
> we should probably now delete this basic test...
> since it's only reason was this list...
>
Makes sense, I'll remove it after this patch gets merged.
> >
> > +igt@kms_psr@primary_page_flip
> > +igt@kms_psr@cursor_plane_move
> > +igt@kms_psr@sprite_plane_onoff
> > +igt@kms_psr@primary_mmap_gtt
>
> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
>
>
> >
> > igt@kms_setmode@basic-clone-single-crtc
> > igt@pm_backlight@basic-brightness
> > igt@pm_rpm@basic-pci-d3-state
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/psr: Add a few PSR tests to fastfeedback test list for some coverage
2018-07-17 19:41 ` Rodrigo Vivi
2018-07-17 20:10 ` Dhinakaran Pandiyan
@ 2018-07-19 8:23 ` Martin Peres
1 sibling, 0 replies; 6+ messages in thread
From: Martin Peres @ 2018-07-19 8:23 UTC (permalink / raw)
To: Rodrigo Vivi, Dhinakaran Pandiyan; +Cc: igt-dev
On 17/07/18 22:41, Rodrigo Vivi wrote:
> On Tue, Jul 17, 2018 at 11:58:51AM -0700, Dhinakaran Pandiyan wrote:
>> PSR tests are primarily executed on shards machines that do not have the
>> required panels, the only test in fastfeedback does not do much. So add
>> these tests to provide some meaningful coverage.
>>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Martin Peres <martin.peres@linux.intel.com>
>> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>> ---
>> tests/intel-ci/fast-feedback.testlist | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
>> index 4b405e36..2e1abf23 100644
>> --- a/tests/intel-ci/fast-feedback.testlist
>> +++ b/tests/intel-ci/fast-feedback.testlist
>> @@ -243,7 +243,10 @@ igt@kms_pipe_crc_basic@read-crc-pipe-c-frame-sequence
>> igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a
>> igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b
>> igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c
>> -igt@kms_psr@basic
>
> we should probably now delete this basic test...
> since it's only reason was this list...
So, adding ~13 seconds and removing 3 seconds. I think we can spend an
extra 10s on PSR testing :)
Thanks for this!
Acked-by: Martin Peres <martin.peres@linux.intel.com>
>
>> +igt@kms_psr@primary_page_flip
>> +igt@kms_psr@cursor_plane_move
>> +igt@kms_psr@sprite_plane_onoff
>> +igt@kms_psr@primary_mmap_gtt
>
>
> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
>
>
>> igt@kms_setmode@basic-clone-single-crtc
>> igt@pm_backlight@basic-brightness
>> igt@pm_rpm@basic-pci-d3-state
>> --
>> 2.17.1
>>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/psr: Add a few PSR tests to fastfeedback test list for some coverage
2018-07-17 18:58 [igt-dev] [PATCH i-g-t] tests/psr: Add a few PSR tests to fastfeedback test list for some coverage Dhinakaran Pandiyan
2018-07-17 19:41 ` Rodrigo Vivi
@ 2018-07-17 20:41 ` Patchwork
2018-07-18 3:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-07-17 20:41 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: igt-dev
== Series Details ==
Series: tests/psr: Add a few PSR tests to fastfeedback test list for some coverage
URL : https://patchwork.freedesktop.org/series/46735/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4503 -> IGTPW_1599 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/46735/revisions/1/mbox/
== Known issues ==
Here are the changes found in IGTPW_1599 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_frontbuffer_tracking@basic:
fi-hsw-peppy: PASS -> DMESG-FAIL (fdo#102614, fdo#106103)
==== Possible fixes ====
igt@kms_chamelium@dp-crc-fast:
fi-kbl-7500u: FAIL (fdo#103841) -> PASS +1
igt@kms_flip@basic-flip-vs-dpms:
fi-skl-6700hq: DMESG-WARN (fdo#105998) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
== Participating hosts (46 -> 40) ==
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-kbl-7560u
== Build changes ==
* IGT: IGT_4562 -> IGTPW_1599
CI_DRM_4503: 4aa6797dfafaf527949bf55d3c8513c6902dfec2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1599: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1599/
IGT_4562: 8781fd89a63eabed9359d02b50583cca67ff3673 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1599/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* [igt-dev] ✓ Fi.CI.IGT: success for tests/psr: Add a few PSR tests to fastfeedback test list for some coverage
2018-07-17 18:58 [igt-dev] [PATCH i-g-t] tests/psr: Add a few PSR tests to fastfeedback test list for some coverage Dhinakaran Pandiyan
2018-07-17 19:41 ` Rodrigo Vivi
2018-07-17 20:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-07-18 3:41 ` Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-07-18 3:41 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: igt-dev
== Series Details ==
Series: tests/psr: Add a few PSR tests to fastfeedback test list for some coverage
URL : https://patchwork.freedesktop.org/series/46735/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4562_full -> IGTPW_1599_full =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1599_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1599_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/46735/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1599_full:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_schedule@deep-bsd2:
shard-kbl: SKIP -> PASS +2
igt@gem_mocs_settings@mocs-rc6-vebox:
shard-kbl: PASS -> SKIP
== Known issues ==
Here are the changes found in IGTPW_1599_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_suspend@shrink:
shard-hsw: PASS -> FAIL (fdo#106886)
igt@gem_exec_blt@cold-max:
shard-snb: PASS -> INCOMPLETE (fdo#105411)
igt@kms_flip@plain-flip-fb-recreate-interruptible:
shard-glk: PASS -> FAIL (fdo#100368) +1
igt@kms_rotation_crc@primary-rotation-180:
shard-kbl: PASS -> DMESG-WARN (fdo#105345)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
shard-kbl: PASS -> FAIL (fdo#99912)
igt@pm_rpm@modeset-stress-extra-wait:
shard-hsw: PASS -> INCOMPLETE (fdo#103540)
igt@testdisplay:
shard-glk: PASS -> INCOMPLETE (fdo#103359, k.org#198133)
==== Possible fixes ====
igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
shard-glk: FAIL (fdo#103060) -> PASS
igt@kms_flip@2x-plain-flip-fb-recreate:
shard-hsw: FAIL (fdo#100368) -> PASS
igt@kms_flip@plain-flip-fb-recreate:
shard-glk: FAIL (fdo#100368) -> PASS +1
igt@kms_plane_lowres@pipe-a-tiling-y:
shard-glk: FAIL (fdo#103166) -> PASS
igt@kms_universal_plane@cursor-fb-leak-pipe-b:
shard-glk: FAIL -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#105345 https://bugs.freedesktop.org/show_bug.cgi?id=105345
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* IGT: IGT_4562 -> IGTPW_1599
* Linux: CI_DRM_4501 -> CI_DRM_4503
CI_DRM_4501: 692d13f7b75baf0bb8c58b9784569c52d68f01e2 @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4503: 4aa6797dfafaf527949bf55d3c8513c6902dfec2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1599: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1599/
IGT_4562: 8781fd89a63eabed9359d02b50583cca67ff3673 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1599/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-19 8:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-17 18:58 [igt-dev] [PATCH i-g-t] tests/psr: Add a few PSR tests to fastfeedback test list for some coverage Dhinakaran Pandiyan
2018-07-17 19:41 ` Rodrigo Vivi
2018-07-17 20:10 ` Dhinakaran Pandiyan
2018-07-19 8:23 ` Martin Peres
2018-07-17 20:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-07-18 3:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).