From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 08FBB89B51 for ; Tue, 22 Jan 2019 15:48:33 +0000 (UTC) Message-ID: From: Paul Kocialkowski Date: Tue, 22 Jan 2019 16:48:05 +0100 In-Reply-To: <20190122142844.20899-9-maxime.ripard@bootlin.com> References: <20190122142844.20899-1-maxime.ripard@bootlin.com> <20190122142844.20899-9-maxime.ripard@bootlin.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v4 08/14] igt: fb: Don't pass the stride when allocating a dumb, multi-planar buffer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Maxime Ripard , igt-dev@lists.freedesktop.org Cc: Petri Latvala , eben@raspberrypi.org, Thomas Petazzoni List-ID: SGksCgpPbiBUdWUsIDIwMTktMDEtMjIgYXQgMTU6MjggKzAxMDAsIE1heGltZSBSaXBhcmQgd3Jv dGU6Cj4gVGhlIGR1bWIgYnVmZmVyIGFsbG9jYXRpb24gQVBJIG9ubHkgY29uc2lkZXJzIGEgc2lu Z2xlIHBsYW5lLCBhbmQgZXZlbgo+IHRob3VnaCBhbGxvY2F0aW5nIG11bHRpLXBsYW5hciBidWZm ZXJzIHRocm91Z2ggaXQgaXMgYWxsb3dlZCwgdGhlIHN0cmlkZSBpdAo+IGdpdmVzIGJhY2sgaXMg dGhlIHRoZSB3aWR0aCB0aW1lcyB0aGUgYnBwIHBhc3NlZCBhcyBhbiBhcmd1bWVudC4KPiAKPiBU aGF0IGRvZXNuJ3Qgd29yayBpbiBvdXIgY2FzZSwgc2luY2UgdGhlIGJwcCBpcyBnb2luZyB0byBi ZSB0aGUgb25lIHdlIGdpdmUKPiBhcyBhbiBhcmd1bWVudCwgYnV0IHNwbGl0IG92ZXIgdGhyZWUg cGxhbmVzIHNvIHRoZSBzdHJpZGUgZG9lc24ndCBtYXRjaAo+IGFueW1vcmUuCj4gCj4gQSBwcm9w ZXIgZml4IGZvciB0aGlzIHdvdWxkIGJlIHRvIGhhdmUgYSBiZXR0ZXIgZHVtYiBidWZmZXIgYWxs b2NhdGlvbiBBUEksCj4gYnV0IGZvciB0aGUgdGltZSBiZWluZywgbGV0J3MgZG8gaXQgdGhhdCB3 YXkuCj4gCj4gU2lnbmVkLW9mZi1ieTogTWF4aW1lIFJpcGFyZCA8bWF4aW1lLnJpcGFyZEBib290 bGluLmNvbT4KCkFsdGhvdWdoIHRoaXMgaXMgc29tZXdoYXQgcmVsYXRlZCB0byB0aGUgY29uY2Vy bnMgb2YgcGF0Y2ggNS8sIGl0CmRlZmluaXRlbHkgZG9lc24ndCBtYWtlIHNlbnNlIHRvIHJldHVy biB0aGlzIHN0cmlkZSBpbiBhbnkgY2FzZSwgc286CgpSZXZpZXdlZC1ieTogUGF1bCBLb2NpYWxr b3dza2kgPHBhdWwua29jaWFsa293c2tpQGJvb3RsaW4uY29tPgoKQ2hlZXJzLAoKUGF1bAoKPiAt LS0KPiAgbGliL2lndF9mYi5jIHwgMTcgKysrKysrKysrKysrKysrKy0KPiAgMSBmaWxlIGNoYW5n ZWQsIDE2IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvbGli L2lndF9mYi5jIGIvbGliL2lndF9mYi5jCj4gaW5kZXggMGYwNDNhY2NlMjlkLi40OTA1NjNjMGVh NGIgMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF9mYi5jCj4gKysrIGIvbGliL2lndF9mYi5jCj4gQEAg LTUzMSw2ICs1MzEsNyBAQCBzdGF0aWMgaW50IGNyZWF0ZV9ib19mb3JfZmIoc3RydWN0IGlndF9m YiAqZmIpCj4gIAljb25zdCBzdHJ1Y3QgZm9ybWF0X2Rlc2Nfc3RydWN0ICpmbXQgPSBsb29rdXBf ZHJtX2Zvcm1hdChmYi0+ZHJtX2Zvcm1hdCk7Cj4gIAl1aW50NjRfdCBzaXplID0gY2FsY19mYl9z aXplKGZiKTsKPiAgCXVuc2lnbmVkIGludCBwbGFuZSwgYnBwOwo+ICsJdW5zaWduZWQgKnN0cmlk ZXMgPSAmZmItPnN0cmlkZXNbMF07Cj4gIAlpbnQgZmQgPSBmYi0+ZmQ7Cj4gIAo+ICAJLyogcmVz cGVjdCB0aGUgc2l6ZSByZXF1ZXN0ZWQgYnkgdGhlIGNhbGxlciAqLwo+IEBAIC01NjQsOCArNTY1 LDIyIEBAIHN0YXRpYyBpbnQgY3JlYXRlX2JvX2Zvcl9mYihzdHJ1Y3QgaWd0X2ZiICpmYikKPiAg CQkJCSAgICBwbGFuZSA/IGZtdC0+aHN1YiAqIGZtdC0+dnN1YiA6IDEpOwo+ICAKPiAgCWZiLT5p c19kdW1iID0gdHJ1ZTsKPiArCj4gKwkvKgo+ICsJICogV2UgY2FuJ3QgcmVhbGx5IHBhc3MgdGhl IHN0cmlkZSBhcnJheSBoZXJlIHNpbmNlIHRoZSBkdW1iCj4gKwkgKiBidWZmZXIgYWxsb2NhdGlv biBpcyBhc3N1bWluZyB0aGF0IGl0IG9wZXJhdGVzIG9uIG9uZQo+ICsJICogcGxhbmUsIGFuZCB0 aGVyZWZvcmUgd2lsbCBjYWxjdWxhdGUgdGhlIHN0cmlkZSBhcyBpZiBlYWNoCj4gKwkgKiBwaXhl bHMgd2VyZSBzdG9yZWQgb24gYSBzaW5nbGUgcGxhbmUuCj4gKwkgKgo+ICsJICogVGhpcyBtaWdo dCBjYXVzZSBpc3N1ZXMgYXQgc29tZSBwb2ludCBvbiBkcml2ZXJzIHRoYXQgd291bGQKPiArCSAq IGNoYW5nZSB0aGUgc3RyaWRlIG9mIFlVViBidWZmZXJzLCBidXQgd2UgaGF2ZW4ndAo+ICsJICog ZW5jb3VudGVyZWQgYW55IHlldC4KPiArCSAqLwo+ICsJaWYgKGZiLT5udW1fcGxhbmVzID4gMSkK PiArCQlzdHJpZGVzID0gTlVMTDsKPiArCj4gIAlmYi0+Z2VtX2hhbmRsZSA9IGttc3Rlc3RfZHVt Yl9jcmVhdGUoZmQsIGZiLT53aWR0aCwgZmItPmhlaWdodCwKPiAtCQkJCQkgICAgIGJwcCwgJmZi LT5zdHJpZGVzWzBdLCAmZmItPnNpemUpOwo+ICsJCQkJCSAgICAgYnBwLCBzdHJpZGVzLCAmZmIt PnNpemUpOwo+ICAKPiAgCXJldHVybiBmYi0+Z2VtX2hhbmRsZTsKPiAgfQotLSAKUGF1bCBLb2Np YWxrb3dza2ksIEJvb3RsaW4KRW1iZWRkZWQgTGludXggYW5kIGtlcm5lbCBlbmdpbmVlcmluZwpo dHRwczovL2Jvb3RsaW4uY29tCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1k ZXYK