Re: [igt-dev] [PATCH i-g-t] Stripping rendercopy implementation to use Cairo for restoring test image

[Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>]

Hi Srinivas,

I noticed your patch got stuck in CI with false positive failures, I 
forwarded the issue to Lakshminarayana Vudum. Once Lakshmi see my mail 
he'll mark those failures not to be about your patch and your patch will 
go on to shards testing.

About the patch otherwise, on subject line you should have note you're 
changing content in tests and which test. On this case subject would 
begin with 'tests/kms_cursor_crc: ...'

On 1.9.2020 18.33, Kamati Srinivas wrote:
> Cc: Landwerlin, Lionel G <lionel.g.landwerlin@intel.com>
> Cc: Heikkila, Juha-pekka <juha-pekka.heikkila@intel.com>
> Cc: Tejask Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
> Cc: K Srinivas <srinivasx.k@intel.com>
> Signed-off-by: Kamati Srinivas <srinivasx.k@intel.com>
> ---
>   tests/kms_cursor_crc.c | 10 +---------
>   1 file changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
> index e9491847..079abe88 100644
> --- a/tests/kms_cursor_crc.c
> +++ b/tests/kms_cursor_crc.c
> @@ -831,15 +831,7 @@ igt_main
>   
>   		igt_display_require(&data.display, data.drm_fd);
>   
> -		if (is_i915_device(data.drm_fd)) {
> -			data.bufmgr = drm_intel_bufmgr_gem_init(data.drm_fd, 4096);
> -			igt_assert(data.bufmgr);
> -			drm_intel_bufmgr_gem_enable_reuse(data.bufmgr);
> -
> -			data.devid = intel_get_drm_devid(data.drm_fd);
> -			data.rendercopy = igt_get_render_copyfunc(data.devid);
> -		}
> -		igt_debug("Using %s for restoring test image\n", (data.rendercopy == NULL)?"Cairo":"rendercopy");
> +		igt_debug("Using Cairo for restoring test image\n");

You'll need to remove all related dead code. I'd suggest you'll take out 
from data_t structure all variables which are for rendercopy and you'll 
see where compilation fail and from this you'll know where you need to 
go fix. Quickly looking at least those data.rendercopy, data.bufmgr 
which are mentioned in above code.

>   	}
>   
>   	data.cursor_max_w = cursor_width;
> 

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev