From: "Kahola, Mika" <mika.kahola@intel.com>
To: "Sripada, Radhakrishna" <radhakrishna.sripada@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH RFC i-g-t 02/10] lib/igt_fb.c: Update tile sizes for GEN12 CCS
Date: Wed, 30 Oct 2019 11:23:14 +0000 [thread overview]
Message-ID: <a451e2d3072ba02207df4e61a5fa93870ba0021e.camel@intel.com> (raw)
In-Reply-To: <20191029212517.GB15634@InViCtUs>
On Tue, 2019-10-29 at 14:25 -0700, Radhakrishna Sripada wrote:
> On Wed, Sep 25, 2019 at 04:09:23PM +0300, Mika Kahola wrote:
> > Update tile sizes for GEN12 CCS.
> >
> > BSpec: 2422
>
> BSpec:47709 - Gen12
I'll fix this. Thanks for pointing out the correct reference and for
the review!
> Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> >
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> > ---
> > lib/igt_fb.c | 34 ++++++++++++++++++++++++++++++++--
> > 1 file changed, 32 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> > index bad3eeca..826d9f70 100644
> > --- a/lib/igt_fb.c
> > +++ b/lib/igt_fb.c
> > @@ -381,6 +381,33 @@ void igt_get_fb_tile_size(int fd, uint64_t
> > modifier, int fb_bpp,
> > *height_ret = 32;
> > }
> > break;
> > + case LOCAL_I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS:
> > + igt_require_intel(fd);
> > + switch (fb_bpp) {
> > + case 8:
> > + *width_ret = 512;
> > + *height_ret = 32;
> > + break;
> > + case 16:
> > + *width_ret = 256;
> > + *height_ret = 32;
> > + break;
> > + case 32:
> > + *width_ret = 128;
> > + *height_ret = 32;
> > + break;
> > + case 64:
> > + *width_ret = 64;
> > + *height_ret = 32;
> > + break;
> > + case 128:
> > + *width_ret = 32;
> > + *height_ret = 32;
> > + break;
> > + default:
> > + igt_assert(false);
> > + }
> > + break;
> > case LOCAL_I915_FORMAT_MOD_Yf_TILED:
> > case LOCAL_I915_FORMAT_MOD_Yf_TILED_CCS:
> > igt_require_intel(fd);
> > @@ -435,8 +462,10 @@ void igt_get_fb_tile_size(int fd, uint64_t
> > modifier, int fb_bpp,
> >
> > static bool is_ccs_modifier(uint64_t modifier)
> > {
> > - return modifier == LOCAL_I915_FORMAT_MOD_Y_TILED_CCS ||
> > - modifier == LOCAL_I915_FORMAT_MOD_Yf_TILED_CCS;
> > +
> > + return modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS ||
> > + modifier == I915_FORMAT_MOD_Y_TILED_CCS ||
> > + modifier == I915_FORMAT_MOD_Yf_TILED_CCS;
> > }
> >
> > static unsigned fb_plane_width(const struct igt_fb *fb, int plane)
> > @@ -655,6 +684,7 @@ uint64_t igt_fb_mod_to_tiling(uint64_t
> > modifier)
> > return I915_TILING_X;
> > case LOCAL_I915_FORMAT_MOD_Y_TILED:
> > case LOCAL_I915_FORMAT_MOD_Y_TILED_CCS:
> > + case LOCAL_I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS:
> > return I915_TILING_Y;
> > case LOCAL_I915_FORMAT_MOD_Yf_TILED:
> > case LOCAL_I915_FORMAT_MOD_Yf_TILED_CCS:
> > --
> > 2.17.1
> >
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-10-30 11:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 13:09 [igt-dev] [PATCH RFC i-g-t 00/10] GEN12 render and media compression with Clear Color Mika Kahola
2019-09-25 13:09 ` [igt-dev] [PATCH RFC i-g-t 01/10] Format modifier for Intel Gen-12 render compression Mika Kahola
2019-10-29 21:26 ` Radhakrishna Sripada
2019-09-25 13:09 ` [igt-dev] [PATCH RFC i-g-t 02/10] lib/igt_fb.c: Update tile sizes for GEN12 CCS Mika Kahola
2019-10-29 21:25 ` Radhakrishna Sripada
2019-10-30 11:23 ` Kahola, Mika [this message]
2019-09-25 13:09 ` [igt-dev] [PATCH RFC i-g-t 03/10] tests/kms_ccs: Add GEN12 CCS render compression format modifiers Mika Kahola
2019-10-29 21:27 ` Radhakrishna Sripada
2019-10-30 13:47 ` Kahola, Mika
2019-10-30 13:55 ` Ville Syrjälä
2019-09-25 13:09 ` [igt-dev] [PATCH RFC i-g-t 04/10] Format modifier for Intel Gen-12 media compression Mika Kahola
2019-09-25 13:09 ` [igt-dev] [PATCH RFC i-g-t 05/10] lib/igt_fb.c: Update tile sizes for GEN12 MCS Mika Kahola
2019-09-25 13:09 ` [igt-dev] [PATCH RFC i-g-t 06/10] tests/kms_ccs: Add GEN12 CCS media compression format modifiers Mika Kahola
2019-09-25 13:09 ` [igt-dev] [PATCH RFC i-g-t 07/10] Format modifier for Gen-12 render engine with Color Clear Mika Kahola
2019-09-25 13:09 ` [igt-dev] [PATCH RFC i-g-t 08/10] lib/igt_fb.c: Update tile sizes for GEN12 " Mika Kahola
2019-10-29 21:31 ` Radhakrishna Sripada
2019-10-30 10:29 ` Kahola, Mika
2019-09-25 13:09 ` [igt-dev] [PATCH RFC i-g-t 09/10] tests/kms_ccs: Add GEN12 CCS Color Clear format modifiers Mika Kahola
2019-09-25 13:09 ` [igt-dev] [PATCH RFC i-g-t 10/10] tests/kms_getgfb: Update GEN12 CCS " Mika Kahola
2019-09-25 14:04 ` [igt-dev] ✓ Fi.CI.BAT: success for GEN12 render and media compression with Clear Color Patchwork
2019-09-26 4:23 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a451e2d3072ba02207df4e61a5fa93870ba0021e.camel@intel.com \
--to=mika.kahola@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=radhakrishna.sripada@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox