Re: [PATCH i-g-t v3 1/3] tests/chamelium/kms_chamelium_edid: Use extended flag to reduce the number of edid

["Joshi, Kunal1" <kunal1.joshi@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2408 bytes --]

Hello Pranay,

On 24-10-2024 13:57, Pranay Samala wrote:
> This test iterates on all the available edids of HDMI.
> Due to CI test timeut limitation, we are reducing the
> number of edids to execute to avoid result as timeout.
>
> Using extended flag to achieve this. The test will execute
> only 25 edids when this flag is not used as CI doesnt uses
> this flag.
> In local execution to execute on all edids, we have to give
> this flag at the runtime.
>
> Signed-off-by: Pranay Samala<pranay.samala@intel.com>
> ---
>   tests/chamelium/kms_chamelium_edid.c | 20 +++++++++++++++++++-
>   1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/tests/chamelium/kms_chamelium_edid.c b/tests/chamelium/kms_chamelium_edid.c
> index 8438f5f15..1bdde1768 100644
> --- a/tests/chamelium/kms_chamelium_edid.c
> +++ b/tests/chamelium/kms_chamelium_edid.c
> @@ -122,6 +122,7 @@
>    */
>   
>   #define MODE_CLOCK_ACCURACY 0.05 /* 5% */
> +static bool extended;
>   
>   static void get_connectors_link_status_failed(chamelium_data_t *data,
>   					      bool *link_status_failed)
> @@ -273,6 +274,9 @@ static void edid_stress_resolution(chamelium_data_t *data,
>   			      data->ports, data->port_count);
>   
>   
> +	if (!extended)
> +		edids_list_len = 25;
> +

Is there any environment variable that can be checked here instead of 
using extended?
If we can somehow know that this is a CI execution with some environment 
variable we can use that instead.
It will allow executing test without extended flag.

If we don't have any such env variable I am ok with this approach just 
add a info message to notify
user we are shortening the list also add a intel platform check.


Thanks and Regards Kunal Joshi

>   	for (i = 0; i < edids_list_len; ++i) {
>   		struct chamelium_edid *chamelium_edid;
>   		drmModeModeInfo mode;
> @@ -504,8 +508,22 @@ static void test_mode_timings(chamelium_data_t *data,
>   	} while (++i < count_modes);
>   }
>   
> +static int opt_handler(int opt, int opt_index, void *_data)
> +{
> +	switch (opt) {
> +	case 'e':
> +		extended = true;
> +		break;
> +	}
> +
> +	return IGT_OPT_HANDLER_SUCCESS;
> +}
> +
> +const char *help_str =
> +	"  -e \tExtended tests.\n";
> +
>   IGT_TEST_DESCRIPTION("Testing EDID with a Chamelium board");
> -igt_main
> +igt_main_args("e", NULL, help_str, opt_handler, NULL)
>   {
>   	chamelium_data_t data;
>   	struct chamelium_port *port;

[-- Attachment #2: Type: text/html, Size: 3125 bytes --]