Re: [PATCH] core: add timestamps to logs

["Hajda, Andrzej" <andrzej.hajda@intel.com>]

W dniu 6.05.2026 o 16:25, Kamil Konieczny pisze:
> Hi Andrzej,
> On 2026-05-05 at 16:46:27 +0200, Andrzej Hajda wrote:
> 
> please use longer prefix, also these changes only debug logs,
> so imho better subject:
> 
> [PATCH] lib/igt_core: add timestamps to error logs

OK

> 
> See for example results here:
> https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15100/shard-lnl-2/igt@core_auth@many-magics.html
> 
>> IGT tests run often time consuming tasks. Timestamps should simplify
>> time analysis and matching with kernel logs.
>> Since IGT is closely connected with the kernel let's use the same format.
>>
>> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
>> ---
>>   lib/igt_core.c | 13 +++++++++----
>>   1 file changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/lib/igt_core.c b/lib/igt_core.c
>> index 4f79c02948ab..e11b181e7a82 100644
>> --- a/lib/igt_core.c
>> +++ b/lib/igt_core.c
>> @@ -3227,10 +3227,15 @@ void igt_vlog(const char *domain, enum igt_log_level level, const char *format,
>>   		formatted_line = strdup(line);
>>   		if (!formatted_line)
>>   			goto out;
>> -	} else if (asprintf(&formatted_line, "(%s:%d) %s%s%s%s: %s", program_name,
>> -		     getpid(), thread_id, (domain) ? domain : "", (domain) ? "-" : "",
>> -		     igt_log_level_str[level], line) == -1) {
>> -		goto out;
>> +	} else {
>> +		struct timespec ts;
>> +
>> +		igt_gettime(&ts);
>> +		if (asprintf(&formatted_line, "[%5ld.%06ld] (%s:%d) %s%s%s%s: %s", (long)ts.tv_sec,
> 
> Can you align it to igt_runner format? It is %ld.%06ld
> see grep 6ld runner/*.c

OK. Looks better.

Regards
Andrzej

> 
> Regards,
> Kamil
> 
>> +			     ts.tv_nsec / 1000, program_name, getpid(), thread_id,
>> +			     (domain) ? domain : "", (domain) ? "-" : "", igt_log_level_str[level],
>> +			     line) == -1)
>> +			goto out;
>>   	}
>>   
>>   	if (line[strlen(line) - 1] == '\n')
>>
>> ---
>> base-commit: 8eb6e58f00d39b3bb79ffc501eb020b36c8f8c31
>> change-id: 20260430-add_timestamps_to_logs-d84fdfd7ef4c
>>
>> Best regards,
>> --
>> Andrzej Hajda <andrzej.hajda@intel.com>
>>