From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2060f.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe59::60f]) by gabe.freedesktop.org (Postfix) with ESMTPS id A69ED10E0B5 for ; Tue, 22 Aug 2023 20:57:56 +0000 (UTC) Message-ID: Date: Tue, 22 Aug 2023 16:57:54 -0400 Content-Language: en-US To: Kamil Konieczny , igt-dev@lists.freedesktop.org, hersenxs.wu@amd.com, Ashutosh Dixit , Petri Latvala References: <20230822201833.29474-1-aurabindo.pillai@amd.com> <20230822204709.zuoxonzyn5ij42jy@kamilkon-desk.igk.intel.com> From: Aurabindo Pillai In-Reply-To: <20230822204709.zuoxonzyn5ij42jy@kamilkon-desk.igk.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH v4] tests/amdgpu: Fix build error due to external file include List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 2023-08-22 16:47, Kamil Konieczny wrote: > Hi Aurabindo, > > On 2023-08-22 at 16:18:33 -0400, Aurabindo Pillai wrote: >> Remove the external file include that causes build error >> on certain systems configured in the CI. >> >> Signed-off-by: Aurabindo Pillai >> --- >> tests/amdgpu/amd_odm.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/tests/amdgpu/amd_odm.c b/tests/amdgpu/amd_odm.c >> index 2781ad1c2..839f2de3f 100644 >> --- a/tests/amdgpu/amd_odm.c >> +++ b/tests/amdgpu/amd_odm.c >> @@ -5,7 +5,6 @@ >> >> #include >> #include >> -#include > > Acked-by: Kamil Konieczny > > Will this test work without xf86drmMode.h? > If it is kms test you may just include igt_kms.h but first > apply fix (or revert). Yes, looks like IGT already includes all the necessary headers. > > Regards, > Kamil > >> >> #include "igt.h" >> #include "igt_amd.h" >> -- >> 2.41.0 >> -- -- Thanks & Regards, Jay