Re: [igt-dev] [PATCH i-g-t] lib/intel_batchbuffer: Media VME kernel is valid only for Gen11

["Ye, Tony" <tony.ye@intel.com>]

The kernel was design for Gen11 and the author didn't guarantee it could 
work on APL. And the binary was built with iga64 with "-p=11" option. If 
you try to build it with "-p=9" you will get "error: NoPreempt not 
supported on given platform".
As the purpose of this test was to test the asymmetric subslice of 
Gen11, I would suggest to remove the support of Gen9 and Gen10. The 
patch looks good to me.

Regards,

Tony

On 2/25/2019 7:57 PM, Tvrtko Ursulin wrote:
>
> On 25/02/2019 11:55, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Do not use it on older gens.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109612
>
> Regards,
>
> Tvrtko
>
>> Cc: Tony Ye <tony.ye@intel.com>
>> ---
>>   lib/intel_batchbuffer.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
>> index b2169a1aa145..6e6bcdeba8a6 100644
>> --- a/lib/intel_batchbuffer.c
>> +++ b/lib/intel_batchbuffer.c
>> @@ -877,7 +877,7 @@ igt_vme_func_t igt_get_media_vme_func(int devid)
>>   {
>>       igt_vme_func_t fill = NULL;
>>   -    if (IS_GEN9(devid) || IS_GEN10(devid) || IS_GEN11(devid))
>> +    if (IS_GEN11(devid))
>>           fill = gen11_media_vme_func;
>>         return fill;
>>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev