Hi Santhosh,

Hi Pranay,

On 04-02-2026 14:09, Pranay Samala wrote:

Skip modifier subtests that are not supported.

Signed-off-by: Pranay Samala <pranay.samala@intel.com>
---
  tests/kms_plane.c | 8 ++++++++
  1 file changed, 8 insertions(+)

diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index a7b1bf25d..69d06d627 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -1495,6 +1495,10 @@ run_tests_for_pipe_plane(data_t *data)
      for (int i = 0; i < ARRAY_SIZE(modifiers); i++) {
          igt_describe("verify the pixel formats for given plane and pipe");
          igt_subtest_with_dynamic_f("pixel-format-%s-modifier", modifiers[i].str) {
+            igt_require_f(igt_display_has_format_mod(&data->display,
+                                 DRM_FORMAT_XRGB8888,
+                                 modifiers[i].modifier),
+                                 "Modifier not supported\n");

This looks to be a redundant check here , as the same is handled in test_format_plane. 

igt_skip_on_f(!found,
              "Modifier " IGT_MODIFIER_FMT " not supported on plane %d\n",
              IGT_MODIFIER_ARGS(data->mod), plane->index);

Thanks,
Santhosh

              data->mod = modifiers[i].modifier;
              run_test(data, test_pixel_formats);
          }
@@ -1504,6 +1508,10 @@ run_tests_for_pipe_plane(data_t *data)
          igt_describe("verify the pixel formats for given plane and pipe with source clamping");
          igt_subtest_with_dynamic_f("pixel-format-%s-modifier-source-clamping",
                         modifiers[i].str) {
+            igt_require_f(igt_display_has_format_mod(&data->display,
+                                 DRM_FORMAT_XRGB8888,
+                                 modifiers[i].modifier),
+                                 "Modifier not supported\n");
              data->mod = modifiers[i].modifier;
              data->crop = 4;
              run_test(data, test_pixel_formats);