[PATCH i-g-t] xe-ci: Disable xe_evict subtests that are expected to possibly fail

[PATCH i-g-t] xe-ci: Disable xe_evict subtests that are expected to possibly fail

[Thomas Hellström]

Threads may compete over VRAM resources, and since there is no
serialization in TTM, threaded evict tests may have a high
possibility of failing.

Disable such tests until we have a working exhaustive eviction
implementation in place.

Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: <akshata.jahagirdar@intel.com>
---
 tests/intel-ci/xe-fast-feedback.testlist | 5 -----
 tests/intel-ci/xe.blocklist.txt          | 7 +++++++
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
index 727be9230..f16ca9188 100644
--- a/tests/intel-ci/xe-fast-feedback.testlist
+++ b/tests/intel-ci/xe-fast-feedback.testlist
@@ -263,19 +263,14 @@ igt@xe_exec_threads@threads-mixed-shared-vm-basic
 igt@xe_exec_threads@threads-mixed-fd-basic
 igt@xe_exec_threads@threads-mixed-userptr-invalidate
 igt@xe_exec_threads@threads-mixed-shared-vm-userptr-invalidate-race
-igt@xe_evict@evict-beng-mixed-threads-small-multi-vm
 igt@xe_evict@evict-beng-small
 igt@xe_evict@evict-beng-small-cm
 igt@xe_evict@evict-beng-small-external
 igt@xe_evict@evict-beng-small-external-cm
 igt@xe_evict@evict-beng-small-multi-vm
 igt@xe_evict@evict-cm-threads-small
-igt@xe_evict@evict-mixed-threads-small
-igt@xe_evict@evict-mixed-threads-small-multi-vm
 igt@xe_evict@evict-small
 igt@xe_evict@evict-small-cm
 igt@xe_evict@evict-small-external
 igt@xe_evict@evict-small-external-cm
 igt@xe_evict@evict-small-multi-vm
-igt@xe_evict@evict-small-multi-vm-cm
-igt@xe_evict@evict-threads-small
diff --git a/tests/intel-ci/xe.blocklist.txt b/tests/intel-ci/xe.blocklist.txt
index e29e745a0..ed9e572a5 100644
--- a/tests/intel-ci/xe.blocklist.txt
+++ b/tests/intel-ci/xe.blocklist.txt
@@ -90,3 +90,10 @@ igt@sriov_basic@enable-vfs-autoprobe-on$
 igt@sriov_basic@enable-vfs-bind-unbind-each$
 igt@sriov_basic@bind-unbind-vf$
 ##################################################################
+# Exclude xe_evict tests that are not expected to succeed
+# due to missing TTM exhaustive eviction
+##################################################################
+igt@xe_evict@*-multi-vm-cm*
+igt@xe_evict@*-threads-*
+# igt@xe_evict@*-cm* # Rebind and VM_BIND may race.
+##################################################################
-- 
2.47.1

Re: [PATCH i-g-t] xe-ci: Disable xe_evict subtests that are expected to possibly fail

[Nirmoy Das]

On 12/18/2024 1:45 PM, Thomas Hellström wrote:
> Threads may compete over VRAM resources, and since there is no
> serialization in TTM, threaded evict tests may have a high
> possibility of failing.
>
> Disable such tests until we have a working exhaustive eviction
> implementation in place.
>
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: <akshata.jahagirdar@intel.com>

Saw many failures of these tests on BMG


Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
>  tests/intel-ci/xe-fast-feedback.testlist | 5 -----
>  tests/intel-ci/xe.blocklist.txt          | 7 +++++++
>  2 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
> index 727be9230..f16ca9188 100644
> --- a/tests/intel-ci/xe-fast-feedback.testlist
> +++ b/tests/intel-ci/xe-fast-feedback.testlist
> @@ -263,19 +263,14 @@ igt@xe_exec_threads@threads-mixed-shared-vm-basic
>  igt@xe_exec_threads@threads-mixed-fd-basic
>  igt@xe_exec_threads@threads-mixed-userptr-invalidate
>  igt@xe_exec_threads@threads-mixed-shared-vm-userptr-invalidate-race
> -igt@xe_evict@evict-beng-mixed-threads-small-multi-vm
>  igt@xe_evict@evict-beng-small
>  igt@xe_evict@evict-beng-small-cm
>  igt@xe_evict@evict-beng-small-external
>  igt@xe_evict@evict-beng-small-external-cm
>  igt@xe_evict@evict-beng-small-multi-vm
>  igt@xe_evict@evict-cm-threads-small
> -igt@xe_evict@evict-mixed-threads-small
> -igt@xe_evict@evict-mixed-threads-small-multi-vm
>  igt@xe_evict@evict-small
>  igt@xe_evict@evict-small-cm
>  igt@xe_evict@evict-small-external
>  igt@xe_evict@evict-small-external-cm
>  igt@xe_evict@evict-small-multi-vm
> -igt@xe_evict@evict-small-multi-vm-cm
> -igt@xe_evict@evict-threads-small
> diff --git a/tests/intel-ci/xe.blocklist.txt b/tests/intel-ci/xe.blocklist.txt
> index e29e745a0..ed9e572a5 100644
> --- a/tests/intel-ci/xe.blocklist.txt
> +++ b/tests/intel-ci/xe.blocklist.txt
> @@ -90,3 +90,10 @@ igt@sriov_basic@enable-vfs-autoprobe-on$
>  igt@sriov_basic@enable-vfs-bind-unbind-each$
>  igt@sriov_basic@bind-unbind-vf$
>  ##################################################################
> +# Exclude xe_evict tests that are not expected to succeed
> +# due to missing TTM exhaustive eviction
> +##################################################################
> +igt@xe_evict@*-multi-vm-cm*
> +igt@xe_evict@*-threads-*
> +# igt@xe_evict@*-cm* # Rebind and VM_BIND may race.
> +##################################################################

Re: [PATCH i-g-t] xe-ci: Disable xe_evict subtests that are expected to possibly fail

[Kamil Konieczny]

Hi Thomas,
On 2024-12-18 at 13:45:19 +0100, Thomas Hellström wrote:
> Threads may compete over VRAM resources, and since there is no
> serialization in TTM, threaded evict tests may have a high
> possibility of failing.
> 
> Disable such tests until we have a working exhaustive eviction
> implementation in place.
> 
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: <akshata.jahagirdar@intel.com>

Looks reasonable, please only change prefix into
tests/intel-ci/xe*:

also consider writing it a little shorter, like:
[PATCH i-g-t] tests/intel-ci/xe*: Disable few xe_evict subtests

With this
Acked-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

Please also see one nit below.

> ---
>  tests/intel-ci/xe-fast-feedback.testlist | 5 -----
>  tests/intel-ci/xe.blocklist.txt          | 7 +++++++
>  2 files changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
> index 727be9230..f16ca9188 100644
> --- a/tests/intel-ci/xe-fast-feedback.testlist
> +++ b/tests/intel-ci/xe-fast-feedback.testlist
> @@ -263,19 +263,14 @@ igt@xe_exec_threads@threads-mixed-shared-vm-basic
>  igt@xe_exec_threads@threads-mixed-fd-basic
>  igt@xe_exec_threads@threads-mixed-userptr-invalidate
>  igt@xe_exec_threads@threads-mixed-shared-vm-userptr-invalidate-race
> -igt@xe_evict@evict-beng-mixed-threads-small-multi-vm
>  igt@xe_evict@evict-beng-small
>  igt@xe_evict@evict-beng-small-cm
>  igt@xe_evict@evict-beng-small-external
>  igt@xe_evict@evict-beng-small-external-cm
>  igt@xe_evict@evict-beng-small-multi-vm
>  igt@xe_evict@evict-cm-threads-small
> -igt@xe_evict@evict-mixed-threads-small
> -igt@xe_evict@evict-mixed-threads-small-multi-vm
>  igt@xe_evict@evict-small
>  igt@xe_evict@evict-small-cm
>  igt@xe_evict@evict-small-external
>  igt@xe_evict@evict-small-external-cm
>  igt@xe_evict@evict-small-multi-vm
> -igt@xe_evict@evict-small-multi-vm-cm
> -igt@xe_evict@evict-threads-small
> diff --git a/tests/intel-ci/xe.blocklist.txt b/tests/intel-ci/xe.blocklist.txt
> index e29e745a0..ed9e572a5 100644
> --- a/tests/intel-ci/xe.blocklist.txt
> +++ b/tests/intel-ci/xe.blocklist.txt
> @@ -90,3 +90,10 @@ igt@sriov_basic@enable-vfs-autoprobe-on$
>  igt@sriov_basic@enable-vfs-bind-unbind-each$
>  igt@sriov_basic@bind-unbind-vf$
>  ##################################################################
> +# Exclude xe_evict tests that are not expected to succeed
> +# due to missing TTM exhaustive eviction
> +##################################################################
> +igt@xe_evict@*-multi-vm-cm*
> +igt@xe_evict@*-threads-*
> +# igt@xe_evict@*-cm* # Rebind and VM_BIND may race.

Did you mean that
igt@xe_evict@evict-cm-threads-small

should stay in BAT?

Regards,
Kamil

> +##################################################################
> -- 
> 2.47.1
> 

Re: [PATCH i-g-t] xe-ci: Disable xe_evict subtests that are expected to possibly fail

[Jahagirdar, Akshata]

On 12/18/2024 4:45 AM, Thomas Hellström wrote:
> Threads may compete over VRAM resources, and since there is no
> serialization in TTM, threaded evict tests may have a high
> possibility of failing.
>
> Disable such tests until we have a working exhaustive eviction
> implementation in place.
>
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: <akshata.jahagirdar@intel.com>
> ---
>   tests/intel-ci/xe-fast-feedback.testlist | 5 -----
>   tests/intel-ci/xe.blocklist.txt          | 7 +++++++
>   2 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
> index 727be9230..f16ca9188 100644
> --- a/tests/intel-ci/xe-fast-feedback.testlist
> +++ b/tests/intel-ci/xe-fast-feedback.testlist
> @@ -263,19 +263,14 @@ igt@xe_exec_threads@threads-mixed-shared-vm-basic
>   igt@xe_exec_threads@threads-mixed-fd-basic
>   igt@xe_exec_threads@threads-mixed-userptr-invalidate
>   igt@xe_exec_threads@threads-mixed-shared-vm-userptr-invalidate-race
> -igt@xe_evict@evict-beng-mixed-threads-small-multi-vm
>   igt@xe_evict@evict-beng-small
>   igt@xe_evict@evict-beng-small-cm
>   igt@xe_evict@evict-beng-small-external
>   igt@xe_evict@evict-beng-small-external-cm
>   igt@xe_evict@evict-beng-small-multi-vm
>   igt@xe_evict@evict-cm-threads-small
> -igt@xe_evict@evict-mixed-threads-small
> -igt@xe_evict@evict-mixed-threads-small-multi-vm
>   igt@xe_evict@evict-small
>   igt@xe_evict@evict-small-cm
>   igt@xe_evict@evict-small-external
>   igt@xe_evict@evict-small-external-cm
>   igt@xe_evict@evict-small-multi-vm
> -igt@xe_evict@evict-small-multi-vm-cm
> -igt@xe_evict@evict-threads-small
There seem to be multiple issues pertaining to these tests.
Reviewed-by: Akshata Jahagirdar <akshata.jahagirdar@intel.com>

> diff --git a/tests/intel-ci/xe.blocklist.txt b/tests/intel-ci/xe.blocklist.txt
> index e29e745a0..ed9e572a5 100644
> --- a/tests/intel-ci/xe.blocklist.txt
> +++ b/tests/intel-ci/xe.blocklist.txt
> @@ -90,3 +90,10 @@ igt@sriov_basic@enable-vfs-autoprobe-on$
>   igt@sriov_basic@enable-vfs-bind-unbind-each$
>   igt@sriov_basic@bind-unbind-vf$
>   ##################################################################
> +# Exclude xe_evict tests that are not expected to succeed
> +# due to missing TTM exhaustive eviction
> +##################################################################
> +igt@xe_evict@*-multi-vm-cm*
> +igt@xe_evict@*-threads-*
> +# igt@xe_evict@*-cm* # Rebind and VM_BIND may race.
> +##################################################################

Re: [PATCH i-g-t] xe-ci: Disable xe_evict subtests that are expected to possibly fail

[Thomas Hellström]

On Wed, 2024-12-18 at 15:18 +0100, Kamil Konieczny wrote:
> Hi Thomas,
> On 2024-12-18 at 13:45:19 +0100, Thomas Hellström wrote:
> > Threads may compete over VRAM resources, and since there is no
> > serialization in TTM, threaded evict tests may have a high
> > possibility of failing.
> > 
> > Disable such tests until we have a working exhaustive eviction
> > implementation in place.
> > 
> > Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> > Cc: Matthew Brost <matthew.brost@intel.com>
> > Cc: <akshata.jahagirdar@intel.com>
> 
> Looks reasonable, please only change prefix into
> tests/intel-ci/xe*:
> 
> also consider writing it a little shorter, like:
> [PATCH i-g-t] tests/intel-ci/xe*: Disable few xe_evict subtests
> 
> With this
> Acked-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> 
> Please also see one nit below.
> 
> > ---
> >  tests/intel-ci/xe-fast-feedback.testlist | 5 -----
> >  tests/intel-ci/xe.blocklist.txt          | 7 +++++++
> >  2 files changed, 7 insertions(+), 5 deletions(-)
> > 
> > diff --git a/tests/intel-ci/xe-fast-feedback.testlist
> > b/tests/intel-ci/xe-fast-feedback.testlist
> > index 727be9230..f16ca9188 100644
> > --- a/tests/intel-ci/xe-fast-feedback.testlist
> > +++ b/tests/intel-ci/xe-fast-feedback.testlist
> > @@ -263,19 +263,14 @@
> > igt@xe_exec_threads@threads-mixed-shared-vm-basic
> >  igt@xe_exec_threads@threads-mixed-fd-basic
> >  igt@xe_exec_threads@threads-mixed-userptr-invalidate
> >  
> > igt@xe_exec_threads@threads-mixed-shared-vm-userptr-invalidate-race
> > -igt@xe_evict@evict-beng-mixed-threads-small-multi-vm
> >  igt@xe_evict@evict-beng-small
> >  igt@xe_evict@evict-beng-small-cm
> >  igt@xe_evict@evict-beng-small-external
> >  igt@xe_evict@evict-beng-small-external-cm
> >  igt@xe_evict@evict-beng-small-multi-vm
> >  igt@xe_evict@evict-cm-threads-small
> > -igt@xe_evict@evict-mixed-threads-small
> > -igt@xe_evict@evict-mixed-threads-small-multi-vm
> >  igt@xe_evict@evict-small
> >  igt@xe_evict@evict-small-cm
> >  igt@xe_evict@evict-small-external
> >  igt@xe_evict@evict-small-external-cm
> >  igt@xe_evict@evict-small-multi-vm
> > -igt@xe_evict@evict-small-multi-vm-cm
> > -igt@xe_evict@evict-threads-small
> > diff --git a/tests/intel-ci/xe.blocklist.txt b/tests/intel-
> > ci/xe.blocklist.txt
> > index e29e745a0..ed9e572a5 100644
> > --- a/tests/intel-ci/xe.blocklist.txt
> > +++ b/tests/intel-ci/xe.blocklist.txt
> > @@ -90,3 +90,10 @@ igt@sriov_basic@enable-vfs-autoprobe-on$
> >  igt@sriov_basic@enable-vfs-bind-unbind-each$
> >  igt@sriov_basic@bind-unbind-vf$
> >  ##################################################################
> > +# Exclude xe_evict tests that are not expected to succeed
> > +# due to missing TTM exhaustive eviction
> > +##################################################################
> > +igt@xe_evict@*-multi-vm-cm*
> > +igt@xe_evict@*-threads-*
> > +# igt@xe_evict@*-cm* # Rebind and VM_BIND may race.
> 
> Did you mean that
> igt@xe_evict@evict-cm-threads-small
> 
> should stay in BAT?

No it shouldn't. Good catch. I'll update.

> 
> Regards,
> Kamil
> 
> > +##################################################################
> > -- 
> > 2.47.1
> >