Re: [PATCH v2 i-g-t 1/4] tests/intel/xe_sriov_vfio: Add VFIO module load/unload subtest

["Laguna, Lukasz" <lukasz.laguna@intel.com>]

On 3/27/2026 15:06, Marcin Bernatowicz wrote:
> Introduce the load-unload-xe-vfio-pci subtest to verify that the
> xe_vfio_pci module can be loaded and unloaded. Skip the test when the
> module is already loaded.
>
> Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
> Cc: Adam Miszczak <adam.miszczak@linux.intel.com>
> Cc: Jakub Kolakowski <jakub1.kolakowski@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Cc: Lukasz Laguna <lukasz.laguna@intel.com>

Reviewed-by: Lukasz Laguna <lukasz.laguna@intel.com>

> ---
> v2:
> - Merge load/unload into a single subtest (Lukasz)
> - Simplify restore_xe_vfio_module  (Lukasz)
> ---
>   tests/intel/xe_sriov_vfio.c | 75 +++++++++++++++++++++++++++++++++++++
>   tests/meson.build           |  1 +
>   2 files changed, 76 insertions(+)
>   create mode 100644 tests/intel/xe_sriov_vfio.c
>
> diff --git a/tests/intel/xe_sriov_vfio.c b/tests/intel/xe_sriov_vfio.c
> new file mode 100644
> index 000000000..ef92fb233
> --- /dev/null
> +++ b/tests/intel/xe_sriov_vfio.c
> @@ -0,0 +1,75 @@
> +// SPDX-License-Identifier: MIT
> +/*
> + * Copyright(c) 2026 Intel Corporation. All rights reserved.
> + */
> +
> +#include "igt_core.h"
> +#include "igt_kmod.h"
> +
> +/**
> + * TEST: xe_sriov_vfio
> + * Category: Core
> + * Mega feature: SR-IOV
> + * Sub-category: SR-IOV VFIO
> + * Functionality: VFIO module
> + * Description: Verify basic xe-vfio-pci module operations.
> + *
> + * SUBTEST: load-unload-xe-vfio-pci
> + * Description: Attempt to load xe_vfio_pci module and then unload it.
> + */
> +
> +IGT_TEST_DESCRIPTION("Xe SR-IOV VFIO tests (xe-vfio-pci)");
> +
> +static const char *XE_VFIO_PCI_MOD = "xe_vfio_pci";
> +
> +static bool xe_vfio_loaded_initially;
> +
> +static void restore_xe_vfio_module(void)
> +{
> +	bool loaded;
> +	int ret;
> +
> +	loaded = igt_kmod_is_loaded(XE_VFIO_PCI_MOD);
> +
> +	if (loaded != xe_vfio_loaded_initially) {
> +		ret = xe_vfio_loaded_initially ?
> +			igt_kmod_load(XE_VFIO_PCI_MOD, NULL) :
> +			igt_kmod_unload(XE_VFIO_PCI_MOD);
> +		igt_abort_on_f(ret,
> +			       "Failed to %s %s during cleanup\n",
> +			       xe_vfio_loaded_initially ? "load" : "unload",
> +			       XE_VFIO_PCI_MOD);
> +		loaded = igt_kmod_is_loaded(XE_VFIO_PCI_MOD);
> +	}
> +
> +	igt_abort_on_f(loaded != xe_vfio_loaded_initially,
> +		       "%s should be %s after cleanup\n",
> +		       XE_VFIO_PCI_MOD,
> +		       xe_vfio_loaded_initially ? "loaded" : "unloaded");
> +}
> +
> +int igt_main()
> +{
> +	igt_fixture() {
> +		xe_vfio_loaded_initially = igt_kmod_is_loaded(XE_VFIO_PCI_MOD);
> +	}
> +
> +	igt_describe("Attempt to load xe_vfio_pci module and then unload it.");
> +	igt_subtest("load-unload-xe-vfio-pci") {
> +		int ret;
> +
> +		igt_skip_on(xe_vfio_loaded_initially);
> +
> +		ret = igt_kmod_load(XE_VFIO_PCI_MOD, NULL);
> +		igt_assert_f(ret == 0, "Failed to load %s (%d)\n", XE_VFIO_PCI_MOD, ret);
> +		igt_assert(igt_kmod_is_loaded(XE_VFIO_PCI_MOD));
> +
> +		ret = igt_kmod_unload(XE_VFIO_PCI_MOD);
> +		igt_assert_f(ret == 0, "Failed to unload %s (%d)\n", XE_VFIO_PCI_MOD, ret);
> +		igt_assert(igt_kmod_is_loaded(XE_VFIO_PCI_MOD) == false);
> +	}
> +
> +	igt_fixture() {
> +		restore_xe_vfio_module();
> +	}
> +}
> diff --git a/tests/meson.build b/tests/meson.build
> index cecb4a8ae..26d9345ec 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -337,6 +337,7 @@ intel_xe_progs = [
>   	'xe_sriov_admin',
>   	'xe_sriov_auto_provisioning',
>   	'xe_sriov_flr',
> +	'xe_sriov_vfio',
>   	'xe_sriov_scheduling',
>           'xe_survivability',
>   	'xe_sriov_vram',