Re: [igt-dev] [PATCH i-g-t] tests/kms_content_protection: rename subtests

["Sharma, Swati2" <swati2.sharma@intel.com>]

On 20-Sep-23 1:30 PM, Kamil Konieczny wrote:
> Hi Swati,
> 
> On 2023-09-18 at 15:41:50 +0530, Swati Sharma wrote:
>> Use '-' instead of '_' while naming subtests and subtest name
>> should use small case.
>>
>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>> ---
>>   tests/kms_content_protection.c | 12 ++++++------
>>   1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/tests/kms_content_protection.c b/tests/kms_content_protection.c
>> index 9378a76c1..ea0c4a0ab 100644
>> --- a/tests/kms_content_protection.c
>> +++ b/tests/kms_content_protection.c
>> @@ -491,14 +491,14 @@ test_fini(igt_output_t *output, enum igt_commit_style s)
>>   }
>>   
>>   /**
>> - * SUBTEST: LIC
>> + * SUBTEST: lic
>>    * Description: Test for the integrity of link.
>>    * Driver requirement: i915, xe
>>    * Functionality: hdcp1.4
>>    * Mega feature: HDCP
>>    * Test category: functionality test
>>    *
>> - * SUBTEST: content_type_change
>> + * SUBTEST: content-type-change
> 
> imho this may be also just spaces (the same goes for TEST name).
> If in doubt please ask Mauro, +cc Mauro, this may be:
> 
>    * SUBTEST: content type change
> 
> testplan.py should fill proper delimiter here. Other changes are ok,

Hi Kamil,

Thanks for the review. Even if we have above case, i will still go with 
'-' delimiter since all kms tests have this delimiter. I don't want to 
change only for this case.

> 
> Regards,
> Kamil
> 
>>    * Description: Test the content type change when the content protection already
>>    *              enabled
>>    * Driver requirement: i915, xe
>> @@ -506,7 +506,7 @@ test_fini(igt_output_t *output, enum igt_commit_style s)
>>    * Mega feature: HDCP
>>    * Test category: functionality test
>>    *
>> - * SUBTEST: mei_interface
>> + * SUBTEST: mei-interface
>>    * Description: Test the teardown and rebuild of the interface between Intel
>>    *              and mei hdcp.
>>    * Driver requirement: i915, xe
>> @@ -802,7 +802,7 @@ static const struct {
>>   	  .content_type = HDCP_CONTENT_TYPE_0
>>   	},
>>   	{ .desc = "Test for the integrity of link.",
>> -	  .name = "LIC",
>> +	  .name = "lic",
>>   	  .cp_tests = CP_LIC,
>>   	  .content_type = HDCP_CONTENT_TYPE_0,
>>   	},
>> @@ -814,12 +814,12 @@ static const struct {
>>   	},
>>   	{ .desc = "Test the teardown and rebuild of the interface between "
>>   		  "Intel and mei hdcp.",
>> -	  .name = "mei_interface",
>> +	  .name = "mei-interface",
>>   	  .cp_tests = CP_MEI_RELOAD,
>>   	  .content_type = HDCP_CONTENT_TYPE_1,
>>   	},
>>   	{ .desc = "Test the content type change when the content protection already enabled",
>> -	  .name = "content_type_change",
>> +	  .name = "content-type-change",
>>   	  .cp_tests = CP_TYPE_CHANGE,
>>   	  .content_type = HDCP_CONTENT_TYPE_1,
>>   	},
>> -- 
>> 2.25.1
>>