[igt-dev] [PATCH i-g-t 1/2] lib: intel: report GT size from the database if available

[igt-dev] [PATCH i-g-t 1/2] lib: intel: report GT size from the database if available

[Lionel Landwerlin]

The scheme if getting the GT size from the PCI-id doesn't work anymore
on Coffeelake.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105451, https://bugs.freedesktop.org/show_bug.cgi?id=101740
---
 lib/intel_device_info.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
index 1c710733..c104c9c4 100644
--- a/lib/intel_device_info.c
+++ b/lib/intel_device_info.c
@@ -410,8 +410,17 @@ unsigned intel_gen(uint16_t devid)
  */
 unsigned intel_gt(uint16_t devid)
 {
+	const struct intel_device_info *devinfo = intel_get_device_info(devid);
 	unsigned mask = intel_gen(devid);
 
+	/* If in the database, just use that information. */
+	if (devinfo->gt != 0)
+		return devinfo->gt - 1;
+
+	/*
+	 * This scheme doesn't work on Coffeelake, we should probably
+	 * not rely on this anymore.
+	 */
 	if (mask >= 8)
 		mask = 0xf;
 	else if (mask >= 6)
-- 
2.16.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 2/2] tests/perf: print out GT size if unknown

[Lionel Landwerlin]

Developers are running into issues on CFL where the GT size isn't
recognized. Let's print it out to make it easier to debug from the CI
traces.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
 tests/perf.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/tests/perf.c b/tests/perf.c
index 6d8ff578..5ad30bb8 100644
--- a/tests/perf.c
+++ b/tests/perf.c
@@ -925,7 +925,8 @@ init_sys_info(void)
 				test_set_uuid = "882fa433-1f4a-4a67-a962-c741888fe5f5";
 				break;
 			default:
-				igt_debug("unsupported Skylake GT size\n");
+				igt_debug("unsupported Skylake GT%d size\n",
+					  intel_gt(devid) + 1);
 				return false;
 			}
 		} else if (IS_BROXTON(devid)) {
@@ -939,7 +940,8 @@ init_sys_info(void)
 				test_set_uuid = "f1792f32-6db2-4b50-b4b2-557128f1688d";
 				break;
 			default:
-				igt_debug("unsupported Kabylake GT size\n");
+				igt_debug("unsupported Kabylake GT%d\n",
+					  intel_gt(devid) + 1);
 				return false;
 			}
 		} else if (IS_GEMINILAKE(devid)) {
@@ -953,7 +955,8 @@ init_sys_info(void)
 				test_set_uuid = "577e8e2c-3fa0-4875-8743-3538d585e3b0";
 				break;
 			default:
-				igt_debug("unsupported Coffeelake GT size\n");
+				igt_debug("unsupported Coffeelake GT%d\n",
+					  intel_gt(devid) + 1);
 				return false;
 			}
 		} else if (IS_CANNONLAKE(devid)) {
-- 
2.16.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib: intel: report GT size from the database if available

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/2] lib: intel: report GT size from the database if available
URL   : https://patchwork.freedesktop.org/series/40278/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
178e7f3da66cd02660a86257df75708a0efa3bbc tests/kms_frontbuffer_tracking: Update check for PSR status

with latest DRM-Tip kernel build CI_DRM_3958
9d737cebc219 drm-tip: 2018y-03m-20d-14h-56m-05s UTC integration manifest

No testlist changes.

---- Possible new issues:

Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                incomplete -> PASS       (fi-cfl-s2)

---- Known issues:

Test gem_mmap_gtt:
        Subgroup basic-small-bo-tiledx:
                pass       -> FAIL       (fi-gdg-551) fdo#102575

fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575

fi-bdw-5557u     total:285  pass:264  dwarn:0   dfail:0   fail:0   skip:21  time:436s
fi-bdw-gvtdvm    total:285  pass:261  dwarn:0   dfail:0   fail:0   skip:24  time:446s
fi-blb-e6850     total:285  pass:220  dwarn:1   dfail:0   fail:0   skip:64  time:380s
fi-bsw-n3050     total:285  pass:239  dwarn:0   dfail:0   fail:0   skip:46  time:540s
fi-bwr-2160      total:285  pass:180  dwarn:0   dfail:0   fail:0   skip:105 time:298s
fi-bxt-dsi       total:285  pass:255  dwarn:0   dfail:0   fail:0   skip:30  time:517s
fi-bxt-j4205     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:517s
fi-byt-j1900     total:285  pass:250  dwarn:0   dfail:0   fail:0   skip:35  time:519s
fi-byt-n2820     total:285  pass:246  dwarn:0   dfail:0   fail:0   skip:39  time:503s
fi-cfl-8700k     total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:412s
fi-cfl-s2        total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:579s
fi-cfl-u         total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:512s
fi-cnl-drrs      total:285  pass:254  dwarn:3   dfail:0   fail:0   skip:28  time:514s
fi-elk-e7500     total:285  pass:225  dwarn:1   dfail:0   fail:0   skip:59  time:427s
fi-gdg-551       total:285  pass:176  dwarn:0   dfail:0   fail:1   skip:108 time:321s
fi-glk-1         total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:536s
fi-hsw-4770      total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:404s
fi-ilk-650       total:285  pass:225  dwarn:0   dfail:0   fail:0   skip:60  time:420s
fi-ivb-3520m     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:467s
fi-ivb-3770      total:285  pass:252  dwarn:0   dfail:0   fail:0   skip:33  time:434s
fi-kbl-7500u     total:285  pass:260  dwarn:1   dfail:0   fail:0   skip:24  time:473s
fi-kbl-7567u     total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:469s
fi-kbl-r         total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:513s
fi-pnv-d510      total:285  pass:219  dwarn:1   dfail:0   fail:0   skip:65  time:669s
fi-skl-6260u     total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:444s
fi-skl-6600u     total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:539s
fi-skl-6700hq    total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:550s
fi-skl-6700k2    total:285  pass:261  dwarn:0   dfail:0   fail:0   skip:24  time:505s
fi-skl-6770hq    total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:498s
fi-skl-guc       total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:429s
fi-skl-gvtdvm    total:285  pass:262  dwarn:0   dfail:0   fail:0   skip:23  time:445s
fi-snb-2520m     total:285  pass:245  dwarn:0   dfail:0   fail:0   skip:40  time:584s
fi-snb-2600      total:285  pass:245  dwarn:0   dfail:0   fail:0   skip:40  time:400s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1167/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: warning for series starting with [i-g-t,1/2] lib: intel: report GT size from the database if available

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/2] lib: intel: report GT size from the database if available
URL   : https://patchwork.freedesktop.org/series/40278/
State : warning

== Summary ==

---- Possible new issues:

Test drv_suspend:
        Subgroup sysfs-reader:
                pass       -> DMESG-WARN (shard-snb)

---- Known issues:

Test kms_flip:
        Subgroup 2x-dpms-vs-vblank-race:
                pass       -> FAIL       (shard-hsw) fdo#103060
Test kms_rotation_crc:
        Subgroup sprite-rotation-180:
                pass       -> FAIL       (shard-snb) fdo#103925
Test kms_setmode:
        Subgroup basic:
                pass       -> FAIL       (shard-apl) fdo#99912
Test kms_vblank:
        Subgroup pipe-b-ts-continuation-dpms-suspend:
                incomplete -> PASS       (shard-hsw) fdo#105054

fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#105054 https://bugs.freedesktop.org/show_bug.cgi?id=105054

shard-apl        total:3478 pass:1814 dwarn:1   dfail:0   fail:7   skip:1655 time:13003s
shard-hsw        total:3478 pass:1767 dwarn:1   dfail:0   fail:2   skip:1707 time:11747s
shard-snb        total:3478 pass:1356 dwarn:2   dfail:0   fail:3   skip:2117 time:7144s
Blacklisted hosts:
shard-kbl        total:3478 pass:1937 dwarn:1   dfail:0   fail:11  skip:1529 time:9872s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1167/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/2] lib: intel: report GT size from the database if available

[Lionel Landwerlin]

Ping?

On 20/03/18 13:47, Lionel Landwerlin wrote:
> The scheme if getting the GT size from the PCI-id doesn't work anymore
> on Coffeelake.
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105451, https://bugs.freedesktop.org/show_bug.cgi?id=101740
> ---
>   lib/intel_device_info.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
> index 1c710733..c104c9c4 100644
> --- a/lib/intel_device_info.c
> +++ b/lib/intel_device_info.c
> @@ -410,8 +410,17 @@ unsigned intel_gen(uint16_t devid)
>    */
>   unsigned intel_gt(uint16_t devid)
>   {
> +	const struct intel_device_info *devinfo = intel_get_device_info(devid);
>   	unsigned mask = intel_gen(devid);
>   
> +	/* If in the database, just use that information. */
> +	if (devinfo->gt != 0)
> +		return devinfo->gt - 1;
> +
> +	/*
> +	 * This scheme doesn't work on Coffeelake, we should probably
> +	 * not rely on this anymore.
> +	 */
>   	if (mask >= 8)
>   		mask = 0xf;
>   	else if (mask >= 6)


_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/2] lib: intel: report GT size from the database if available

[Chris Wilson]

Quoting Lionel Landwerlin (2018-05-14 14:15:01)
> Ping?
> 
> On 20/03/18 13:47, Lionel Landwerlin wrote:
> > The scheme if getting the GT size from the PCI-id doesn't work anymore
> > on Coffeelake.
> >
> > Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105451, https://bugs.freedesktop.org/show_bug.cgi?id=101740
> > ---
> >   lib/intel_device_info.c | 9 +++++++++
> >   1 file changed, 9 insertions(+)
> >
> > diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
> > index 1c710733..c104c9c4 100644
> > --- a/lib/intel_device_info.c
> > +++ b/lib/intel_device_info.c
> > @@ -410,8 +410,17 @@ unsigned intel_gen(uint16_t devid)
> >    */
> >   unsigned intel_gt(uint16_t devid)
> >   {
> > +     const struct intel_device_info *devinfo = intel_get_device_info(devid);
> >       unsigned mask = intel_gen(devid);
> >   
> > +     /* If in the database, just use that information. */
> > +     if (devinfo->gt != 0)
> > +             return devinfo->gt - 1;
> > +
> > +     /*
> > +      * This scheme doesn't work on Coffeelake, we should probably
> > +      * not rely on this anymore.
> > +      */

I don't get this comment in light of the above. If you are adding a
preferred mechanism, why complain about the stuff you haven't convert?
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/2] lib: intel: report GT size from the database if available

[Lionel Landwerlin]

On 14/05/18 16:41, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2018-05-14 14:15:01)
>> Ping?
>>
>> On 20/03/18 13:47, Lionel Landwerlin wrote:
>>> The scheme if getting the GT size from the PCI-id doesn't work anymore
>>> on Coffeelake.
>>>
>>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105451, https://bugs.freedesktop.org/show_bug.cgi?id=101740
>>> ---
>>>    lib/intel_device_info.c | 9 +++++++++
>>>    1 file changed, 9 insertions(+)
>>>
>>> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
>>> index 1c710733..c104c9c4 100644
>>> --- a/lib/intel_device_info.c
>>> +++ b/lib/intel_device_info.c
>>> @@ -410,8 +410,17 @@ unsigned intel_gen(uint16_t devid)
>>>     */
>>>    unsigned intel_gt(uint16_t devid)
>>>    {
>>> +     const struct intel_device_info *devinfo = intel_get_device_info(devid);
>>>        unsigned mask = intel_gen(devid);
>>>    
>>> +     /* If in the database, just use that information. */
>>> +     if (devinfo->gt != 0)
>>> +             return devinfo->gt - 1;
>>> +
>>> +     /*
>>> +      * This scheme doesn't work on Coffeelake, we should probably
>>> +      * not rely on this anymore.
>>> +      */
> I don't get this comment in light of the above. If you are adding a
> preferred mechanism, why complain about the stuff you haven't convert?
> -Chris
>
I only added gt information on hsw+. So a number of devices won't have 
the information.
I do need to add it for CNL+ too, then this comment could be turn into 
an assert(gen < 8 && !haswell)

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/2] lib: intel: report GT size from the database if available

[Chris Wilson]

Quoting Lionel Landwerlin (2018-05-14 16:50:10)
> On 14/05/18 16:41, Chris Wilson wrote:
> > Quoting Lionel Landwerlin (2018-05-14 14:15:01)
> >> Ping?
> >>
> >> On 20/03/18 13:47, Lionel Landwerlin wrote:
> >>> The scheme if getting the GT size from the PCI-id doesn't work anymore
> >>> on Coffeelake.
> >>>
> >>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> >>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105451, https://bugs.freedesktop.org/show_bug.cgi?id=101740
> >>> ---
> >>>    lib/intel_device_info.c | 9 +++++++++
> >>>    1 file changed, 9 insertions(+)
> >>>
> >>> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
> >>> index 1c710733..c104c9c4 100644
> >>> --- a/lib/intel_device_info.c
> >>> +++ b/lib/intel_device_info.c
> >>> @@ -410,8 +410,17 @@ unsigned intel_gen(uint16_t devid)
> >>>     */
> >>>    unsigned intel_gt(uint16_t devid)
> >>>    {
> >>> +     const struct intel_device_info *devinfo = intel_get_device_info(devid);
> >>>        unsigned mask = intel_gen(devid);
> >>>    
> >>> +     /* If in the database, just use that information. */
> >>> +     if (devinfo->gt != 0)
> >>> +             return devinfo->gt - 1;
> >>> +
> >>> +     /*
> >>> +      * This scheme doesn't work on Coffeelake, we should probably
> >>> +      * not rely on this anymore.
> >>> +      */
> > I don't get this comment in light of the above. If you are adding a
> > preferred mechanism, why complain about the stuff you haven't convert?
> > -Chris
> >
> I only added gt information on hsw+. So a number of devices won't have 
> the information.
> I do need to add it for CNL+ too, then this comment could be turn into 
> an assert(gen < 8 && !haswell)

How about
/*
 * From Coffelake onwards, the GT is no longer accurately encoded in the
 * PCI-ID and we need to use a look up table.
 */
if (devinfo->gt)
	return devinfo->gt - 1;

if (devinfo->gen > 9 || IS_COFFELAKE(devinfo))
	igt_warn("GT information inaccurate; please update intel_device_info\n");

and see how it long takes.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/2] lib: intel: report GT size from the database if available

[Lionel Landwerlin]

On 14/05/18 17:15, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2018-05-14 16:50:10)
>> On 14/05/18 16:41, Chris Wilson wrote:
>>> Quoting Lionel Landwerlin (2018-05-14 14:15:01)
>>>> Ping?
>>>>
>>>> On 20/03/18 13:47, Lionel Landwerlin wrote:
>>>>> The scheme if getting the GT size from the PCI-id doesn't work anymore
>>>>> on Coffeelake.
>>>>>
>>>>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>>>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105451, https://bugs.freedesktop.org/show_bug.cgi?id=101740
>>>>> ---
>>>>>     lib/intel_device_info.c | 9 +++++++++
>>>>>     1 file changed, 9 insertions(+)
>>>>>
>>>>> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
>>>>> index 1c710733..c104c9c4 100644
>>>>> --- a/lib/intel_device_info.c
>>>>> +++ b/lib/intel_device_info.c
>>>>> @@ -410,8 +410,17 @@ unsigned intel_gen(uint16_t devid)
>>>>>      */
>>>>>     unsigned intel_gt(uint16_t devid)
>>>>>     {
>>>>> +     const struct intel_device_info *devinfo = intel_get_device_info(devid);
>>>>>         unsigned mask = intel_gen(devid);
>>>>>     
>>>>> +     /* If in the database, just use that information. */
>>>>> +     if (devinfo->gt != 0)
>>>>> +             return devinfo->gt - 1;
>>>>> +
>>>>> +     /*
>>>>> +      * This scheme doesn't work on Coffeelake, we should probably
>>>>> +      * not rely on this anymore.
>>>>> +      */
>>> I don't get this comment in light of the above. If you are adding a
>>> preferred mechanism, why complain about the stuff you haven't convert?
>>> -Chris
>>>
>> I only added gt information on hsw+. So a number of devices won't have
>> the information.
>> I do need to add it for CNL+ too, then this comment could be turn into
>> an assert(gen < 8 && !haswell)
> How about
> /*
>   * From Coffelake onwards, the GT is no longer accurately encoded in the
>   * PCI-ID and we need to use a look up table.
>   */
> if (devinfo->gt)
> 	return devinfo->gt - 1;
>
> if (devinfo->gen > 9 || IS_COFFELAKE(devinfo))
> 	igt_warn("GT information inaccurate; please update intel_device_info\n");

I'm going to avoid igt_warn() as intel_device_info is pulled in by aubdump.

Thanks for the suggestion!

>
> and see how it long takes.
> -Chris
>

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev