public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Karthik B S <karthik.b.s@intel.com>
To: Mohammed Thasleem <mohammed.thasleem@intel.com>,
	<igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t] tests/intel/kms_pm_dc: Add check for display require output
Date: Tue, 10 Mar 2026 14:27:33 +0530	[thread overview]
Message-ID: <a6da408b-bdd3-4c8c-962b-7a784948fd1b@intel.com> (raw)
In-Reply-To: <20260310063735.40069-1-mohammed.thasleem@intel.com>

Hi Thasleem,

On 3/10/2026 12:07 PM, Mohammed Thasleem wrote:
> Add igt_display_require_output() check to ensure at least one display
> output is available before running igt_kms tests.

There are few of the subtests of kms_pm_dc passing on headless systems 
as well. Please check if those need to be split into a separate test or 
if those were passing by mistake in the first place.

Thanks and Regards,
Karthik.B.S
>
> Signed-off-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
> ---
>   tests/intel/kms_pm_dc.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c
> index 2f822abea..d1c4a5019 100644
> --- a/tests/intel/kms_pm_dc.c
> +++ b/tests/intel/kms_pm_dc.c
> @@ -771,6 +771,7 @@ int igt_main()
>   		igt_require(igt_setup_runtime_pm(data.drm_fd));
>   		igt_require(igt_pm_dmc_loaded(data.debugfs_fd));
>   		igt_display_require(&data.display, data.drm_fd);
> +		igt_display_require_output(&data.display);
>   		/* Make sure our Kernel supports MSR and the module is loaded */
>   		igt_require(igt_kmod_load("msr", NULL) == 0);
>   

  parent reply	other threads:[~2026-03-10  8:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-10  6:37 [PATCH i-g-t] tests/intel/kms_pm_dc: Add check for display require output Mohammed Thasleem
2026-03-10  8:34 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-03-10  8:57 ` Karthik B S [this message]
2026-03-10  9:44 ` ✓ i915.CI.BAT: " Patchwork
2026-03-10 11:54 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-03-10 14:44 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6da408b-bdd3-4c8c-962b-7a784948fd1b@intel.com \
    --to=karthik.b.s@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=mohammed.thasleem@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox