From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id ECBF56E6B0 for ; Tue, 15 Jan 2019 13:32:39 +0000 (UTC) References: <20190115123511.11474-1-andi.shyti@intel.com> <20190115123511.11474-3-andi.shyti@intel.com> <154755723693.30063.8985044656295200164@skylake-alporthouse-com> <5fb9e076-2371-12cc-c8db-6fbae7e2cb8c@linux.intel.com> <154755836143.30063.304770428386021030@skylake-alporthouse-com> From: Tvrtko Ursulin Message-ID: Date: Tue, 15 Jan 2019 13:32:39 +0000 MIME-Version: 1.0 In-Reply-To: <154755836143.30063.304770428386021030@skylake-alporthouse-com> Content-Language: en-US Subject: Re: [igt-dev] [RFC PATCH v4 2/3] lib: implement new engine discovery interface List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , Andi Shyti , IGT dev Cc: Andi Shyti List-ID: Ck9uIDE1LzAxLzIwMTkgMTM6MTksIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTAxLTE1IDEzOjE0OjEwKQo+Pgo+PiBPbiAxNS8wMS8yMDE5IDEzOjAw LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBRdW90aW5nIEFuZGkgU2h5dGkgKDIwMTktMDEtMTUg MTI6MzU6MTApCj4+Pj4gS2VybmVsIGNvbW1pdHM6Cj4+Pj4KPj4+PiBbMV0gYWU4ZjQ1NDRkZDhm ICgiZHJtL2k5MTU6IEVuZ2luZSBkaXNjb3ZlcnkgcXVlcnkiKQo+Pj4+IFsyXSAzMWU3ZDM1NjY3 YTAgKCJkcm0vaTkxNTogQWxsb3cgYSBjb250ZXh0IHRvIGRlZmluZSBpdHMgc2V0IG9mIGVuZ2lu ZXMiKQo+Pj4+Cj4+Pj4gZnJvbSBbKl0gcmVwb3NpdG9yeSwgaW1wbGVtZW50IGEgbmV3IHVhcGkg Zm9yIGVuZ2luZSBkaXNjb3ZlcnkKPj4+PiB0aGF0IGNvbnNpc3QgaW4gZmlyc3QgcXVlcnlpbmcg dGhlIGRyaXZlciBhYm91dCB0aGUgZW5naW5lcyBpbgo+Pj4+IHRoZSBncHUgWzFdIGFuZCB0aGVu IGJpbmRpbmcgYSBjb250ZXh0IHRvIHRoZSBzZXQgb2YgZW5naW5lcyB0aGF0Cj4+Pj4gaXQgY2Fu IGFjY2VzcyBbMl0uCj4+Pj4KPj4+PiBJbiBpZ3QgdGhlIGNsYXNzaWMgd2F5IGZvciBkaXNjb3Zl cmluZyBlbmdpbmVzIGlzIGRvbmUgdGhyb3VnaAo+Pj4+IHRoZSBmb3JfZWFjaF9waHlzaWNhbF9l bmdpbmUoKSBtYWNybywgdGhhdCB3b3VsZCBiZSByZXBsYWNlZCBieQo+Pj4+IHRoZSBuZXcgZm9y X2VhY2hfZW5naW5lX2N0eCgpLgo+Pj4+Cj4+Pj4gQSBuZXcgZnVuY3Rpb24gaXMgYWRkZWQgZ2Vt X2luaXRfZW5naW5lX2xpc3QoKSB0aGF0IGlzIGNhbGxlZAo+Pj4+IGR1cmluZyBkZXZpY2Ugb3Bl biB3aGljaCBjcmVhdGVzIHRoZSBsaXN0IG9mIGVuZ2luZXMuIFRoYXQgbGlzdAo+Pj4+IGlzIHN0 b3JlZCBpbiB0aGUgaW50ZWxfZXhlY3V0aW9uX2VuZ2luZXMyIHRoYXQgcmVwbGFjZXMgdGhlCj4+ Pj4gY3VycmVudCBhcnJheSB3aGljaCBoYXMgbW9yZSBhIHJlZmVyZW5jZSBtZWFuaW5nLiBOb3cg dGhlCj4+Pj4gaW50ZWxfZXhlY3V0aW9uX2VuZ2luZXMyIHN0b3JlcyB0aGUgZW5naW5lcyBjdXJy ZW50bHkgcHJlc2VudCBpbgo+Pj4+IHRoZSBHUFUuCj4+Pj4KPj4+PiBbKl0gZ2l0Oi8vcGVvcGxl LmZyZWVkZXNrdG9wLm9yZy9+dHVyc3VsaW4vZHJtLWludGVsCj4+Pj4KPj4+PiBTaWduZWQtb2Zm LWJ5OiBBbmRpIFNoeXRpIDxhbmRpLnNoeXRpQGludGVsLmNvbT4KPj4+PiAtLS0KPj4+PiAgICBs aWIvZHJtdGVzdC5jIHwgMTIgKysrKystLQo+Pj4+ICAgIGxpYi9pZ3RfZ3QuYyAgfCA5OSArKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0KPj4+PiAgICBs aWIvaWd0X2d0LmggIHwgMTAgKysrKystCj4+Pj4gICAgMyBmaWxlcyBjaGFuZ2VkLCAxMTAgaW5z ZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pCj4+Pj4KPj4+PiBkaWZmIC0tZ2l0IGEvbGliL2Ry bXRlc3QuYyBiL2xpYi9kcm10ZXN0LmMKPj4+PiBpbmRleCA3YzEyNGFjNjY2ZWMuLjJkMTU1ZWVh OGExMyAxMDA2NDQKPj4+PiAtLS0gYS9saWIvZHJtdGVzdC5jCj4+Pj4gKysrIGIvbGliL2RybXRl c3QuYwo+Pj4+IEBAIC0zMDEsNyArMzAxLDcgQEAgc3RhdGljIGludCBfX29wZW5fZHJpdmVyKGNv bnN0IGNoYXIgKmJhc2UsIGludCBvZmZzZXQsIHVuc2lnbmVkIGludCBjaGlwc2V0KQo+Pj4+ICAg IAo+Pj4+ICAgICAgICAgICBmZCA9IF9fc2VhcmNoX2FuZF9vcGVuKGJhc2UsIG9mZnNldCwgY2hp cHNldCk7Cj4+Pj4gICAgICAgICAgIGlmIChmZCAhPSAtMSkKPj4+PiAtICAgICAgICAgICAgICAg cmV0dXJuIGZkOwo+Pj4+ICsgICAgICAgICAgICAgICBnb3RvIHNldF9lbmdpbmVzX2FuZF9yZXR1 cm47Cj4+Pj4gICAgCj4+Pj4gICAgICAgICAgIHB0aHJlYWRfbXV0ZXhfbG9jaygmbXV0ZXgpOwo+ Pj4+ICAgICAgICAgICBmb3IgKGNvbnN0IHN0cnVjdCBtb2R1bGUgKm0gPSBtb2R1bGVzOyBtLT5t b2R1bGU7IG0rKykgewo+Pj4+IEBAIC0zMTQsNyArMzE0LDE1IEBAIHN0YXRpYyBpbnQgX19vcGVu X2RyaXZlcihjb25zdCBjaGFyICpiYXNlLCBpbnQgb2Zmc2V0LCB1bnNpZ25lZCBpbnQgY2hpcHNl dCkKPj4+PiAgICAgICAgICAgfQo+Pj4+ICAgICAgICAgICBwdGhyZWFkX211dGV4X3VubG9jaygm bXV0ZXgpOwo+Pj4+ICAgIAo+Pj4+IC0gICAgICAgcmV0dXJuIF9fc2VhcmNoX2FuZF9vcGVuKGJh c2UsIG9mZnNldCwgY2hpcHNldCk7Cj4+Pj4gKyAgICAgICBmZCA9IF9fc2VhcmNoX2FuZF9vcGVu KGJhc2UsIG9mZnNldCwgY2hpcHNldCk7Cj4+Pj4gKyAgICAgICBpZiAoZmQgPCAwKQo+Pj4+ICsg ICAgICAgICAgICAgICByZXR1cm4gZmQ7Cj4+Pj4gKwo+Pj4+ICtzZXRfZW5naW5lc19hbmRfcmV0 dXJuOgo+Pj4+ICsgICAgICAgaWYgKGlzX2k5MTVfZGV2aWNlKGZkKSkKPj4+PiArICAgICAgICAg ICAgICAgZ2VtX2luaXRfZW5naW5lX2xpc3QoZmQpOwo+Pj4KPj4+IERvIHdlIHJlYWxseSB3YW50 IG1vcmUgaW1wbGljaXQgYWN0aW9ucyBvbiBvcGVuaW5nIGFuIGZkPwo+Pj4KPj4+IFdlIGFscmVh ZHkgaGF2ZSBpZ3RfcmVxdWlyZV9nZW0oKSB3aGljaCB3b3VsZCBtYWtlIGFuIGludGVyZXN0aW5n Cj4+PiBzdGFydGluZyBwb2ludCwgZm9yIHRoYXQgd2UgbWF5IHdhbnQgdG8gdXNlIGZkIG5vdCBm cm9tCj4+PiBkcm1fb3Blbl9kcml2ZXIoKS4gSG93ZXZlciwgdGhlcmUgc2VlbXMgdG8gYmUgbm8g aXNzdWUgd2l0aCBjcmVhdGluZyB0aGUKPj4+IG5hbWVzIG9uIHRoZSBmbHkgKGFuZCBhc2sgZm9y IHRoZSBjb21wbGVtZW50YXJ5IGdldHRlciBmb3IgZW5naW5lc1tdIHNvCj4+PiB0aGF0IGFuIGlu ZGV4IGNvdWxkIGJlIHRyYW5zbGF0ZWQgYmFjayB0byBjbGFzczppbnN0YW5jZSkuCj4+Pgo+Pj4g Q2VydGFpbmx5IGhhdmluZyBkcm10ZXN0IHByZXN1bWUgR0VNIChhbmQgYmUgc3ViamVjdCB0byBh bGwgb2YgdGhlIGV4dHJhCj4+PiBydWxlcykgZ2l2ZW4gaTkxNSBzZWVtcyBhIGJpdCBydWRlLgo+ Pgo+PiBNeSBzdWdnZXN0aW9uIHdhcyB0byBjby1zaXRlIHdpdGggZXhpc3RpbmcgImlzIGk5MTUi IGNvZGUgaW4KPj4gZHJtX29wZW5fZHJpdmVyIGFuZCBkcm1fb3Blbl9kcml2ZXJfcmVuZGVyLiBC dXQgaWd0X3JlcXVpcmVfZ2VtIGFsc28KPj4gc291bmRzIG9rYXkuCj4+Cj4+IEkgZGlkbid0IHVu ZGVyc3RhbmQgdGhlIGJpdCBhYm91dCB0aGUgY29tcGxlbWVudGFyeSBnZXR0ZXIuCj4gCj4gSnVz dCB3ZSdyZSBtaXNzaW5nIHRoZSBHRVRQQVJBTSBlbmdpbmVzIGludGVyZmFjZSwgd2hpY2ggSSB0 aGluayBjb3VsZCBiZQo+IHVzZWQgdG8gcmV0cmlldmUgdGhlIGluZm9ybWF0aW9uIHJlcXVpcmVk IGZvciBwcmV0dHkgcHJpbnRpbmcgYXQgcnVudGltZSwKPiBhbmQgc28gYXZvaWQgZ2xvYmFsIHRh YmxlcyB0aGF0IG1heSBub3QgbWF0Y2ggbXkgY29udGV4dC4KCkFyZSB5b3UgaW1hZ2luaW5nIGZv cl9lYWNoX2VuZ2luZV9jdHggdG8gcXVlcnkgaWYgdGhlIGNvbnRleHQgYWxyZWFkeSAKaGFzIGVu Z2luZSBtYXAgc2V0IHVwIGFuZCBpbiB0aGF0IGNhc2UgaXRlcmF0ZSBvdmVyIHRob3NlIGVuZ2lu ZXM/IEFuZCAKaWYgdGhlcmUgaXMgbm8gZW5naW5lIG1hcCB0byBzZXQgdXAgb25lIGNvbnRhaW5p bmcgYWxsIGVuZ2luZXM/CgpPciBhY3R1YWxseSwgbWF5YmUgdGhlIGZvcm1lciBhcyB0aGUgb25s eSBiZWhhdmlvdXIgb2YgCmZvcl9lYWNoX2VuZ2luZV9jdHgsIGFuZCBvbmx5IGZvcl9lYWNoX3Bo eXNpY2FsX2VuZ2luZSBhdXRvLWNvbmZpZ3VyaW5nIAp0aGUgbWFwPwoKPj4+PiArICAgICAgIC8q Cj4+Pj4gKyAgICAgICAgKiBUaGUgZmlyc3QgaW9jdGwgaXMgc2VudCB3aXRoIGl0ZW0ubGVuZ3Ro ID0gMAo+Pj4+ICsgICAgICAgICogd2hpY2ggYXNrcyB0byB0aGUgZHJpdmVyIHRvIHN0b3JlIGlu IGxlbmd0aCB0aGUKPj4+PiArICAgICAgICAqIG1lbW9yeSBuZWVkZWQgZm9yIHRoZSBlbmdpbmVz LiBJbiB0aGUgZHJpdmVyLCBsZW5ndGgKPj4+PiArICAgICAgICAqIGlzIGVxdWFsIHRvCj4+Pj4g KyAgICAgICAgKgo+Pj4+ICsgICAgICAgICogICBsZW4gPSBzaXplb2Yoc3RydWN0IGRybV9pOTE1 X3F1ZXJ5X2VuZ2luZV9pbmZvKSArCj4+Pj4gKyAgICAgICAgKiAgICAgICAgICAgICAgICAgICBJ TlRFTF9JTkZPKGk5MTUpLT5udW1fcmluZ3MgKgo+Pj4+ICsgICAgICAgICogICAgICAgICAgICAg ICAgICAgc2l6ZW9mKHN0cnVjdCBkcm1faTkxNV9lbmdpbmVfaW5mbyk7Cj4+Pgo+Pj4gTmFoLCBk byBub3QgaW1wbHkgeW91IGFyZSB0aWVkIHRvIGltcGxlbWVudGF0aW9uIGRldGFpbHMgLSB0aGF0 IGlzIHRoZQo+Pj4gd2hvbGUgcG9pbnQgb2YgcXVlcnlpbmcgdGhlIGxlbmd0aCBmaXJzdC4gRG8g bm90ZSB0aGF0IHlvdSBjYW4gb3Zlcgo+Pj4gYWxsb2NhdGUgKHNheSB1c2UgYSBzbWFsbCBiaXQg b2Ygc3RhY2spIGFuZCBkbyB0aGUgcXVlcnkgaW4gb25lIHNob3QsCj4+PiBvbmx5IGFsbG9jYXRp bmcgZnJvbSBoZWFwIGlmIHdlIG5lZWQgbW9yZSByb29tLgo+Pj4KPj4+PiArICAgICAgICAqLwo+ Pj4+ICsgICAgICAgaWd0X2Fzc2VydCghaW9jdGwoZmQsIERSTV9JT0NUTF9JOTE1X1FVRVJZLCAm cXVlcnkpKTsKPj4+Cj4+PiBCYWQgbmV3cyBmb3Igb2xkIGtlcm5lbHMuCj4+Cj4+IERvIHdlIGNh cmUgYWJvdXQgb2xkIGtlcm5lbHM/IEkgdGhvdWdodCBmb3IgSUdUIHdlIGRpZCBub3QuCj4gCj4g V2Ugc3VwcG9zZWRseSBkbyEgOikKPiAKPiBXZSBkZWZpbml0ZWx5IGRvIGNhcmUgYWJvdXQgYmVp bmcgYWJsZSB0byBiaXNlY3Qga2VybmVscyBmcm9tIGFuIGFybSdzCj4gbGVuZ3RoIGFnby4gQmV5 b25kIGFuIGFybSdzIGxlbmd0aCwgbm8gb25lIHdpbGwgbm90aWNlLiBDZXJ0YWlubHkgd2UKPiBk b24ndCBpbnRlbmQgdG8gbWFrZSB0aGluZ3MgaGFyZGVyIHRoYW4gd2UgbmVlZCB0by4gOikKClF1 ZXN0aW9uIGlzIGhvdyBkb2VzIHRoZSBjb21wbGV0ZSBuZXcgSUdUIHdvcmxkIGxvb2suIElmIGV2 ZXJ5dGhpbmcgCmRlcGVuZHMgb24gZW5naW5lIG1hcCBpbnRlcmZhY2UgKGV2ZXJ5dGhpbmcgYXMg YWxsIApmb3JfZWFjaF9waHlzaWNhbF9lbmdpbmUgdGVzdHMpLCB0aGVuIHdlIGNhbiBoYXZlIGl0 IGZhbGwgYmFjayB0byBhIApzdGF0aWMgdGFibGUgYXMgdG9kYXkgYnV0IGxvc2Ugc29tZSBjb3Zl cmFnZS4gKFNpbmNlIHdlIGRvbid0IGhhdmUgYSB3YXkgCm9mIHByb2Jpbmcgb3IgYWNjZXNzaW5n IGFsbCBlbmdpbmVzIHdpdGhvdXQgdGhlIG5ldyB1YXBpLCB3ZSBjYW4gb25seSAKaGF2ZSBhIHN1 YnNldCBvZiBlbmdpbmVzIGluIHRoZSBzdGF0aWMgZmFsbCBiYWNrIHRhYmxlLikKClJlZ2FyZHMs CgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K aWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg==