Re: [PATCH i-g-t 02/15] tests/drm_read: Use for_each_crtc*()

[Jani Nikula <jani.nikula@intel.com>]

On Fri, 30 Jan 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Convert tests/drm_read to use the crtc based iterators
> (as opposed to the old pipe based ones).
>
> This one was done manually due to coccinelle refusing
> to cooperate with me.
>
> I left the old 'pipe' variable around since its final value
> gets used in a bunch of places after the loop. I'll probably
> need further cleanup later, but this seems sufficient for now.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  tests/drm_read.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/tests/drm_read.c b/tests/drm_read.c
> index c44e207f7dd8..e745e98534bd 100644
> --- a/tests/drm_read.c
> +++ b/tests/drm_read.c
> @@ -280,6 +280,7 @@ int igt_main()
>  	igt_fixture() {
>  		struct sigaction alarm_action = {};
>  		igt_output_t *output;
> +		igt_crtc_t *crtc;
>  
>  		igt_assert_neq(sigaction(SIGALRM, NULL, &alarm_action), -1);
>  		alarm_action.sa_flags &= ~SA_RESTART;
> @@ -292,16 +293,17 @@ int igt_main()
>  		igt_display_require(&display, fd);
>  		igt_display_require_output(&display);
>  
> -		for_each_pipe_with_valid_output(&display, pipe, output) {
> +		for_each_crtc_with_valid_output(&display, crtc, output) {
>  			drmModeModeInfo *mode = igt_output_get_mode(output);
>  
>  			igt_create_pattern_fb(fd, mode->hdisplay, mode->vdisplay,
>  					      DRM_FORMAT_XRGB8888,
>  					      DRM_FORMAT_MOD_LINEAR, &fb);
>  
> -			igt_output_set_crtc(output,
> -				            igt_crtc_for_pipe(output->display, pipe));
> +			igt_output_set_crtc(output, crtc);
>  			igt_plane_set_fb(igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY), &fb);
> +
> +			pipe = crtc->pipe;
>  			break;
>  		}

-- 
Jani Nikula, Intel