public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Randhawa, Jagmeet" <jagmeet.randhawa@intel.com>
To: "Kamil Konieczny" <kamil.konieczny@linux.intel.com>,
	igt-dev@lists.freedesktop.org, stuart.summers@intel.com,
	"Janusz Krzysztofik" <janusz.krzysztofik@linux.intel.com>,
	"Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Subject: Re: [i-g-t] tests/core_hotunplug: Open render capable DRM device
Date: Wed, 4 Mar 2026 09:36:59 -0800	[thread overview]
Message-ID: <a887180c-dc2f-441a-9e4f-252780166d77@intel.com> (raw)
In-Reply-To: <20260304135601.iwue6vspcb5oxbo5@kamilkon-DESK.igk.intel.com>

Hello Kamil,


For this test file, All subtests use render device for health checks. 
Because of that,

selecting a render capable device up front seems like the most direct 
way to establish test

precondition and avoid accidentally selecting a card-only driver such as 
simpledrm.


Adding simpledrm to the list of known/blocked drivers could work, but we 
would still need

additional logic to continue scanning and select next suitable driver. 
Selecting a render-capable

device first naturally ensures we pick a device that exposes a render 
node and avoids the simpledrm

case without adding special handling for a specific driver.


There is no public GitLab issue for this, failure observed internally.

On 3/4/2026 5:56 AM, Kamil Konieczny wrote:
> Hi Jagmeet,
> On 2026-03-04 at 06:53:32 +0800, Jagmeet Randhawa wrote:
>> The test may select simpledrm when opening DRIVER_ANY,
>> which does not expose a render node. This causes the
>> later render open to fail.
>>
>> Open a render capable device initially using
>> __drm_open_driver_render(DRIVER_ANY) to avoid
>> selecting simpledrm.
> This is strange, as this test assumes card open and then tries
> uses render for verification so I am not sure if you could
> start with render. Adding Janusz to Cc.
>
> Could you also add links to issues on GitLab, if there are any?
>
> Other idea to solve this would be to add simpledrm to known
> drivers and a blocked ones, like VGEM.
>
> Regards,
> Kamil
>
> Cc: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
> Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
>
>> Signed-off-by: Jagmeet Randhawa <jagmeet.randhawa@intel.com>
>> ---
>>   tests/core_hotunplug.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
>> index 7c9dae1bf..3a612fce2 100644
>> --- a/tests/core_hotunplug.c
>> +++ b/tests/core_hotunplug.c
>> @@ -696,8 +696,8 @@ int igt_main()
>>   		int fd_drm;
>>   		char driver[32] = {};
>>   
>> -		fd_drm = __drm_open_driver(DRIVER_ANY);
>> -		igt_skip_on_f(fd_drm < 0, "No known DRM device found\n");
>> +		fd_drm = __drm_open_driver_render(DRIVER_ANY);
>> +		igt_skip_on_f(fd_drm < 0, "No known DRM render device found\n");
>>   
>>   		priv.chipset = drm_get_chipset(fd_drm);
>>   		/* Make sure it opens the same driver */
>> -- 
>> 2.52.0
>>

  parent reply	other threads:[~2026-03-04 17:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03 22:53 [i-g-t] tests/core_hotunplug: Open render capable DRM device Jagmeet Randhawa
2026-03-04  6:40 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-03-04  7:04 ` ✓ i915.CI.BAT: " Patchwork
2026-03-04 13:56 ` [i-g-t] " Kamil Konieczny
2026-03-04 16:31   ` Janusz Krzysztofik
2026-03-04 17:49     ` Randhawa, Jagmeet
2026-03-04 17:36   ` Randhawa, Jagmeet [this message]
2026-03-05  5:11 ` ✗ Xe.CI.FULL: failure for " Patchwork
2026-03-05  8:38 ` Patchwork
2026-03-05  9:04 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a887180c-dc2f-441a-9e4f-252780166d77@intel.com \
    --to=jagmeet.randhawa@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=janusz.krzysztofik@linux.intel.com \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=stuart.summers@intel.com \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox