Re: [igt-dev] [PATCH RFC i-g-t 03/10] tests/kms_ccs: Add GEN12 CCS render compression format modifiers

Ville Syrjälä
2019-10-30T13:55:12Z

On Wed, Oct 30, 2019 at 01:47:22PM +0000, Kahola, Mika wrote:
> On Tue, 2019-10-29 at 14:27 -0700, Radhakrishna Sripada wrote:
> > On Wed, Sep 25, 2019 at 04:09:24PM +0300, Mika Kahola wrote:
> > > Add GEN12 CCS format modifiers for render compression.
> > >
> > > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> > > ---
> > > tests/kms_ccs.c | 17 ++++++++++++++---
> > > 1 file changed, 14 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
> > > index 1ce66cde..cde62416 100644
> > > --- a/tests/kms_ccs.c
> > > +++ b/tests/kms_ccs.c
> > > @@ -75,6 +75,10 @@ static const uint64_t ccs_modifiers[] = {
> > > LOCAL_I915_FORMAT_MOD_Yf_TILED_CCS,
> > > };
> > >
> > > +static const uint64_t ccs_gen12_modifiers[] = {
> > > + LOCAL_I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS,
> > > +};
> > > +
> > > /*
> > > * Limit maximum used sprite plane width so this test will not
> > > mistakenly
> > > * fail on hardware limitations which are not interesting to this
> > > test.
> > > @@ -307,9 +311,16 @@ static int __test_output(data_t *data)
> > >
> > > igt_output_set_pipe(data->output, data->pipe);
> > >
> > > - for (i = 0; i < ARRAY_SIZE(ccs_modifiers); i++) {
> > > - data->ccs_modifier = ccs_modifiers[i];
> > > - valid_tests += test_ccs(data);
> > > + if (intel_gen(intel_get_drm_devid(data->drm_fd)) >= 12) {
> > > + for (i = 0; i < ARRAY_SIZE(ccs_gen12_modifiers); i++) {
> > > + data->ccs_modifier = ccs_gen12_modifiers[i];
> >
> > Do we skip the gen9 ccs modifiers here?
> The idea here was to use gen12 modifiers for gen12+ platforms.

We have igt_display_has_format_mod() & co.

Though we should perhaps also check that we don't accept the wrong
modifiers. But that's probably better handled by some other test.
In fact I seem to recall having posted one like that. Ah yes, these
two:
https://patchwork.freedesktop.org/patch/239809/?series=46876&rev=1
https://patchwork.freedesktop.org/patch/239814/?series=46876&rev=1

>
> Actually, I noticed from BSpec later on that 90/270 is not supported
> for render compression (BSpec #49252) and I need to update the patch
> accordingly.
>
> >
> > - Radhakrishna(RK) Sripada
> > > + valid_tests += test_ccs(data);
> > > + }
> > > + } else {
> > > + for (i = 0; i < ARRAY_SIZE(ccs_modifiers); i++) {
> > > + data->ccs_modifier = ccs_modifiers[i];
> > > + valid_tests += test_ccs(data);
> > > + }
> > > }
> > >
> > > igt_output_set_pipe(data->output, PIPE_NONE);
> > > --
> > > 2.17.1
> > >
> > > _______________________________________________
> > > igt-dev mailing list
> > > igt-dev@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

--
Ville Syrjälä
Intel