Re: [PATCH i-g-t 2/6] lib/xe/xe_sriov_admin: Add SR-IOV admin exit cleanup restore helper

["Laguna, Lukasz" <lukasz.laguna@intel.com>]

On 6/2/2026 16:16, Marcin Bernatowicz wrote:
> Add xe_sriov_admin_exit_cleanup_restore_defaults() as a best-effort
> exit-handler callback to restore PF/VF scheduling defaults via
> bulk restore.
>
> Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
> Cc: Adam Miszczak <adam.miszczak@linux.intel.com>
> Cc: Jakub Kolakowski <jakub1.kolakowski@intel.com>
> Cc: Lukasz Laguna <lukasz.laguna@intel.com>

Reviewed-by: Lukasz Laguna <lukasz.laguna@intel.com>

> ---
>   lib/xe/xe_sriov_admin.c | 21 +++++++++++++++++++++
>   lib/xe/xe_sriov_admin.h |  2 ++
>   2 files changed, 23 insertions(+)
>
> diff --git a/lib/xe/xe_sriov_admin.c b/lib/xe/xe_sriov_admin.c
> index f3be70db8..0e7ffb52d 100644
> --- a/lib/xe/xe_sriov_admin.c
> +++ b/lib/xe/xe_sriov_admin.c
> @@ -623,3 +623,24 @@ void xe_sriov_admin_bulk_restore_defaults(int pf_fd)
>   {
>   	igt_assert_eq(0, __xe_sriov_admin_bulk_restore_defaults(pf_fd));
>   }
> +
> +/**
> + * xe_sriov_admin_exit_cleanup_restore_defaults - Best-effort SR-IOV defaults restore callback
> + * @pf_fd: PF device file descriptor
> + * @sig: Exit signal number, or 0 on normal exit
> + * @user_data: Unused
> + *
> + * Callback suitable for igt_sriov_install_exit_handler() when a test modifies
> + * XE SR-IOV scheduling defaults. Restores PF and VF scheduling attributes to
> + * driver defaults. Failures are ignored so the callback remains best-effort.
> + */
> +void xe_sriov_admin_exit_cleanup_restore_defaults(int pf_fd, int sig, void *user_data)
> +{
> +	(void)sig;
> +	(void)user_data;
> +
> +	if (!xe_sriov_admin_is_present(pf_fd))
> +		return;
> +
> +	(void)__xe_sriov_admin_bulk_restore_defaults(pf_fd);
> +}
> diff --git a/lib/xe/xe_sriov_admin.h b/lib/xe/xe_sriov_admin.h
> index 607e33a86..3db13c2ac 100644
> --- a/lib/xe/xe_sriov_admin.h
> +++ b/lib/xe/xe_sriov_admin.h
> @@ -56,5 +56,7 @@ int  __xe_sriov_admin_restore_defaults(int pf_fd, unsigned int vf_num);
>   void  xe_sriov_admin_restore_defaults(int pf_fd, unsigned int vf_num);
>   int  __xe_sriov_admin_bulk_restore_defaults(int pf_fd);
>   void  xe_sriov_admin_bulk_restore_defaults(int pf_fd);
> +void xe_sriov_admin_exit_cleanup_restore_defaults(int pf_fd, int sig,
> +						  void *user_data);
>   
>   #endif /* __XE_SRIOV_ADMIN_H__ */