Re: [PATCH i-g-t v14 4/4] lib/intel_device_info: remove the graphics_rel from xe2+ devices

["Wang, X" <x.wang@intel.com>]

On 10/1/2026 22:05, Zbigniew Kempczyński wrote:
> On Mon, Sep 28, 2026 at 10:27:07AM -0700, Xin Wang wrote:
>> On Xe2+ platforms, the graphics IP version is no longer a stable
>> property of a PCI ID "device type". After IP disaggregation, devices
>> sharing the same PCI ID can report different IP versions via GMD_ID, so
>> encoding graphics_rel in the static PCI-ID table gives wrong minor
>> versions on such devices.
>>
>> Drop graphics_rel for these platforms and rely on the runtime value
>> that xe_device_get() reads from GMD_ID.
>>
>> v2:
>>   - also drop graphics_rel from WCL and NVL-P.
>>
>> Signed-off-by: Xin Wang <x.wang@intel.com>
>> ---
>>   lib/intel_device_info.c | 7 -------
>>   1 file changed, 7 deletions(-)
>>
>> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
>> index 9201ca806c..0879f49038 100644
>> --- a/lib/intel_device_info.c
>> +++ b/lib/intel_device_info.c
>> @@ -512,7 +512,6 @@ static const struct intel_device_info intel_pontevecchio_info = {
>>   
>>   static const struct intel_device_info intel_lunarlake_info = {
>>   	.graphics_ver = 20,
>> -	.graphics_rel = 4,
> Can't we drop ver as well?
We still have PCI-ID-only consumers, such as intel_gtt, which accesses
the device through PCI BARs rather than xe_device_get(). Its GTT
address decoding uses intel_gen(devid), including an explicit case
for graphics version 20. Dropping graphics_ver would make that path
report an unsupported platform on Lunar Lake.

> --
> Zbigniew
>
>>   	.display_ver = 20,
>>   	.has_4tile = true,
>>   	.has_flatccs = true,
>> @@ -524,7 +523,6 @@ static const struct intel_device_info intel_lunarlake_info = {
>>   
>>   static const struct intel_device_info intel_battlemage_info = {
>>   	.graphics_ver = 20,
>> -	.graphics_rel = 1,
>>   	.display_ver = 14,
>>   	.has_4tile = true,
>>   	.has_flatccs = true,
>> @@ -536,7 +534,6 @@ static const struct intel_device_info intel_battlemage_info = {
>>   
>>   static const struct intel_device_info intel_pantherlake_info = {
>>   	.graphics_ver = 30,
>> -	.graphics_rel = 0,
>>   	.display_ver = 30,
>>   	.has_4tile = true,
>>   	.has_flatccs = true,
>> @@ -548,7 +545,6 @@ static const struct intel_device_info intel_pantherlake_info = {
>>   
>>   static const struct intel_device_info intel_wildcatlake_info = {
>>   	.graphics_ver = 30,
>> -	.graphics_rel = 3,
>>   	.display_ver = 30,
>>   	.has_4tile = true,
>>   	.has_flatccs = true,
>> @@ -560,7 +556,6 @@ static const struct intel_device_info intel_wildcatlake_info = {
>>   
>>   static const struct intel_device_info intel_novalake_s_info = {
>>   	.graphics_ver = 30,
>> -	.graphics_rel = 04,
>>   	.display_ver = 35,
>>   	.has_4tile = true,
>>   	.has_oam = true,
>> @@ -572,7 +567,6 @@ static const struct intel_device_info intel_novalake_s_info = {
>>   
>>   static const struct intel_device_info intel_novalake_p_info = {
>>   	.graphics_ver = 35,
>> -	.graphics_rel = 10,
>>   	.display_ver = 35,
>>   	.has_4tile = true,
>>   	.has_oam = true,
>> @@ -584,7 +578,6 @@ static const struct intel_device_info intel_novalake_p_info = {
>>   
>>   static const struct intel_device_info intel_crescentisland_info = {
>>   	.graphics_ver = 35,
>> -	.graphics_rel = 11,
>>   	.display_ver = 0,
>>   	.has_oam = true,
>>   	.is_crescentisland = true,
>> -- 
>> 2.43.0
>>