Re: FW: [PATCH i-g-t v2 1/2] tests/kms_atomic_transition: Use extended flag for local execution

["Naladala, Ramanaidu" <Ramanaidu.naladala@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1949 bytes --]


On 11/11/2024 11:49 AM, Samala, Pranay wrote:
>
> -----Original Message-----
> From: Samala, Pranay<pranay.samala@intel.com> 
> Sent: Wednesday, November 6, 2024 2:49 PM
> To:igt-dev@lists.freedesktop.org
> Cc: B S, Karthik<karthik.b.s@intel.com>; Joshi, Kunal1<kunal1.joshi@intel.com>; Lattannavar, Sameer<sameer.lattannavar@intel.com>; Samala, Pranay<pranay.samala@intel.com>
> Subject: [PATCH i-g-t v2 1/2] tests/kms_atomic_transition: Use extended flag for local execution
>
> There is no need to reduce the debug log level for local executions.
> This flag is used to prevent the reduction of the debug log level in local environments, while it will lower the log level in CI environments.
>
> To avoid reducing the debug log level in local executions, the extended flag must be explicitly used.
>
> Signed-off-by: Pranay Samala<pranay.samala@intel.com>
> ---
>   tests/kms_atomic_transition.c | 16 +++++++++-------
>   1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c index f4f8afc66..f11e846d8 100644
> --- a/tests/kms_atomic_transition.c
> +++ b/tests/kms_atomic_transition.c
> @@ -1189,13 +1189,15 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>   		for_each_connected_output(&data.display, output)
>   			count++;
>   
> -		dir = igt_sysfs_drm_module_params_open();
> -		if (dir >= 0) {
> -			current_log_level = igt_drm_debug_level_get(dir);
> -			close(dir);
> -
> -			if (current_log_level > 10)
> -				igt_drm_debug_level_update(10);
> +		if (!data.extended) {
> +			dir = igt_sysfs_drm_module_params_open();
> +			if (dir >= 0) {
> +				current_log_level = igt_drm_debug_level_get(dir);
> +				close(dir);
> +
> +				if (current_log_level > 10)
> +					igt_drm_debug_level_update(10);
> +			}
>   		}
>   	}

LGTM,

Reviewed-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com> 
<mailto:ramanaidu.naladala@intel.com>

>   
> --
> 2.34.1
>

[-- Attachment #2: Type: text/html, Size: 38643 bytes --]