Re: [PATCH i-g-t 5/5] tests/intel/xe_configfs: Add test to validate survivability mode

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Tue, Apr 22, 2025 at 08:57:35AM -0500, Lucas De Marchi wrote:
> On Tue, Apr 22, 2025 at 03:26:01PM +0530, Riana Tauro wrote:
> > The test validates if survivability mode is enabled on supported
> > platforms when configured using configfs attribute.
> > 
> > Signed-off-by: Riana Tauro <riana.tauro@intel.com>
> > ---
> > tests/intel/xe_configfs.c | 112 ++++++++++++++++++++++++++++++++++++++
> > tests/meson.build         |   1 +
> > 2 files changed, 113 insertions(+)
> > create mode 100644 tests/intel/xe_configfs.c
> > 
> > diff --git a/tests/intel/xe_configfs.c b/tests/intel/xe_configfs.c
> > new file mode 100644
> > index 000000000..414af4a86
> > --- /dev/null
> > +++ b/tests/intel/xe_configfs.c
> 
> 
> humn... does it make sense to test survivability mode in a xe_configfs
> test? configfs is just the way to trigger it. For completly different
> areas of the driver I don't think we should bundle the tests into a
> configfs test: we don't test if xe can be loaded without display in a
> xe_param.c test, or if we can inject faults in a xe_debugfs.c test, etc.
> 
> My suggestion is to have a dedicated test for survivability in which
> configfs is part of it.

Well, that would work for survivability itself. But perhaps it is good
to have dedicated entry points for the knobs we expose, like we have
a single place to toggle all sysfs and debufs. So we don't forget to
add new cases and we have a single entry point to quickly exercises
the knobs.

> 
> Lucas De Marchi