Re: [PATCH i-g-t 2/7] tools/intel_display_poller: Fix long opts

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Thu, Oct 02, 2025 at 09:54:07PM +0200, Michał Grzelak wrote:
> On Mon, 22 Sep 2025, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Fix the long option handling by providing a .val for each that
> > matches the short option.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > tools/intel_display_poller.c | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/tools/intel_display_poller.c b/tools/intel_display_poller.c
> > index 6089be3f1ffa..69906d557a37 100644
> > --- a/tools/intel_display_poller.c
> > +++ b/tools/intel_display_poller.c
> > @@ -1352,14 +1352,14 @@ int main(int argc, char *argv[])
> >
> > 	for (;;) {
> > 		static const struct option long_options[] = {
> > -			{ .name = "test", .has_arg = required_argument, },
> > -			{ .name = "pipe", .has_arg = required_argument, },
> > -			{ .name = "bit", .has_arg = required_argument, },
> > -			{ .name = "line", .has_arg = required_argument, },
> > -			{ .name = "fuzz", .has_arg = required_argument, },
> > -			{ .name = "pixel", .has_arg = no_argument, },
> > -			{ .name = "async", .has_arg = no_argument, },
> > -			{ .name = "vrr-push", .has_arg = required_argument, },
> > +			{ .name = "test", .has_arg = required_argument, .val = 't', },
> > +			{ .name = "pipe", .has_arg = required_argument, .val = 'b', },
> 
> I'm unsure about this since I can't find the definition for struct
> option,

"man getopt_long" is probably the fastest way to find it.

> but shouldn't be here a .val = 'p'? Seems like it will clash
> with --bit option. Otherwise,

Aye, good catch. I must have still been using the short option to
specify the pipe when testing this.

> 
> Reviewed-by: Michał Grzelak <michal.grzelak@intel.com>

Thanks.

Fixed the 'd' vs. 'p' fumble while pushing. And I also noticed
that a few hunks from the --dsb-id patch ended up in the 
previous patch, so I moved those over as well.

> 
> > +			{ .name = "bit", .has_arg = required_argument, .val = 'b', },
> > +			{ .name = "line", .has_arg = required_argument, .val = 'l', },
> > +			{ .name = "fuzz", .has_arg = required_argument, .val = 'f', },
> > +			{ .name = "pixel", .has_arg = no_argument, .val = 'x', },
> > +			{ .name = "async", .has_arg = no_argument, .val = 'a', },
> > +			{ .name = "vrr-push", .has_arg = required_argument, .val = 'v', },
> > 			{ },
> > 		};
> >
> > -- 
> > 2.49.1
> >
> >
> 
> BR,
> Michał


-- 
Ville Syrjälä
Intel