Re: [PATCH i-g-t] kms_flip_tiling: reduce exec time for sim env

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Oct 08, 2025 at 08:55:40PM +0530, Jeevan B wrote:
> For simulation environment, we can reduce execution time
> by running test only with basic tiling combinations.
> 
> v2: Add helper to check basic tiling support.
> 
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
>  tests/intel/kms_flip_tiling.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/tests/intel/kms_flip_tiling.c b/tests/intel/kms_flip_tiling.c
> index ff9ad1229..024421b58 100644
> --- a/tests/intel/kms_flip_tiling.c
> +++ b/tests/intel/kms_flip_tiling.c
> @@ -84,6 +84,13 @@ static int try_commit(igt_display_t *display)
>  				       COMMIT_ATOMIC : COMMIT_LEGACY);
>  }
>  
> +static bool is_allowed_modifier(uint64_t mod)

That function name and implementation is extremely confusing.
Why are these allowed and nothing else? Nothing here tells me
any of that.

> +{
> +	return mod == DRM_FORMAT_MOD_LINEAR ||
> +	       mod == I915_FORMAT_MOD_4_TILED ||
> +	       mod == I915_FORMAT_MOD_X_TILED;
> +}
> +
>  static uint64_t pageflip_timeout_us(drmModeModeInfo *mode)
>  {
>  	uint64_t timeout_ns;
> @@ -216,6 +223,7 @@ igt_main
>  	igt_describe("Check pageflip between modifiers");
>  	igt_subtest_with_dynamic("flip-change-tiling") {
>  		enum pipe pipe;
> +		bool run_in_simulation = igt_run_in_simulation();
>  
>  		for_each_pipe_with_valid_output(&data.display, pipe, output) {
>  			igt_plane_t *plane;
> @@ -242,6 +250,11 @@ igt_main
>  					if (plane->formats[j] != data.testformat)
>  						continue;
>  
> +					if (run_in_simulation &&
> +					    (!is_allowed_modifier(plane->modifiers[i]) ||
> +					     !is_allowed_modifier(plane->modifiers[j])))
> +						continue;
> +
>  					igt_dynamic_f("pipe-%s-%s-%s-to-%s",
>  						      kmstest_pipe_name(pipe),
>  						      igt_output_name(output),
> -- 
> 2.43.0

-- 
Ville Syrjälä
Intel