From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC423D31A0E for ; Wed, 14 Jan 2026 06:39:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 69E8110E1C0; Wed, 14 Jan 2026 06:39:42 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="PPmywPWj"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id EA9DC10E1C0 for ; Wed, 14 Jan 2026 06:39:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1768372782; x=1799908782; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=MiJP9ProAOkAaM+KHW/ZnUbULYcEQbWsl+CMoRaBiBs=; b=PPmywPWjM/BkNCWjR3JDEwj1vLs4irISHnxHHQrkrRiRoyIDfN4jckqX CeC6tEJ6GbCgLlPXBgDjofj9mGVFU8BWSyo7WmxmC5jIw+ETKfW1uA5zW AK2oechJliMeHy0cEMAAsvYvlIKTRdtg8yzxQu8qVxSA/v75c3CKY9EPQ 9dVo+3uzv6ddEcndY+5q3bl1vR0W5m9/B/OhKNTazaWlgwKLVyhTXqDw2 F27S3vloVtmUFPKzFPNsPyUGMoAlXf3sch/LmIcM6cP6UqdMt/SomhbJ4 tPmL25DahaEtR2qruCs1c9Nbv71qc9pFNYaYgpvbWRUXwB6ACoDTUB6Eb Q==; X-CSE-ConnectionGUID: wcg5zJkTS3Ogkq1FWVS0Tw== X-CSE-MsgGUID: Ra+fEe+kSXuG/8BaCy5EQQ== X-IronPort-AV: E=McAfee;i="6800,10657,11670"; a="69646868" X-IronPort-AV: E=Sophos;i="6.21,225,1763452800"; d="scan'208";a="69646868" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2026 22:39:41 -0800 X-CSE-ConnectionGUID: wKCH2lkcRwav3VVJmu4YPQ== X-CSE-MsgGUID: qUahGLNtTB2fNBRig/pbww== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,225,1763452800"; d="scan'208";a="205157519" Received: from fmsmsx903.amr.corp.intel.com ([10.18.126.92]) by fmviesa010.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2026 22:39:40 -0800 Received: from FMSMSX901.amr.corp.intel.com (10.18.126.90) by fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 13 Jan 2026 22:39:40 -0800 Received: from fmsedg903.ED.cps.intel.com (10.1.192.145) by FMSMSX901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29 via Frontend Transport; Tue, 13 Jan 2026 22:39:40 -0800 Received: from BYAPR05CU005.outbound.protection.outlook.com (52.101.85.8) by edgegateway.intel.com (192.55.55.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 13 Jan 2026 22:39:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Uk3A3V393d0QeA4b4EIkINv1ByoaRxPE2FC3N2IB4VrBfQWSzxllyTxAWivV33nqg9N1YktvSsR+vK3X+lYOEsXA8+KElpzsjapHXheBPHnRkfDO0DJZbL2SZY078p0+TXL9xfvpxK03PtPwslHzyd+IJHR0oc7Wnqd+YJ9PACGjpGWMb2N9GP6WbGF8yf+awqcO4W/UXr1YD0yFiuv8fR0eX+3BIxBTILjagnrMLIlat/ffCbAMpri9M2KnLFzWGEOuFQ2j3fuol1qiXhjAs7hzI17wNQubVQlUIiCiWLOQb56uSWNCFFDQIN4kdUq5zTNiOkl8DebyfrzczL8pDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wq2MJOtH3+a9M4KDRowuGFlUNxLew7vC28Cfgpf1qW0=; b=co9Ldl1pWWA9/ZOtKDn5wMFXz6NXL6dZN5GDiLEmpZWqfIhfmZiUz+YU1MIev/XpjqpX59+aVdGN0YNm/WpKkiP/mzd+Yo/mae27dAsWG7vSzmMMx3awmlcpW2ojN9Y9lwuMaOohEz4lKMOjNGNdwQobp3fDb6fnpjXrXPJwGYzy4XjsX9sGo1oeJGRCp3TNJnxxJrB1ZUd4mmkAUBP3lsnLlSGlgzqUMS05aiu4siDOPq5bRAunIT39V0DYMDXmxJgkxSdkLHp93/EnjnQmfgsgf/9TLyju6fO6oAxYjE/Z1/ZHFWfnPHdUwDP8eayvO7vtnf9S+Lcy9HPUlM6krA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from BL3PR11MB6410.namprd11.prod.outlook.com (2603:10b6:208:3b9::15) by PH8PR11MB6707.namprd11.prod.outlook.com (2603:10b6:510:1c6::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9499.7; Wed, 14 Jan 2026 06:39:36 +0000 Received: from BL3PR11MB6410.namprd11.prod.outlook.com ([fe80::b01a:aa33:165:efc]) by BL3PR11MB6410.namprd11.prod.outlook.com ([fe80::b01a:aa33:165:efc%6]) with mapi id 15.20.9520.005; Wed, 14 Jan 2026 06:39:35 +0000 Date: Tue, 13 Jan 2026 22:39:32 -0800 From: Niranjana Vishwanathapura To: Xin Wang CC: , Subject: Re: [PATCH] tests/intel/xe_exec_multi_queue: enable preempt flag for Q0 Message-ID: References: <20260114063236.831396-1-x.wang@intel.com> Content-Type: text/plain; charset="us-ascii"; format=flowed Content-Disposition: inline In-Reply-To: <20260114063236.831396-1-x.wang@intel.com> X-ClientProxiedBy: SJ0PR13CA0122.namprd13.prod.outlook.com (2603:10b6:a03:2c6::7) To BL3PR11MB6410.namprd11.prod.outlook.com (2603:10b6:208:3b9::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL3PR11MB6410:EE_|PH8PR11MB6707:EE_ X-MS-Office365-Filtering-Correlation-Id: c64efe37-75b2-4d55-eaac-08de5337aeed X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?cQnt06wQ6dhCwsd1DtGqYPNTawsfciDLt30hAIfO+az5ZkbGNUmBiZRm7IAG?= =?us-ascii?Q?uX6DYEVlbcEhZwgNmk4n5sFcMf/aLSLNwXStNC24aWaeR57JnlpiV5zdc6w6?= =?us-ascii?Q?v2z7nTfAqYgQZmY2HIElbL9WiwVJNeRwFvqEcThIGFgE2YFIa76WYXJHSEmk?= =?us-ascii?Q?Ou4NKFk5IQUNna+ctf1U7NQp/MvIvw8vJZLhVNBD8fkb0EgucZ8YHtkbD5+L?= =?us-ascii?Q?a3idWRPaJh2SKYTzD+HSxNLe8L7ENqC38ahHaV+sLgxFjzIjqkMJRRYdNA49?= =?us-ascii?Q?N9Fm/RJ+2MP2jDDN5C9SB0qXfeyIdhP+lAyVdACXm0I064PLcR3Iw1j8uiB5?= =?us-ascii?Q?l6srkAeos2Cu/VZUwwFMp17qqvxLHt7eHHyA7a5p3A66W7ZfPhnJ/veaciXW?= =?us-ascii?Q?d9pvFiAVaK9KluVFMvcI/CzsJtGUBFeEul2RLPndAV8wt0TOcjEKRrFOLRih?= =?us-ascii?Q?aZVMZAegw5FYrZ/DwiT1LGvNpDSiQjLJ/cH7h6QRYASqOPZwc9I170L8ObZz?= =?us-ascii?Q?oq9i7ONNMJtqZoITnWT/Nf8q1w64VQtcMYyWhwzXNUc+NLBA8qJU+WcnAznz?= =?us-ascii?Q?4diJG9hK1KkwsEYuPz0V8jMU0l6vbocWhKRLJuhh8fZN872icnJPP7mp01xz?= =?us-ascii?Q?z1iiey+tsOiYT3PtRpc/aI90EbB+T9bZbAx+B66/OtO1zWq8CyfMCZKzh3ou?= =?us-ascii?Q?5RrBqR3AsKgTCv40TfkPDZeUIiCjkIyJslSbxGJxtdhGhrrEdY8Q1wFNUTA/?= =?us-ascii?Q?4JwSXHBzcBGeptTUkUgxpR1gyTILFEmO9kzytQYFNqkavYlR6XrAm1CaeTKB?= =?us-ascii?Q?mVQyPn13ucM36sbfAglAbfFTq3/jRKAo+/zyaFJH82qmVBkKHJfI6nFqjP37?= =?us-ascii?Q?yCDnrNepIbN0QHPJy/mrrgmaro/umADnP7UiTHKZwey47YnqRfh66YV3R6/Q?= =?us-ascii?Q?tfU/5dVLXqixPUUHMWd0aSunVQ8HUFdAJO5x284z/UreaaN7vg1H3oD8YIUN?= =?us-ascii?Q?5iQkiz+bQ2I6J87kve4609/UGDEP1O1LlQdCzQ9chsVuzNmb99qJt8Q7NWnl?= =?us-ascii?Q?bZiWN3lSebVVohY+zg/ItBWr/E+bkx5BfDVQzFIY4zYxN620p88rJ5sJadKz?= =?us-ascii?Q?QDkoSjUDCccCjxtpdT/3l+cdoyqPa4jnRfCYQEp1LDw91WUR1nKZR/12igH8?= =?us-ascii?Q?MTUC9r8KYdt8xXtJk4gvUqfCXbQMULVwQYTCFJEVSbBbANCiOpbuVGV00/mr?= =?us-ascii?Q?lAPkKmBKJnhF7cudzFiRWdEpln/p4liAV40IvUQt3yMCnqKzXka4eIAdpg3z?= =?us-ascii?Q?PXVCru+1EV9bWGOweTER8Z7dVdlhG01GCVmW+O+9C73W1PZlbarVg/7JrRgn?= =?us-ascii?Q?P0RNdh1TXNePw4XEQcCPP8lbGLG+fjXu1yYPFzGDNtsu9hHic/TogBznWct5?= =?us-ascii?Q?OhqKJginZOsl2s9L3jX0fDv3uD/hSfx9?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL3PR11MB6410.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?J5yMPimDI66nXro1+yl2Y+NuoIKPejDnbF2GMPXprF0L2mJiVgNsdBxrluRg?= =?us-ascii?Q?R2rFNav09p9fquToqtQR7f6iqxsMO2rz9mytwoivLPoqOd2ALubL8vbP5ZbV?= =?us-ascii?Q?gWZRrdmVHqhnuJ14svNlk64DOAT+kYM8qA+B9KCL+xA0YVuCnXdOw0TY5ktH?= =?us-ascii?Q?SGScWqfd0c7YC041W4pLx/j2XMRJQmrXwVfseeP65ZxYXZvuZ9H++E4FxcUT?= =?us-ascii?Q?mHvIrAghDPWnNTHkSFjU2wPqYvgsPEmenLg92Dsoeg0ySjDYk1Te2w1BSfsp?= =?us-ascii?Q?iJgkrv3tj/Jvtr68f7UB9WJm9768wPCbzqfxl4gzNPc9KPEZEJhlfTrOxUdC?= =?us-ascii?Q?mnlNDYrBUBokgQsJ3RM8fweS3NfJnftoUzncLAgf54J57RwHrv5TX1BdQx8j?= =?us-ascii?Q?xdn7sS4HX0VDftiNVQV1wSzhkrRymBX5CKKOnIWgGUBLZIgrj92qlYEcvnmD?= =?us-ascii?Q?TsGS37bIUjAuIGSKRqv3Y+MbyD5aRP7vIAFK02Gf0Jlh8otmqpraXP8YzHdE?= =?us-ascii?Q?pcVVD9A4zdxoRs4k2Uu5m13DZuw6XjBXjyPpRYIPGqJfRr9/Usz5qunnuVej?= =?us-ascii?Q?XFDRcYXOQQW8AzkFsEdPPiNSl2vDVDqGs9w6hS+UoYsx0amYQkSTd/Xkh749?= =?us-ascii?Q?RmHstj7OML78EuZzhCaV2Q4i989YTnghCKaTk0NXb5QPTqT1D3U97v6qanCX?= =?us-ascii?Q?KMo/vAKt/59DCi3tLlcx64pGT7Jru9ikcRLhVd0VlY5Yu1Ast2AcdWTl8uAw?= =?us-ascii?Q?/JZLEjixUU0adygyix6o0n4h8QrGvBwLDwunD3qZKAp9YpD8xoYgAT87i2Pp?= =?us-ascii?Q?amCmvmt4kd7FSPZw1Ipxu07fO/RCRycEBJc0OX4MRz30KW4KDHry3k/2BasA?= =?us-ascii?Q?MrkZyoQoiNWNPxAU0sM2lBpijxkFhQKGV98a+TaRvAM0aK1dFdxArQC150xn?= =?us-ascii?Q?V+OcrqtT1MenoBWtzE/UYq4iWCLv9OXMfE08GmjAU6arz8QJSTMXEr0FhVli?= =?us-ascii?Q?JDGbfLzwtbJw7GPZBgXTXeGh8EeXgZCZubU6fbCC69GxA3sgnxfRLI5G090e?= =?us-ascii?Q?W0WCu6A4kL/HN0L/OS8hoBF69y6DLaeJXgz9XtAj09JOdkqbUAGpsEhiyqJ9?= =?us-ascii?Q?RoBFvUNDthVLR0UAkMO5Q+9UNmw/Zl7g859Toa2gU0Lt2kf9khLvC5b4p/kk?= =?us-ascii?Q?agOZ5Dwc7QZTDXHVQiIkxVvZc0d/c9eVj+NWf0TfGLvEpIyrIEa1/2SEAVcr?= =?us-ascii?Q?ZWvSxaxBLsfAg6WV4JS68bq2fmWOnmb9hf3g34OFGYsBG0kZbPwh/303/Kk3?= =?us-ascii?Q?lSBAuc4b+VehmaXwfYgeHQ6/CEySbsZWGD4+To5ya1lyHwgpdNqPSlQPBeh8?= =?us-ascii?Q?lmf31IC2BUQ3JQ2vMJeOeHlOIX8FOO8z2BN+NEvzyg1HW4whrRZDEU+8rokh?= =?us-ascii?Q?95gf0ezkWEYOXZGCxjgseNaK+MIsQkmPpBQyP2EXjZ3qj+zXIEaztHzy4Q6Z?= =?us-ascii?Q?wJgW8z0N7cZFnZKeiKaqh0bzAH0LEfx4sHVkMYt8OyPySx11YxW8vw4n8yL5?= =?us-ascii?Q?+QY5po28ROGANa8FiA1HjZaDLg/LcKPYcM0ZdUUFWH+XPdvdIcTEcutlIwLd?= =?us-ascii?Q?O7ODZugaUyDGbn2oV/qGQFy+t4Z2rbOwwebEWMRnYaMggg6F5C8I0ySi3F4j?= =?us-ascii?Q?KBIoS+0uIpK+hrhqI3debrLgPdPzF64lvGPGjoVYYQACN7gf970RsiSYpedt?= =?us-ascii?Q?sI3k8xO8HmWgg8oDkGPoXfD14sEHlo27IkwtI7YNju91TLyQLKD2?= X-MS-Exchange-CrossTenant-Network-Message-Id: c64efe37-75b2-4d55-eaac-08de5337aeed X-MS-Exchange-CrossTenant-AuthSource: BL3PR11MB6410.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2026 06:39:35.7387 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Cjl99zqoXCp94QMUX0Jw9GyDY15oLp1DQN7CiaB1xvBjqP2t1WF6SewZWNt8uEO/4fzOJW98IpV27fCTwG5xT1Zkkrsh5PNxulm1ZMxuLklf2bVbOhsBM1KdQvi2kdQC X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6707 X-OriginatorOrg: intel.com X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Wed, Jan 14, 2026 at 06:32:36AM +0000, Xin Wang wrote: >The spinner preempt flag enables queue preemption and multi-queue >switching. Always enable premept flag while inserting multi-queue >switch point. We need multi-queue switch point only in Q0 which >acts as a gating queue until all other queues with different >priorities are submitted to hardware. NIT...may be bit of rewording... "In priority test, we need multi-queue switch point only in Q0..." In any case, LGTM. Reviewed-by: Niranjana Vishwanathapura > >Suggested-by: Niranjana Vishwanathapura >Signed-off-by: Xin Wang >--- > lib/xe/xe_spin.c | 2 +- > tests/intel/xe_exec_multi_queue.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/lib/xe/xe_spin.c b/lib/xe/xe_spin.c >index 4dc110c22..0bc06aec3 100644 >--- a/lib/xe/xe_spin.c >+++ b/lib/xe/xe_spin.c >@@ -181,7 +181,7 @@ void xe_spin_init(struct xe_spin *spin, struct xe_spin_opts *opts) > */ > if (opts->multi_queue_switch) { > uint64_t wait_addr = opts->addr + offsetof(struct xe_spin, wait_cond); >- >+ igt_assert_f(opts->preempt, "preempt field is required to enable multi-queue switching\n"); > spin->batch[b++] = MI_SEMAPHORE_WAIT_CMD | > MI_SEMAPHORE_POLL | > MI_SEMAPHORE_QUEUE_SWITCH_MODE | >diff --git a/tests/intel/xe_exec_multi_queue.c b/tests/intel/xe_exec_multi_queue.c >index 6bc6f9f63..32a84ef6b 100644 >--- a/tests/intel/xe_exec_multi_queue.c >+++ b/tests/intel/xe_exec_multi_queue.c >@@ -453,8 +453,8 @@ __test_priority(int fd, struct drm_xe_engine_class_instance *eci, > > for (i = 0; i < num_queues; i++) { > uint64_t spin_addr = addr + i * sizeof(struct xe_spin); >- >- xe_spin_init_opts(spin[i], .addr = spin_addr, .multi_queue_switch = true); >+ /* Insert multi-queue switch point in Q0 to validate priority based queue switching */ >+ xe_spin_init_opts(spin[i], .addr = spin_addr, .multi_queue_switch = !i, .preempt = !i); > sync.addr = spin_addr + (char *)&spin[i]->exec_sync - (char *)spin[i]; > exec.exec_queue_id = exec_queues[i]; > exec.address = spin_addr; >-- >2.43.0 >