From: Jan Maslak <jan.maslak@intel.com>
To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Cc: <igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t 1/2] tests/xe_render_copy: Skip if platform doesn't support flatccs
Date: Thu, 15 Jan 2026 15:02:07 +0100 [thread overview]
Message-ID: <aWjzX8338AzAu5t6@ART-DEV-395> (raw)
In-Reply-To: <20260115092155.114781-5-zbigniew.kempczynski@intel.com>
LGTM,
Reviewed-by: Jan Maslak <jan.maslak@intel.com>
On Thu, Jan 15, 2026 at 10:21:57AM +0100, Zbigniew Kempczyński wrote:
> If device doesn't support flatccs skip the test, otherwise we fail
> during buffer creation which rely on this flag.
>
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Jan Maślak <jan.maslak@intel.com>
> ---
> tests/intel/xe_render_copy.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/intel/xe_render_copy.c b/tests/intel/xe_render_copy.c
> index e2e752e28b..861daec971 100644
> --- a/tests/intel/xe_render_copy.c
> +++ b/tests/intel/xe_render_copy.c
> @@ -710,6 +710,8 @@ int igt_main_args("dpiW:H:", NULL, help_str, opt_handler, NULL)
> for (int id = 0; id <= COPY_FULL_COMPRESSED; id++) {
> igt_subtest_with_dynamic_f("render-%s", testname[id]) {
> igt_require(xe_has_engine_class(xe, DRM_XE_ENGINE_CLASS_RENDER));
> + if (id == COPY_FULL_COMPRESSED)
> + igt_require(HAS_FLATCCS(buf_ops_get_devid(bops)));
>
> for_each_tiling(tiling) {
> if (!render_supports_tiling(xe, tiling,
> --
> 2.43.0
>
next prev parent reply other threads:[~2026-01-15 14:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 9:21 [PATCH i-g-t 0/2] Add missing flatccs flag for NVL-S Zbigniew Kempczyński
2026-01-15 9:21 ` [PATCH i-g-t 1/2] tests/xe_render_copy: Skip if platform doesn't support flatccs Zbigniew Kempczyński
2026-01-15 14:02 ` Jan Maslak [this message]
2026-01-15 9:21 ` [PATCH i-g-t 2/2] lib/intel_device_info: Add missing flatccs flag for NVL-S Zbigniew Kempczyński
2026-01-15 14:03 ` Jan Maslak
2026-01-15 10:05 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-01-15 10:23 ` ✓ i915.CI.BAT: " Patchwork
2026-01-15 11:15 ` ✓ Xe.CI.Full: " Patchwork
2026-01-15 12:29 ` ✗ i915.CI.Full: failure " Patchwork
2026-01-15 14:54 ` Zbigniew Kempczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWjzX8338AzAu5t6@ART-DEV-395 \
--to=jan.maslak@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox