Re: [PATCH i-g-t v2] lib/igt_kms: use for_each_crtc() for iterating CRTCs

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Feb 11, 2026 at 11:16:35AM +0200, Jani Nikula wrote:
> The loop still figures out the pipe mask, keep using pipe here. The main
> thing is not using the loop index as pipe, as that is subject to change
> in the future.
> 
> v2: 1 << pipe (Ville)
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  lib/igt_kms.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index c4be889dc696..68d61472d9e8 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -3622,16 +3622,14 @@ igt_output_t **__igt_pipe_populate_outputs(igt_display_t *display, igt_output_t
>  {
>  	unsigned full_pipe_mask = 0, assigned_pipes = 0;
>  	igt_output_t *output;
> +	igt_crtc_t *crtc;
>  	int i, j;
>  
>  	memset(chosen_outputs, 0,
>  	       sizeof(*chosen_outputs) * igt_display_n_crtcs(display));
>  
> -	for (i = 0; i < igt_display_n_crtcs(display); i++) {
> -		igt_crtc_t *crtc = igt_crtc_for_pipe(display, i);
> -		if (crtc->valid)
> -			full_pipe_mask |= (1 << i);
> -	}
> +	for_each_crtc(display, crtc)
> +		full_pipe_mask |= 1 << crtc->pipe;
>  
>  	/*
>  	 * Try to assign all outputs to the first available CRTC for
> -- 
> 2.47.3

-- 
Ville Syrjälä
Intel