From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 470D8E98DED for ; Mon, 23 Feb 2026 06:41:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DD33F10E240; Mon, 23 Feb 2026 06:41:30 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="fPwIs9ZR"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id B3AF410E240 for ; Mon, 23 Feb 2026 06:41:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771828890; x=1803364890; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=aEt1LJTohQ1EFxsxQngF1uRaE5tlehk3aG6BWMoj6CE=; b=fPwIs9ZRcGIk3bXH0ukSpmTlIgVuueLN91WC60AkN+Dn5kY0Ck6hQsA3 RiO+9MMhH59A+9XKkkq6cNoTHIWxTj6dMk+VBk1ZbW7+Qe/U+VwYzqmaO qe2bn9fv8JluGtagq52OM5AUX8/8BjlP1gfEaLPXJtAwAql2inTCKzLvf uqlNWbH+IUJrq1aanffJJgBqMFxvfte/qzpw4FyBqxNXB0HfGlC8jn77v uXdGy469SWZu24sjz8bHBbzqxClQv6Te9xNTpjH9XlOseq4W64ZX7CjgO XpMwmpmFtVi3AuT9y6r661ziyTEdqv2EqLTrDgrj0prh6r42dby3hLR1J A==; X-CSE-ConnectionGUID: wJVPCSa9QDCn7O8zF+HJRA== X-CSE-MsgGUID: 9Z1+tSVQQPueEGWiybp/Ag== X-IronPort-AV: E=McAfee;i="6800,10657,11709"; a="83530867" X-IronPort-AV: E=Sophos;i="6.21,306,1763452800"; d="scan'208";a="83530867" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2026 22:41:29 -0800 X-CSE-ConnectionGUID: iPJeNU6XShGnIT67wkl0nQ== X-CSE-MsgGUID: 26mhxT91TayA6cKueN/dMw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,306,1763452800"; d="scan'208";a="212896603" Received: from vpanait-mobl.ger.corp.intel.com (HELO localhost) ([10.245.245.194]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2026 22:41:28 -0800 Date: Mon, 23 Feb 2026 08:41:25 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Ankit Nautiyal Cc: igt-dev@lists.freedesktop.org, kamil.konieczny@linux.intel.com Subject: Re: [PATCH i-g-t 1/2] tools/intel_vbt_decode: sync intel_vbt_defs.h with commit 4d33c77cf2c3 Message-ID: References: <20260223040859.1362813-1-ankit.k.nautiyal@intel.com> <20260223040859.1362813-2-ankit.k.nautiyal@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260223040859.1362813-2-ankit.k.nautiyal@intel.com> X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Mon, Feb 23, 2026 at 09:38:58AM +0530, Ankit Nautiyal wrote: > Synchronize intel_vbt_defs.h with kernel commit: > 4d33c77cf2c3 ("drm/i915/vbt: Add eDP Data rate overrride field in VBT") > > v2: Correct the commit id that matches with changes in intel_vbt_defs.h > (Kamil) > > Signed-off-by: Ankit Nautiyal > --- > tools/intel_vbt_decode.c | 36 ++++++++++++++++++++++++++++++++++++ > tools/intel_vbt_defs.h | 18 ++++++++++++++++++ > 2 files changed, 54 insertions(+) > > diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c > index d4aada743e42..6f6f70dcee63 100644 > --- a/tools/intel_vbt_decode.c > +++ b/tools/intel_vbt_decode.c > @@ -1125,6 +1125,39 @@ static const char * const hdmi_frl_rate_str[] = { > [5] = "12 GT/s", > }; > > +static void dump_edp_data_rate_override(uint32_t edp_data_rate_override) > +{ > + int i; > + static const uint32_t link_rates[BDB_263_VBT_EDP_NUM_RATES][2] = { > + { BDB_263_VBT_EDP_LINK_RATE_1_62, 162000 }, > + { BDB_263_VBT_EDP_LINK_RATE_2_16, 216000 }, > + { BDB_263_VBT_EDP_LINK_RATE_2_43, 243000 }, > + { BDB_263_VBT_EDP_LINK_RATE_2_7, 270000 }, > + { BDB_263_VBT_EDP_LINK_RATE_3_24, 324000 }, > + { BDB_263_VBT_EDP_LINK_RATE_4_32, 432000 }, > + { BDB_263_VBT_EDP_LINK_RATE_5_4, 540000 }, > + { BDB_263_VBT_EDP_LINK_RATE_6_75, 675000 }, > + { BDB_263_VBT_EDP_LINK_RATE_8_1, 810000 }, > + { BDB_263_VBT_EDP_LINK_RATE_10, 1000000 }, > + { BDB_263_VBT_EDP_LINK_RATE_13_5, 1350000 }, > + { BDB_263_VBT_EDP_LINK_RATE_20, 2000000}, > + }; > + > + edp_data_rate_override &= BDB_263_VBT_EDP_RATES_MASK; > + > + printf("\t\teDP data rate override:"); > + > + if (!edp_data_rate_override) { > + printf("(none)\n"); > + return; > + } > + printf("\n"); > + > + for (i = 0; i < BDB_263_VBT_EDP_NUM_RATES; i++) > + if (link_rates[i][0] & edp_data_rate_override) > + printf("\t\t\t%d kbps\n", link_rates[i][1]); > +} This part has nothing to do with syncing the header. Please split the updates to the tool into separate patches. > + > static void dump_child_device(struct context *context, > const struct child_device_config *child) > { > @@ -1285,6 +1318,9 @@ static void dump_child_device(struct context *context, > > if (context->bdb->version >= 256) > printf("\t\tEFP panel index: %d\n", child->efp_index); > + > + if (context->bdb->version >= 263) > + dump_edp_data_rate_override(child->edp_data_rate_override); > } > > static void dump_child_devices(struct context *context, const uint8_t *devices, > diff --git a/tools/intel_vbt_defs.h b/tools/intel_vbt_defs.h > index 6612d3a4ec49..932305df2320 100644 > --- a/tools/intel_vbt_defs.h > +++ b/tools/intel_vbt_defs.h > @@ -437,6 +437,22 @@ enum vbt_gmbus_ddi { > #define BDB_230_VBT_DP_MAX_LINK_RATE_UHBR13P5 6 > #define BDB_230_VBT_DP_MAX_LINK_RATE_UHBR20 7 > > +/* EDP link rate 263+ */ > +#define BDB_263_VBT_EDP_LINK_RATE_1_62 (1 << 0) > +#define BDB_263_VBT_EDP_LINK_RATE_2_16 (1 << 1) > +#define BDB_263_VBT_EDP_LINK_RATE_2_43 (1 << 2) > +#define BDB_263_VBT_EDP_LINK_RATE_2_7 (1 << 3) > +#define BDB_263_VBT_EDP_LINK_RATE_3_24 (1 << 4) > +#define BDB_263_VBT_EDP_LINK_RATE_4_32 (1 << 5) > +#define BDB_263_VBT_EDP_LINK_RATE_5_4 (1 << 6) > +#define BDB_263_VBT_EDP_LINK_RATE_6_75 (1 << 7) > +#define BDB_263_VBT_EDP_LINK_RATE_8_1 (1 << 8) > +#define BDB_263_VBT_EDP_LINK_RATE_10 (1 << 9) > +#define BDB_263_VBT_EDP_LINK_RATE_13_5 (1 << 10) > +#define BDB_263_VBT_EDP_LINK_RATE_20 (1 << 11) > +#define BDB_263_VBT_EDP_NUM_RATES 12 > +#define BDB_263_VBT_EDP_RATES_MASK 0xfff > + > /* > * The child device config, aka the display device data structure, provides a > * description of a port and its configuration on the platform. > @@ -547,6 +563,8 @@ struct child_device_config { > u8 dp_max_link_rate:3; /* 216+ */ > u8 dp_max_link_rate_reserved:5; /* 216+ */ > u8 efp_index; /* 256+ */ > + u32 edp_data_rate_override:12; /* 263+ */ > + u32 edp_data_rate_override_reserved:20; /* 263+ */ > } __packed; > > struct bdb_general_definitions { > -- > 2.45.2 -- Ville Syrjälä Intel