public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] lib/intel_compute: Wait for compute walker before returning to ring
@ 2026-01-22 10:45 Zbigniew Kempczyński
  2026-01-22 14:55 ` ✓ i915.CI.BAT: success for " Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 9+ messages in thread
From: Zbigniew Kempczyński @ 2026-01-22 10:45 UTC (permalink / raw)
  To: igt-dev
  Cc: Zbigniew Kempczyński, Matthew Brost, Daniele Ceraolo Spurio,
	Francois Dugast

Most compute tests don't need to synchronize at the batch level as
kmd executes pipe-control at some point. Last xe driver proposal (link
below) causes turning off preemption before pipe-control preventing
entering to SIP and finish the WMTP test properly.

Change adds pipe-control at batch level causing sync wait on
compute-walker and preventing disabling the preemption prematurely.

Link: https://patchwork.freedesktop.org/series/160113/
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Francois Dugast <francois.dugast@intel.com>
---
 lib/intel_compute.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/lib/intel_compute.c b/lib/intel_compute.c
index 00ef280e8f..8578b6e402 100644
--- a/lib/intel_compute.c
+++ b/lib/intel_compute.c
@@ -1694,6 +1694,13 @@ static void xe2lpg_compute_exec_compute(int fd,
 	addr_bo_buffer_batch[b++] = 0x00000000;
 	addr_bo_buffer_batch[b++] = 0x00000000;
 
+	addr_bo_buffer_batch[b++] = PIPE_CONTROL;
+	addr_bo_buffer_batch[b++] = 0x00100000;
+	addr_bo_buffer_batch[b++] = 0x00000000;
+	addr_bo_buffer_batch[b++] = 0x00000000;
+	addr_bo_buffer_batch[b++] = 0x00000000;
+	addr_bo_buffer_batch[b++] = 0x00000000;
+
 	addr_bo_buffer_batch[b++] = MI_BATCH_BUFFER_END;
 }
 
@@ -2032,6 +2039,13 @@ static void xe3p_compute_exec_compute(int fd,
 	addr_bo_buffer_batch[b++] = 0x00000000; /* dw62 */
 	addr_bo_buffer_batch[b++] = 0x00000000; /* dw63 */
 
+	addr_bo_buffer_batch[b++] = PIPE_CONTROL;
+	addr_bo_buffer_batch[b++] = 0x00100000;
+	addr_bo_buffer_batch[b++] = 0x00000000;
+	addr_bo_buffer_batch[b++] = 0x00000000;
+	addr_bo_buffer_batch[b++] = 0x00000000;
+	addr_bo_buffer_batch[b++] = 0x00000000;
+
 	addr_bo_buffer_batch[b++] = MI_BATCH_BUFFER_END;
 }
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2026-02-26 18:20 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-22 10:45 [PATCH i-g-t] lib/intel_compute: Wait for compute walker before returning to ring Zbigniew Kempczyński
2026-01-22 14:55 ` ✓ i915.CI.BAT: success for " Patchwork
2026-01-23  2:47 ` ✗ i915.CI.Full: failure " Patchwork
2026-01-27  9:13 ` ✓ Xe.CI.BAT: success for lib/intel_compute: Wait for compute walker before returning to ring (rev2) Patchwork
2026-01-27  9:16 ` ✗ i915.CI.BAT: failure " Patchwork
2026-01-27 11:11 ` ✗ Xe.CI.Full: " Patchwork
2026-02-02 14:15 ` [PATCH i-g-t] lib/intel_compute: Wait for compute walker before returning to ring Francois Dugast
2026-02-03  7:57   ` Zbigniew Kempczyński
2026-02-26 18:20     ` Matthew Brost

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox