From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 00/10] tests: avoid using crtc->pipe where possible
Date: Tue, 10 Mar 2026 12:20:18 +0200 [thread overview]
Message-ID: <aa_wYugxXowLvlTI@intel.com> (raw)
In-Reply-To: <cover.1773066012.git.jani.nikula@intel.com>
On Mon, Mar 09, 2026 at 04:21:34PM +0200, Jani Nikula wrote:
> Tests should generally avoid using crtc->pipe if possible. It's an Intel
> implementation detail, and crtc->crtc_index is the generic thing to
> use. Do some conversions to crtc_index use.
>
>
> Jani Nikula (10):
> tests/kms_writeback: use igt_crtc_name()
> tests/kms_colorop: use igt_crtc_name()
> tests/kms_color_pipeline: use igt_crtc_name()
> tests/kms_cursor_crc: use CRTC indexes instead of pipes for CRTC
> tracking
> tests/kms_cursor_edge_walk: use CRTC indexes instead of pipes for CRTC
> tracking
> tests/kms_pipe_crc_basic: use CRTC indexes instead of pipes for CRTC
> tracking
> tests/kms_plane_alpha_blend: use CRTC indexes instead of pipes for
> CRTC tracking
> tests/kms_vblank: use CRTC indexes instead of pipes for CRTC tracking
> tests/kms_cursor_legacy: use CRTC indexes instead of pipes for CRTC
> tracking
> tests/kms_debugfs: use CRTC indexes instead of pipes for fb tracking
I'd just nuke the array from kms_debugfs.
But no big deal either way. Series is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> tests/kms_color_pipeline.c | 2 +-
> tests/kms_colorop.c | 4 ++--
> tests/kms_cursor_crc.c | 16 ++++++++--------
> tests/kms_cursor_edge_walk.c | 14 +++++++-------
> tests/kms_cursor_legacy.c | 2 +-
> tests/kms_debugfs.c | 4 ++--
> tests/kms_pipe_crc_basic.c | 14 +++++++-------
> tests/kms_plane_alpha_blend.c | 14 +++++++-------
> tests/kms_vblank.c | 20 ++++++++++----------
> tests/kms_writeback.c | 4 ++--
> 10 files changed, 47 insertions(+), 47 deletions(-)
>
> --
> 2.47.3
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2026-03-10 10:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 14:21 [PATCH i-g-t 00/10] tests: avoid using crtc->pipe where possible Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 01/10] tests/kms_writeback: use igt_crtc_name() Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 02/10] tests/kms_colorop: " Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 03/10] tests/kms_color_pipeline: " Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 04/10] tests/kms_cursor_crc: use CRTC indexes instead of pipes for CRTC tracking Jani Nikula
2026-03-10 10:05 ` Ville Syrjälä
2026-03-10 10:52 ` Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 05/10] tests/kms_cursor_edge_walk: " Jani Nikula
2026-03-09 14:25 ` Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 06/10] tests/kms_pipe_crc_basic: " Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 07/10] tests/kms_plane_alpha_blend: " Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 08/10] tests/kms_vblank: " Jani Nikula
2026-03-09 14:25 ` Jani Nikula
2026-03-09 16:48 ` [PATCH i-g-t v2] " Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 09/10] tests/kms_cursor_legacy: " Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 10/10] tests/kms_debugfs: use CRTC indexes instead of pipes for fb tracking Jani Nikula
2026-03-10 10:08 ` Ville Syrjälä
2026-03-09 23:58 ` ✓ i915.CI.BAT: success for tests: avoid using crtc->pipe where possible (rev2) Patchwork
2026-03-10 0:04 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-10 5:31 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-03-10 9:03 ` ✗ i915.CI.Full: " Patchwork
2026-03-10 10:20 ` Ville Syrjälä [this message]
2026-03-10 11:24 ` [PATCH i-g-t 00/10] tests: avoid using crtc->pipe where possible Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa_wYugxXowLvlTI@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox