Re: [PATCH i-g-t v1] tests/kms_invalid_mode: add prints when test skips

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Mon, Mar 02, 2026 at 12:20:31PM +0000, Samala, Pranay wrote:
> Hi Sumit,
> 
> > -----Original Message-----
> > From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of sumit
> > kishore
> > Sent: Monday, March 2, 2026 4:54 PM
> > To: igt-dev@lists.freedesktop.org
> > Cc: Joshi, Kunal1 <kunal1.joshi@intel.com>; Kishore, Sumit
> > <sumit.kishore@intel.com>
> > Subject: [PATCH i-g-t v1] tests/kms_invalid_mode: add prints when test skips
> Title should start with a capital letter "Add" not "add"
> 
> > 
> > add debug print to display the reason for test skip
> > 
> > Signed-off-by: sumit kishore <sumit.kishore@intel.com>
> > ---
> >  tests/kms_invalid_mode.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c index
> > 5edffb649..8ba488812 100644
> > --- a/tests/kms_invalid_mode.c
> > +++ b/tests/kms_invalid_mode.c
> > @@ -266,7 +266,9 @@ test_output(data_t *data)
> >  	 * sure everything is really getting rejected?
> >  	 */
> >  	mode = *igt_output_get_mode(output);
> > -	igt_require(data->adjust_mode(data, &mode));
> > +	igt_require_f(data->adjust_mode(data, &mode),
> > +		"Skipping as %s has scaling properties\n",
> > igt_output_name(output));
> This skip message isn't quite accurate. Only clock-too-high subtest checks for scaling property. All other adjust_mode functions simply return true.

That check is pretty much outdated anyway. The kernel will reject
the mode if the vrefresh doesn't match any of the connector's
fixed modes. So we should probably just remove the check.

> 
> Imho, It would be better to add the debug message directly in that function.
> 
> Regards,
> Pranay
> > +
> > 
> >  	igt_create_fb(data->drm_fd,
> >  		      max_t(uint16_t, mode.hdisplay, 64),
> > --
> > 2.43.0

-- 
Ville Syrjälä
Intel