From: Jani Nikula <jani.nikula@intel.com>
To: Jeevan B <jeevan.b@intel.com>, igt-dev@lists.freedesktop.org
Cc: pranay.samala@intel.com, karthik.b.s@intel.com,
Jeevan B <jeevan.b@intel.com>
Subject: Re: [PATCH i-g-t 2/8] tests/kms_panel_fitting: Find fastboot param with a dedicated display module
Date: Thu, 19 Nov 2026 11:13:56 +0200 [thread overview]
Message-ID: <aad093d91c79284b812dfb3968d1b374d6e0f998@intel.com> (raw)
In-Reply-To: <20261118154426.345883-3-jeevan.b@intel.com>
On Wed, 18 Nov 2026, Jeevan B <jeevan.b@intel.com> wrote:
> The test checked for /sys/module/{i915,xe}/parameters/fastboot before
> forcing fastboot. With display split into intel_display.ko the parameter
> lives in /sys/module/intel_display/parameters, so the check failed and
> fastboot was silently not forced.
>
> Look the parameter up through igt_params, which searches the GPU driver
> module and then intel_display.
The module parameter has been removed by commit 58883680a841 ("drm/i915:
Remove the module parameter 'fastboot'") in kernel v6.7.
BR,
Jani.
>
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
> tests/kms_panel_fitting.c | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
> index 478e8b5d7..64b992bea 100644
> --- a/tests/kms_panel_fitting.c
> +++ b/tests/kms_panel_fitting.c
> @@ -254,19 +254,22 @@ static void test_panel_fitting(data_t *data, enum test_type type)
> igt_display_t *display = &data->display;
> igt_output_t *output;
> igt_crtc_t *crtc;
> - struct stat sb;
>
> if (type == TEST_ATOMIC) {
> - char path[PATH_MAX];
> + char *fastboot;
>
> igt_require_f(is_intel_device(display->drm_fd), "not valid for non-intel devices\n");
>
> - /* Until this is force enabled, force modeset evasion. */
> - snprintf(path, PATH_MAX, "/sys/module/%s/parameters/fastboot",
> - is_i915_device(data->drm_fd) ? "i915" : "xe");
> -
> - if (stat(path, &sb) == 0)
> + /*
> + * Until this is force enabled, force modeset evasion. The parameter
> + * lives in the GPU driver or, with a dedicated display module, in
> + * intel_display; igt_params looks in both.
> + */
> + fastboot = __igt_params_get(data->drm_fd, "fastboot");
> + if (fastboot) {
> + free(fastboot);
> igt_set_module_param_int(data->drm_fd, "fastboot", 1);
> + }
>
> igt_require(intel_display_ver(intel_get_drm_devid(display->drm_fd)) >= 5);
--
Jani Nikula, Intel
next prev parent reply other threads:[~2026-11-19 9:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 15:44 [PATCH i-g-t 0/8] RFC: Add intel_display module support to module load tests Jeevan B
2026-11-18 15:44 ` [PATCH i-g-t 1/8] lib/igt_params: Fall back to intel_display module parameters Jeevan B
2026-11-18 15:44 ` [PATCH i-g-t 2/8] tests/kms_panel_fitting: Find fastboot param with a dedicated display module Jeevan B
2026-11-19 9:13 ` Jani Nikula [this message]
2026-11-18 15:44 ` [PATCH i-g-t 3/8] tests/intel/i915_module_load: Check intel_display in load subtest Jeevan B
2026-11-18 15:44 ` [PATCH i-g-t 4/8] tests/intel/xe_module_load: Check intel_display in load subtests Jeevan B
2026-11-18 15:44 ` [PATCH i-g-t 5/8] lib/igt_kmod: Unload intel_display together with the GPU driver Jeevan B
2026-11-18 15:44 ` [PATCH i-g-t 6/8] tests/intel: Add intel_display_module_load test Jeevan B
2026-11-18 15:44 ` [PATCH i-g-t 7/8] tests/intel/xe_module_load: Verify driver unload result Jeevan B
2026-11-18 15:44 ` [PATCH i-g-t 8/8] tests/intel/i915_module_load: " Jeevan B
2026-11-19 3:40 ` ✓ Xe.CI.BAT: success for RFC: Add intel_display module support to module load tests Patchwork
2026-11-19 12:46 ` ✗ i915.CI.BAT: failure " Patchwork
2026-11-20 3:40 ` ✗ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aad093d91c79284b812dfb3968d1b374d6e0f998@intel.com \
--to=jani.nikula@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jeevan.b@intel.com \
--cc=karthik.b.s@intel.com \
--cc=pranay.samala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox