public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 1/2] tests/intel/kms_pipe_stress: use CRTC index not pipe for vblank ioctl
Date: Fri, 20 Mar 2026 13:57:20 +0200	[thread overview]
Message-ID: <ab02IKwdvnVkB9BI@intel.com> (raw)
In-Reply-To: <20260320113143.2882422-1-jani.nikula@intel.com>

On Fri, Mar 20, 2026 at 01:31:42PM +0200, Jani Nikula wrote:
> The vblank ioctl expects CRTC index, not pipe. Fix the pipe vs. CRTC
> index mixup by switching to use igt_crtc_get_vblank().
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  tests/intel/kms_pipe_stress.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/intel/kms_pipe_stress.c b/tests/intel/kms_pipe_stress.c
> index 85ab2ec50621..a0ce3c4d7ecb 100644
> --- a/tests/intel/kms_pipe_stress.c
> +++ b/tests/intel/kms_pipe_stress.c
> @@ -591,7 +591,7 @@ static void stress_pipes(struct data *data, struct timespec *start,
>  
>  		igt_pipe_crc_start(data->pipe_crc[pipe]);
>  		igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc[pipe], &crc);
> -		kmstest_get_vblank(data->display.drm_fd, crtc->pipe, DRM_VBLANK_NEXTONMISS);
> +		igt_crtc_get_vblank(crtc, DRM_VBLANK_NEXTONMISS);
>  		igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc[pipe], &crc2);
>  		igt_pipe_crc_stop(data->pipe_crc[pipe]);
>  		igt_assert_crc_equal(&crc, &crc2);
> -- 
> 2.47.3

-- 
Ville Syrjälä
Intel

  parent reply	other threads:[~2026-03-20 11:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-20 11:31 [PATCH i-g-t 1/2] tests/intel/kms_pipe_stress: use CRTC index not pipe for vblank ioctl Jani Nikula
2026-03-20 11:31 ` [PATCH i-g-t 2/2] lib/kms: fix igt_crtc_connector_valid() validity check Jani Nikula
2026-03-20 11:57   ` Ville Syrjälä
2026-03-20 11:57 ` Ville Syrjälä [this message]
2026-03-20 15:26 ` ✓ Xe.CI.BAT: success for series starting with [i-g-t,1/2] tests/intel/kms_pipe_stress: use CRTC index not pipe for vblank ioctl Patchwork
2026-03-20 15:44 ` ✓ i915.CI.BAT: " Patchwork
2026-03-21  7:26 ` ✗ i915.CI.Full: failure " Patchwork
2026-03-21 15:35 ` ✗ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab02IKwdvnVkB9BI@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox