From: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"kamil.konieczny@linux.intel.com"
<kamil.konieczny@linux.intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t v4] lib/i915: Add a helper to read mmio registers via ioctl
Date: Fri, 15 Sep 2023 20:32:16 +0000 [thread overview]
Message-ID: <ab7266446e039b8a70a144e5446d03fbf46373de.camel@intel.com> (raw)
In-Reply-To: <20230915175558.l5gt3yk7ddjkneey@kamilkon-desk.igk.intel.com>
On Fri, 2023-09-15 at 19:55 +0200, Kamil Konieczny wrote:
> Hi Alan,
> On 2023-09-14 at 20:29:14 -0700, Alan Previn wrote:
> > +__u64 i915_reg_read_ioctl(int drmfd, __u64 offset)
> > +{
> > + __u64 value;
> > +
> > + igt_assert_eq(__i915_reg_read_ioctl(drmfd, offset, &value), 0);
> > + errno = 0;
> --- ^
> Delete this, you already checked errno in assert.
> Put one empty line before return from function.
>
> Rest looks good.
>
alan: got it. thanks for your patience.
prev parent reply other threads:[~2023-09-15 20:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 3:29 [igt-dev] [PATCH i-g-t v4] lib/i915: Add a helper to read mmio registers via ioctl Alan Previn
2023-09-15 4:52 ` [igt-dev] ✓ CI.xeBAT: success for lib/i915: Add a helper to read mmio registers via ioctl (rev3) Patchwork
2023-09-15 4:58 ` [igt-dev] ✓ Fi.CI.BAT: " Patchwork
2023-09-15 13:25 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-09-15 17:55 ` [igt-dev] [PATCH i-g-t v4] lib/i915: Add a helper to read mmio registers via ioctl Kamil Konieczny
2023-09-15 20:32 ` Teres Alexis, Alan Previn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab7266446e039b8a70a144e5446d03fbf46373de.camel@intel.com \
--to=alan.previn.teres.alexis@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox