From: Antonio Argenziano <antonio.argenziano@intel.com>
To: Vinay Belgaumkar <vinay.belgaumkar@intel.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH-i-g-t] tests/i915/gem_mmap_wc: Skip gtt test if aperture is missing
Date: Fri, 24 Jan 2020 14:54:09 -0800 [thread overview]
Message-ID: <abc1e800-c85a-37d1-b5bd-5a3fc23bd869@intel.com> (raw)
In-Reply-To: <20200124211819.1796-1-vinay.belgaumkar@intel.com>
On 24/01/20 13:18, Vinay Belgaumkar wrote:
> Skip subtest on platforms that do not have mappable aperture.
>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> Cc: Antonio Argenziano <antonio.argenziano@intel.com>
> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
> tests/i915/gem_mmap_wc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_mmap_wc.c b/tests/i915/gem_mmap_wc.c
> index 375a9b50..d1f023d3 100644
> --- a/tests/i915/gem_mmap_wc.c
> +++ b/tests/i915/gem_mmap_wc.c
> @@ -599,8 +599,10 @@ igt_main
> test_write_cpu_read_wc(fd, 1);
> igt_subtest("write-cpu-read-wc-unflushed")
> test_write_cpu_read_wc(fd, 0);
> - igt_subtest("write-gtt-read-wc")
> + igt_subtest("write-gtt-read-wc") {
> + gem_require_mappable_ggtt(fd);
> test_write_gtt_read_wc(fd);
> + }
"write-gtt" needs some love as well (Even tough it is not doing what it
should right now).
Antonio
> igt_subtest("pf-nonblock")
> test_pf_nonblock(fd);
> igt_subtest("set-cache-level")
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-01-24 22:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 21:18 [igt-dev] [PATCH-i-g-t] tests/i915/gem_mmap_wc: Skip gtt test if aperture is missing Vinay Belgaumkar
2020-01-24 22:25 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-24 22:54 ` Antonio Argenziano [this message]
2020-01-27 13:49 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abc1e800-c85a-37d1-b5bd-5a3fc23bd869@intel.com \
--to=antonio.argenziano@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=vinay.belgaumkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox