From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: sumit kishore <sumit.kishore@intel.com>
Cc: igt-dev@lists.freedesktop.org, karthik.b.s@intel.com
Subject: Re: [PATCH i-g-t v2] tests/kms_properties: Add skip on headless machines
Date: Wed, 18 Mar 2026 21:06:01 +0200 [thread overview]
Message-ID: <abr3mcfHCmNGsnR2@intel.com> (raw)
In-Reply-To: <20260318140120.283593-1-sumit.kishore@intel.com>
On Wed, Mar 18, 2026 at 07:31:20PM +0530, sumit kishore wrote:
> Print debug messages for sub-tests which are expected to
> skip on headless display systems.
>
> v2: Use existing library function, instead of
> defining new (karthik)
>
> Signed-off-by: sumit kishore <sumit.kishore@intel.com>
> ---
> tests/kms_properties.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/kms_properties.c b/tests/kms_properties.c
> index f735839da..9f5649c90 100644
> --- a/tests/kms_properties.c
> +++ b/tests/kms_properties.c
> @@ -377,6 +377,8 @@ static void plane_properties(igt_display_t *display, bool atomic)
> igt_output_t *output;
> igt_crtc_t *crtc;
>
> + igt_display_require_output(display);
> +
> for_each_crtc_with_single_output(display, crtc, output) {
> igt_display_reset(display);
>
> @@ -400,6 +402,8 @@ static void crtc_properties(igt_display_t *display, bool atomic)
> igt_crtc_t *crtc;
> igt_output_t *output;
>
> + igt_display_require_output(display);
> +
I'm thinking these tests shouldn't even need an output. It should be
possible to set (at least most) plane/crtc properties regardless of
whether they're active or not.
> for_each_crtc_with_single_output(display, crtc, output) {
> igt_display_reset(display);
>
> --
> 2.43.0
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2026-03-18 19:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 14:01 [PATCH i-g-t v2] tests/kms_properties: Add skip on headless machines sumit kishore
2026-03-18 16:26 ` ✓ Xe.CI.BAT: success for tests/kms_properties: Add skip on headless machines (rev2) Patchwork
2026-03-18 16:35 ` ✗ i915.CI.BAT: failure " Patchwork
2026-03-18 17:28 ` [PATCH i-g-t v2] tests/kms_properties: Add skip on headless machines Samala, Pranay
2026-03-18 19:06 ` Ville Syrjälä [this message]
2026-03-25 6:31 ` Kishore, Sumit
2026-03-20 4:36 ` ✗ Xe.CI.FULL: failure for tests/kms_properties: Add skip on headless machines (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abr3mcfHCmNGsnR2@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=karthik.b.s@intel.com \
--cc=sumit.kishore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox