Re: [PATCH i-g-t v1] tests/intel/kms_frontbuffer_tracking: Improve skip message

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Thu, Apr 02, 2026 at 10:07:02AM +0530, Sowmiya S wrote:
> Replace vague or negative skip messages with standardized,
> explicit descriptions that clearly state why a test is
> being skipped.
> 
> Signed-off-by: Sowmiya S <sowmiya.s@intel.com>
> ---
>  tests/intel/kms_frontbuffer_tracking.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
> index c16f63199..6a7017256 100644
> --- a/tests/intel/kms_frontbuffer_tracking.c
> +++ b/tests/intel/kms_frontbuffer_tracking.c
> @@ -2548,20 +2548,20 @@ static void check_test_requirements(const struct test_mode *t)
>  {
>  	if (t->pipes == PIPE_DUAL)
>  		igt_require_f(scnd_mode_params.output,
> -			    "Can't test dual pipes with the current outputs\n");
> +			      "no valid secondary output available for dual-pipe tests\n");
>  
>  	if (t->feature & FEATURE_FBC)
>  		igt_require_f(fbc.can_test,
> -			      "Can't test FBC with this chipset\n");
> +			      "feature not supported (feature: fbc)\n");
>  
>  	if (t->feature & FEATURE_PSR) {
>  		igt_require_f(psr.can_test,
> -			      "Can't test PSR with the current outputs\n");
> +			      "feature not supported (feature: psr)\n");
>  	}
>  
>  	if (t->feature & FEATURE_DRRS)
>  		igt_require_f(drrs.can_test,
> -			      "Can't test DRRS with the current outputs\n");
> +			      "feature not supported (feature: drrs)\n");
>  
>  	/*
>  	 * In kernel, When PSR is enabled, DRRS will be disabled. So If a test
> @@ -2569,7 +2569,7 @@ static void check_test_requirements(const struct test_mode *t)
>  	 */
>  	igt_require_f(!((t->feature & FEATURE_PSR) &&
>  		      (t->feature & FEATURE_DRRS)),
> -		      "Can't test PSR and DRRS together\n");
> +		      "incompatible features (feature: psr & drrs)\n");

This doesn't look like an improvement to me. The old one clearly
says what happened, this new one form looks like something meant
to confuses humans and be parsed by some machine.

>  
>  	if (opt.only_pipes != PIPE_COUNT)
>  		igt_require(t->pipes == opt.only_pipes);
> -- 
> 2.43.0

-- 
Ville Syrjälä
Intel