public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH i-g-t v1] tests/intel/kms_frontbuffer_tracking: Improve skip message
@ 2026-04-02  4:37 Sowmiya S
  2026-04-02  5:08 ` ✓ i915.CI.BAT: success for " Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Sowmiya S @ 2026-04-02  4:37 UTC (permalink / raw)
  To: igt-dev; +Cc: karthik.b.s, swati2.sharma, Sowmiya S

Replace vague or negative skip messages with standardized,
explicit descriptions that clearly state why a test is
being skipped.

Signed-off-by: Sowmiya S <sowmiya.s@intel.com>
---
 tests/intel/kms_frontbuffer_tracking.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
index c16f63199..6a7017256 100644
--- a/tests/intel/kms_frontbuffer_tracking.c
+++ b/tests/intel/kms_frontbuffer_tracking.c
@@ -2548,20 +2548,20 @@ static void check_test_requirements(const struct test_mode *t)
 {
 	if (t->pipes == PIPE_DUAL)
 		igt_require_f(scnd_mode_params.output,
-			    "Can't test dual pipes with the current outputs\n");
+			      "no valid secondary output available for dual-pipe tests\n");
 
 	if (t->feature & FEATURE_FBC)
 		igt_require_f(fbc.can_test,
-			      "Can't test FBC with this chipset\n");
+			      "feature not supported (feature: fbc)\n");
 
 	if (t->feature & FEATURE_PSR) {
 		igt_require_f(psr.can_test,
-			      "Can't test PSR with the current outputs\n");
+			      "feature not supported (feature: psr)\n");
 	}
 
 	if (t->feature & FEATURE_DRRS)
 		igt_require_f(drrs.can_test,
-			      "Can't test DRRS with the current outputs\n");
+			      "feature not supported (feature: drrs)\n");
 
 	/*
 	 * In kernel, When PSR is enabled, DRRS will be disabled. So If a test
@@ -2569,7 +2569,7 @@ static void check_test_requirements(const struct test_mode *t)
 	 */
 	igt_require_f(!((t->feature & FEATURE_PSR) &&
 		      (t->feature & FEATURE_DRRS)),
-		      "Can't test PSR and DRRS together\n");
+		      "incompatible features (feature: psr & drrs)\n");
 
 	if (opt.only_pipes != PIPE_COUNT)
 		igt_require(t->pipes == opt.only_pipes);
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-04-06 10:18 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-02  4:37 [PATCH i-g-t v1] tests/intel/kms_frontbuffer_tracking: Improve skip message Sowmiya S
2026-04-02  5:08 ` ✓ i915.CI.BAT: success for " Patchwork
2026-04-02  5:24 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-02  8:58 ` ✓ Xe.CI.FULL: " Patchwork
2026-04-02 10:16 ` [PATCH i-g-t v1] " Ville Syrjälä
2026-04-06 10:18   ` S, Sowmiya
2026-04-02 21:44 ` ✗ i915.CI.Full: failure for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox