public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Kahola, Mika" <mika.kahola@intel.com>
To: "juhapekka.heikkila@gmail.com" <juhapekka.heikkila@gmail.com>,
	"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_cursor_legacy: increase timeout for nonblocking flip wait
Date: Mon, 9 Mar 2020 11:19:03 +0000	[thread overview]
Message-ID: <ac9ace63e65f68f798006b1cade6e042e91ce6a3.camel@intel.com> (raw)
In-Reply-To: <1583333427-18040-1-git-send-email-juhapekka.heikkila@gmail.com>

On Wed, 2020-03-04 at 16:50 +0200, Juha-Pekka Heikkila wrote:
> When run on more than one monitor there may be modeset in queue
> which will block flip. Kernel will timeout with modeset at
> ten seconds so lets wait in test also that same ten seconds at
> maximum.
> 
> V2 Ville Syrjälä: lets just wait for five seconds
Let's just do this.

Reviewed-by: Mika Kahola <mika.kahola@intel.com>

> 
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>


> ---
>  tests/kms_cursor_legacy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
> index f41f68d..d5f95b8 100644
> --- a/tests/kms_cursor_legacy.c
> +++ b/tests/kms_cursor_legacy.c
> @@ -251,7 +251,7 @@ static void flip_nonblocking(igt_display_t
> *display, enum pipe pipe_id, bool ato
>  	igt_plane_t *primary = igt_pipe_get_plane_type(pipe,
> DRM_PLANE_TYPE_PRIMARY);
>  	int ret;
>  
> -	igt_set_timeout(1, "Scheduling page flip\n");
> +	igt_set_timeout(5, "Scheduling page flip\n");
>  	if (!atomic) {
>  		/* Schedule a nonblocking flip for the next vblank */
>  		do {
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2020-03-09 11:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04 14:50 [igt-dev] [PATCH i-g-t] tests/kms_cursor_legacy: increase timeout for nonblocking flip wait Juha-Pekka Heikkila
2020-03-04 16:36 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_cursor_legacy: increase timeout for nonblocking flip wait (rev2) Patchwork
2020-03-05 13:32 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2020-03-09 11:19 ` Kahola, Mika [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-02-21 12:08 [igt-dev] [PATCH i-g-t] tests/kms_cursor_legacy: increase timeout for nonblocking flip wait Juha-Pekka Heikkila
2020-02-21 12:23 ` Chris Wilson
2020-02-21 13:12   ` Juha-Pekka Heikkila
2020-02-21 13:16     ` Chris Wilson
2020-02-21 13:24       ` Juha-Pekka Heikkila
2020-02-21 13:31       ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac9ace63e65f68f798006b1cade6e042e91ce6a3.camel@intel.com \
    --to=mika.kahola@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=juhapekka.heikkila@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox