public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Anirban, Sk" <sk.anirban@intel.com>
Cc: igt-dev@lists.freedesktop.org, anshuman.gupta@intel.com,
	badal.nilawar@intel.com, riana.tauro@intel.com,
	karthik.poosa@intel.com, raag.jadav@intel.com,
	soham.purkait@intel.com, mallesh.koujalagi@intel.com,
	vinay.belgaumkar@intel.com
Subject: Re: [PATCH] tests/intel/xe_pm_residency: Fix suspend duration calculation
Date: Mon, 23 Mar 2026 17:43:33 +0200	[thread overview]
Message-ID: <acFfpWxozSezlo7E@intel.com> (raw)
In-Reply-To: <6c1cd079-abbd-4487-b19f-bdf5e9f46c17@intel.com>

On Mon, Mar 23, 2026 at 08:06:44PM +0530, Anirban, Sk wrote:
> Hi,
> 
> On 23-03-2026 03:31 pm, Ville Syrjälä wrote:
> > On Mon, Mar 23, 2026 at 12:32:29PM +0530, Sk Anirban wrote:
> >> Fix the unit mismatch caused by interpreting seconds as milliseconds
> >> during suspend duration calculations. Apply MSEC_PER_SEC multiplier
> >> to ensure correct unit handling.
> >>
> >> Signed-off-by: Sk Anirban <sk.anirban@intel.com>
> >> ---
> >>   tests/intel/xe_pm_residency.c | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tests/intel/xe_pm_residency.c b/tests/intel/xe_pm_residency.c
> >> index 61b63ed4f..46718a444 100644
> >> --- a/tests/intel/xe_pm_residency.c
> >> +++ b/tests/intel/xe_pm_residency.c
> >> @@ -223,7 +223,7 @@ static void test_idle_residency(int fd, int gt, enum test_type flag)
> >>   		 * elapsed time during suspend is approximately equal to autoresume delay
> >>   		 * when a full suspend cycle(SUSPEND_TEST_NONE) is used.
> >>   		 */
> >> -		elapsed_ms = igt_get_autoresume_delay(SUSPEND_STATE_FREEZE);
> >> +		elapsed_ms = igt_get_autoresume_delay(SUSPEND_STATE_FREEZE) * MSEC_PER_SEC;
> > Why doesn't the test actually measure this?
> 
> Since rtcwake is being used to enter s2idle, both paths end up using a 
> 15‑second delay as the command parameter
> 
> and this value is carried through all related calculations. Are you 
> suggesting switching to a monotonic clock–based approach during resume?

CLOCK_BOOTTIME

-- 
Ville Syrjälä
Intel

  reply	other threads:[~2026-03-23 15:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23  7:02 [PATCH] tests/intel/xe_pm_residency: Fix suspend duration calculation Sk Anirban
2026-03-23  9:30 ` Jani Nikula
2026-03-23  9:41   ` Anirban, Sk
2026-03-23  9:54     ` Jani Nikula
2026-03-23  9:58       ` Anirban, Sk
2026-03-23 14:12     ` Kamil Konieczny
2026-03-23 10:01 ` Ville Syrjälä
2026-03-23 14:36   ` Anirban, Sk
2026-03-23 15:43     ` Ville Syrjälä [this message]
2026-03-23 13:32 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-03-23 15:46 ` ✗ i915.CI.BAT: failure " Patchwork
2026-03-23 18:35 ` ✓ Xe.CI.FULL: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acFfpWxozSezlo7E@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=karthik.poosa@intel.com \
    --cc=mallesh.koujalagi@intel.com \
    --cc=raag.jadav@intel.com \
    --cc=riana.tauro@intel.com \
    --cc=sk.anirban@intel.com \
    --cc=soham.purkait@intel.com \
    --cc=vinay.belgaumkar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox