Re: [PATCH i-g-t 4/4] tests/intel/kms_fbc_dirty_rect: check the plane size before fbc dirty rect tests

Reddy Guddati, Santhosh
2026-03-31T07:23:09Z

On 27-03-2026 13:41, Govindapillai, Vinod wrote:
> On Fri, 2026-03-27 at 10:35 +0530, Reddy Guddati, Santhosh wrote:
>> Hi Vinod,
>>
>> On 26-03-2026 12:55, Vinod Govindapillai wrote:
>>> If the FBC cannot support the plan size, skip the tests
>>>
>> %s/plan/plane
>>> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
>>> ---
>>>   tests/intel/kms_fbc_dirty_rect.c | 19 +++++++++++++++++--
>>>   1 file changed, 17 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/tests/intel/kms_fbc_dirty_rect.c
>>> b/tests/intel/kms_fbc_dirty_rect.c
>>> index efbd46985..ee13e95dd 100644
>>> --- a/tests/intel/kms_fbc_dirty_rect.c
>>> +++ b/tests/intel/kms_fbc_dirty_rect.c
>>> @@ -401,6 +401,22 @@ static void cleanup(data_t *data)
>>>    igt_display_commit2(&data->display, COMMIT_ATOMIC);
>>>   }
>>>
>>> +static bool check_fbc_supported(data_t *data)
>>> +{
>>> + if (!intel_fbc_supported(data->crtc)) {
>>> + igt_info("FBC not supported by the chipset on
>>> pipe\n");
>>> + return false;
>>> + }
>>> +
>>> + if (!intel_fbc_plane_size_supported(&data->display, data-
>>>> mode->hdisplay,
>>> +     data->mode->vdisplay))
>>> {
>>> + igt_info("Plane size not supported as per FBC size
>>> restrictions\n");
>>> + return false;
>>> + }
>>> +
>>> + return true;
>>> +}
>>> +
>>>   static bool prepare_test(data_t *data)
>>>   {
>>>    igt_display_reset(&data->display);
>>> @@ -411,8 +427,7 @@ static bool prepare_test(data_t *data)
>>>    data->pipe_crc = igt_crtc_crc_new(data->crtc,
>>>
>>> IGT_PIPE_CRC_SOURCE_AUTO);
>>>
>>> - igt_require_f(intel_fbc_supported(data->crtc),
>>> -       "FBC not supported by the chipset on
>>> pipe\n");
>>> + igt_require_f(check_fbc_supported(data), "FBC is not
>>> supported with this configuration\n");
>>>
>> Since the change in fbc dirty rectangle is independent of other
>> changes
>> in the series and imho this can be a split as separate patch from
>> blocking it.
>
> Yes. No dependency to other patches in this series. If this can be RB-
> ed with that typo fixed in the commit message, only this patch could be
> cherry-picked and merge and fix the typo at the merge time? I guess no
> need to resend only this patch again with typo fixed and waste CI. I
> don't have commit rights. Could you pls do that.
>
> thanks
> Vinod

This change LGTM. I will merge these changes with typo fix.
Reviewed-by: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>

Regards,
Santhosh
>
>>
>> Regards,
>> Santhosh
>>>    if (psr_sink_support(data->drm_fd, data->debugfs_fd,
>>> PSR_MODE_1, NULL) ||
>>>        psr_sink_support(data->drm_fd, data->debugfs_fd,
>>> PSR_MODE_2, NULL) ||
>>
>