Re: [PATCH i-g-t v9 6/6] tests/kms_flip: test suspend at most twice on SNB && BMG

["Thasleem, Mohammed" <mohammed.thasleem@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1378 bytes --]


On 30-03-2026 01:25 pm, Michał Grzelak wrote:
> gettime_us() on SNB and BMG from CI does not return proper time after
> starting suspend tests. This results in too many suspends issued before
> we hit the duration_ms. Break the loop on second execution.
>
> This WA explicitly conflicts with commit c75dcbdac51d ("tests/kms_flip:
> various improvements"). This WA is therefore only used by SNB and BMG.
>
> Signed-off-by: Michał Grzelak<michal.grzelak@intel.com>
LGTM:

Reviewed-by: Mohammed Thasleem <mohammed.thasleem@intel.com>

> ---
>   tests/kms_flip.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index 1a0517bcef..81fa8dd5c0 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -1325,7 +1325,13 @@ static bool event_loop(struct test_output *o, unsigned duration_ms,
>   		       unsigned *elapsed)
>   {
>   	unsigned long start, end;
> +	uint32_t devid;
>   	int count = 0;
> +	bool wa;
> +
> +	devid = intel_get_drm_devid(drm_fd);
> +
> +	wa = IS_SANDYBRIDGE(devid) || IS_BATTLEMAGE(devid);
>   
>   	start = gettime_us();
>   
> @@ -1346,6 +1352,9 @@ static bool event_loop(struct test_output *o, unsigned duration_ms,
>   		if (count && (gettime_us() - start) / 1000 >= duration_ms)
>   			break;
>   
> +		if (count && wa && o->flags & TEST_SUSPEND)
> +			break;
> +
>   		count++;
>   	}
>   

[-- Attachment #2: Type: text/html, Size: 2820 bytes --]