From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7427610E6EA for ; Tue, 9 Jan 2024 10:17:51 +0000 (UTC) Message-ID: Date: Tue, 9 Jan 2024 15:47:31 +0530 Subject: Re: [i-g-t 1/2] tests/kms_vrr: Tweak flipline subtest Content-Language: en-US To: Bhanuprakash Modem , "Golani, Mitulkumar Ajitkumar" , "igt-dev@lists.freedesktop.org" References: <20231213081652.3662325-1-bhanuprakash.modem@intel.com> <20231213095350.3684163-1-bhanuprakash.modem@intel.com> From: "Modem, Bhanuprakash" In-Reply-To: <20231213095350.3684163-1-bhanuprakash.modem@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: + Mitul to review On 13-12-2023 03:23 pm, Bhanuprakash Modem wrote: > As per the spec: If there is no flip request with in Vmax, > Hardware will terminate the Vblank at Vmax. > > If we flip with the interval > Vmax, the expected refresh rate > could be: (Vmax + time left for the next flip + Vmin), and it > is very difficult to generalize. For low refresh rate panels > (like 40 - 60 Hz), result is not falling into the threshold. > > Hence, tweak the test to increase the flip request interval. > > Signed-off-by: Bhanuprakash Modem > --- > tests/kms_vrr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c > index 1ace970a5..71fc36162 100644 > --- a/tests/kms_vrr.c > +++ b/tests/kms_vrr.c > @@ -481,11 +481,11 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags) > } > > if (flags & TEST_FLIPLINE) { > - rate = rate_from_refresh(range.min - 5); > + rate = rate_from_refresh(range.min - 10); > result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS); > igt_assert_f(result < 50, > "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold exceeded, result was %u%%\n", > - (range.min - 5), rate, result); > + (range.min - 10), rate, result); > } > > /*