Re: [PATCH i-g-t 2/3] tests/intel/xe_ccs: require flat CCS on xe2

[Matthew Auld <matthew.auld@intel.com>]

On 31/01/2024 12:21, Zbigniew Kempczyński wrote:
> On Wed, Jan 31, 2024 at 11:43:04AM +0000, Matthew Auld wrote:
>> On Xe2 compression is handled via PAT indexes and flat CCS, even on
>> igpu. Ensure the device has flat CCS support on such hardware, to
>> determine if these tests are valid.
>>
>> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>> Cc: Akshata Jahagirdar <akshata.jahagirdar@intel.com>
>> Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
>> ---
>>   tests/intel/xe_ccs.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/tests/intel/xe_ccs.c b/tests/intel/xe_ccs.c
>> index 7d0e8ed7a..88f812c91 100644
>> --- a/tests/intel/xe_ccs.c
>> +++ b/tests/intel/xe_ccs.c
>> @@ -653,6 +653,8 @@ igt_main_args("bf:pst:W:H:", NULL, help_str, opt_handler, NULL)
>>   	igt_fixture {
>>   		xe = drm_open_driver(DRIVER_XE);
>>   		igt_require(blt_has_block_copy(xe));
>> +		if (AT_LEAST_GEN(xe, 20))
>> +			igt_require(HAS_FLATCCS(xe));
> 
> We have block-copy-uncompressed which doesn't require flatccs.
> I included this in xe_ccs.c to avoid duplicating the test code.
> Shouldn't above check be in compressed subtests?

Yes, I think that makes sense. I didn't look closely enough here.

> 
> --
> Zbigniew
> 
>>   
>>   		xe_device_get(xe);
>>   
>> -- 
>> 2.43.0
>>