Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Sharma, Swati2" <swati2.sharma@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>,
	igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_hdr: Update dmesg error message
Date: Fri, 5 May 2023 20:34:58 +0530	[thread overview]
Message-ID: <adae800e-c234-7f0e-2559-a2a401ade155@intel.com> (raw)
In-Reply-To: <v7hmocsbafml52pb6ie24tfcwfj5hb57ppg4pt2eunj2zmd5zg@m675ievofyl7>

LGTM

Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 05-May-23 8:09 PM, Lucas De Marchi wrote:
> On Thu, May 04, 2023 at 05:05:56PM -0700, Lucas De Marchi wrote:
>> Error message changed in the kernel in commit
>> e5eef23e267c ("drm/display: Don't block HDR_OUTPUT_METADATA on
>> unknown EOTF"). We should probably have a better way to get this
>> error, but this should bring it back to a pass.
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>> ---
>>
>> Still to be tested.... didn't have a machine available to reproduce it
> 
> from CI results:
> 
> igt@kms_hdr@invalid-hdr@pipe-a-dp-1:
>      shard-apl: FAIL (i915#8253) -> PASS
> 
> Lucas De Marchi
> 
>>
>> tests/kms_hdr.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c
>> index 23f12c14a..cbc0f3a55 100644
>> --- a/tests/kms_hdr.c
>> +++ b/tests/kms_hdr.c
>> @@ -418,7 +418,7 @@ static void test_static_toggle(data_t *data, enum 
>> pipe pipe,
>>     igt_output_set_prop_value(data->output, IGT_CONNECTOR_MAX_BPC, 10);
>>     igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, 
>> NULL);
>>     if (flags & TEST_INVALID_HDR) {
>> -        igt_assert_eq(system("dmesg|tail -n 1000|grep -E \"EOTF Not 
>> Supported\""), 0);
>> +        igt_assert_eq(system("dmesg|tail -n 1000|grep -E \"Unknown 
>> EOTF [0-9]+\""), 0);
>>         goto cleanup;
>>     }
>>     igt_assert_output_bpc_equal(data->fd, pipe, output->name, 10);
>> -- 
>> 2.40.1
>>

      reply	other threads:[~2023-05-05 15:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05  0:05 [igt-dev] [PATCH i-g-t] tests/kms_hdr: Update dmesg error message Lucas De Marchi
2023-05-05  0:42 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-05-05  8:07 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-05-05 14:39 ` [igt-dev] [PATCH i-g-t] " Lucas De Marchi
2023-05-05 15:04   ` Sharma, Swati2 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adae800e-c234-7f0e-2559-a2a401ade155@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox