From: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
To: Stuart Summers <stuart.summers@intel.com>
Cc: <igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t] tests/intel/xe_exec_reset: Remove CANCEL logic for CM variants
Date: Sun, 12 Apr 2026 18:17:36 -0700 [thread overview]
Message-ID: <adxEMP0Ttn5UnIO-@nvishwa1-desk> (raw)
In-Reply-To: <20260406220043.42823-1-stuart.summers@intel.com>
On Mon, Apr 06, 2026 at 10:00:42PM +0000, Stuart Summers wrote:
>The compute mode tests are expected to be long running and will
>not trigger the TDR logic in the KMD. This is illustrated in
>the test in that the legacy cases implement the CANCEL case,
>which is meant to trigger the TDR based resets vs the CM
>cases which do not support this.
>
>Remove the CANCEL logic from the CM tests since it isn't actually
>used in any of the test cases here.
>
>Signed-off-by: Stuart Summers <stuart.summers@intel.com>
>---
> tests/intel/xe_exec_reset.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/tests/intel/xe_exec_reset.c b/tests/intel/xe_exec_reset.c
>index 7aaee31dd..4493a56fc 100644
>--- a/tests/intel/xe_exec_reset.c
>+++ b/tests/intel/xe_exec_reset.c
>@@ -421,7 +421,7 @@ test_compute_mode(int fd, struct drm_xe_engine_class_instance *eci,
> uint64_t exec_addr;
> int e = i % n_exec_queues;
>
>- if (!i || flags & CANCEL) {
>+ if (!i) {
> spin_opts.addr = base_addr + spin_offset;
> xe_spin_init(&data[i].spin, &spin_opts);
> exec_addr = spin_opts.addr;
>@@ -478,7 +478,7 @@ test_compute_mode(int fd, struct drm_xe_engine_class_instance *eci,
> xe_vm_unbind_async(fd, vm, 0, 0, addr, bo_size, sync, 1);
> xe_wait_ufence(fd, &data[0].vm_sync, USER_FENCE_VALUE, 0, 3 * NSEC_PER_SEC);
>
>- if (!(flags & (GT_RESET | CANCEL))) {
>+ if (!(flags & GT_RESET)) {
> for (i = 1; i < n_execs; i++)
> igt_assert_eq(data[i].data, 0xc0ffee);
> }
>--
LGTM
Reviewed-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
>2.43.0
>
prev parent reply other threads:[~2026-04-13 1:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-06 22:00 [PATCH i-g-t] tests/intel/xe_exec_reset: Remove CANCEL logic for CM variants Stuart Summers
2026-04-06 22:27 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-04-06 22:44 ` ✓ i915.CI.BAT: " Patchwork
2026-04-07 0:37 ` ✗ i915.CI.Full: failure " Patchwork
2026-04-07 19:09 ` Summers, Stuart
2026-04-07 2:38 ` ✗ Xe.CI.FULL: " Patchwork
2026-04-09 4:39 ` [PATCH i-g-t] " Dandamudi, Priyanka
2026-04-13 1:17 ` Niranjana Vishwanathapura [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adxEMP0Ttn5UnIO-@nvishwa1-desk \
--to=niranjana.vishwanathapura@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=stuart.summers@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox