From: Lyude Paul <lyude@redhat.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>,
Eben Upton <eben@raspberrypi.org>,
Boris Brezillon <boris.brezillon@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [igt-dev] [PATCH i-g-t v2 03/12] chamelium: Debug-print CRCs when comparing them and dumping frames
Date: Fri, 14 Dec 2018 14:42:29 -0500 [thread overview]
Message-ID: <ae9bf29d27e05988e04ef27211f69532fca13aec.camel@redhat.com> (raw)
In-Reply-To: <20181213155533.18048-4-paul.kocialkowski@bootlin.com>
Reviewed-by: Lyude-Paul <lyude@redhat.com>
On Thu, 2018-12-13 at 16:55 +0100, Paul Kocialkowski wrote:
> Add debug prints for the reference and captured CRCs when comparing them
> and dumping them, which can be useful to get an idea of what is going on
> (e.g. specific noise on display cables often only changes one of the
> values that compose the CRC).
>
> It's also useful to associate a test debug output with the dumped
> pictures (that have the CRC in their name).
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> ---
> lib/igt_chamelium.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
> index d136fb04c342..32b859eac4a7 100644
> --- a/lib/igt_chamelium.c
> +++ b/lib/igt_chamelium.c
> @@ -1033,6 +1033,9 @@ void chamelium_assert_crc_eq_or_dump(struct chamelium
> *chamelium,
> char *capture_suffix;
> bool eq;
>
> + igt_debug("Reference CRC: %s\n", igt_crc_to_string(reference_crc));
> + igt_debug("Captured CRC: %s\n", igt_crc_to_string(capture_crc));
> +
> eq = igt_check_crc_equal(reference_crc, capture_crc);
> if (!eq && igt_frame_dump_is_enabled()) {
> /* Grab the reference frame from framebuffer */
> @@ -1101,6 +1104,10 @@ void
> chamelium_assert_analog_frame_match_or_dump(struct chamelium *chamelium,
> capture_crc = chamelium_get_crc_for_area(chamelium, port, 0,
> 0,
> 0, 0);
>
> + igt_debug("Reference CRC: %s\n",
> + igt_crc_to_string(reference_crc));
> + igt_debug("Captured CRC: %s\n",
> igt_crc_to_string(capture_crc));
> +
> reference_suffix = igt_crc_to_string_extended(reference_crc,
> '-', 2);
> capture_suffix = igt_crc_to_string_extended(capture_crc, '-',
--
Cheers,
Lyude Paul
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-12-14 19:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 15:55 [igt-dev] [PATCH i-g-t v2 00/12] Chamelium VC4 plane testing, with T-tiled mode Paul Kocialkowski
2018-12-13 15:55 ` [igt-dev] [PATCH i-g-t v2 01/12] chamelium: Pass dimensions instead of mode to pattern generation helper Paul Kocialkowski
2018-12-14 8:58 ` Maxime Ripard
2018-12-13 15:55 ` [igt-dev] [PATCH i-g-t v2 02/12] chamelium: Pass the pattern block size as argument to helpers Paul Kocialkowski
2018-12-14 9:00 ` Maxime Ripard
2018-12-13 15:55 ` [igt-dev] [PATCH i-g-t v2 03/12] chamelium: Debug-print CRCs when comparing them and dumping frames Paul Kocialkowski
2018-12-14 9:00 ` Maxime Ripard
2018-12-14 19:42 ` Lyude Paul [this message]
2018-12-13 15:55 ` [igt-dev] [PATCH i-g-t v2 04/12] lib: drmtest: Add helpers to check and require the VC4 driver Paul Kocialkowski
2018-12-14 9:00 ` Maxime Ripard
2018-12-13 15:55 ` [igt-dev] [PATCH i-g-t v2 05/12] lib/igt_fb: Add checks on i915 for i915-specific tiled buffer allocation Paul Kocialkowski
2018-12-14 9:02 ` Maxime Ripard
2018-12-13 15:55 ` [igt-dev] [PATCH i-g-t v2 06/12] lib/igt_fb: Add support for allocating T-tiled VC4 buffers Paul Kocialkowski
2018-12-14 9:03 ` Maxime Ripard
2018-12-13 15:55 ` [igt-dev] [PATCH i-g-t v2 07/12] lib/igt_vc4: Add helpers for converting linear to T-tiled XRGB buffers Paul Kocialkowski
2018-12-14 9:03 ` Maxime Ripard
2018-12-13 15:55 ` [igt-dev] [PATCH i-g-t v2 08/12] lib/igt_fb: Add a stride-provisioned fashion of igt_fb_convert Paul Kocialkowski
2018-12-14 9:05 ` Maxime Ripard
2018-12-13 15:55 ` [igt-dev] [PATCH i-g-t v2 09/12] lib/igt_fb: Add a helper to retreive the plane bpp for a given format Paul Kocialkowski
2018-12-14 9:05 ` Maxime Ripard
2018-12-13 15:55 ` [igt-dev] [PATCH i-g-t v2 10/12] lib/igt_kms: Add helpers to count and iterate planes from pipe Paul Kocialkowski
2018-12-13 15:55 ` [igt-dev] [PATCH i-g-t v2 11/12] lib/igt_kms: Add helpers to count and iterate planes from output Paul Kocialkowski
2018-12-13 15:55 ` [igt-dev] [PATCH i-g-t v2 12/12] chamelium: Add a CRC-based display test for randomized planes Paul Kocialkowski
2018-12-14 9:22 ` Maxime Ripard
2018-12-13 16:18 ` [igt-dev] ✗ Fi.CI.BAT: failure for Chamelium VC4 plane testing, with T-tiled mode (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae9bf29d27e05988e04ef27211f69532fca13aec.camel@redhat.com \
--to=lyude@redhat.com \
--cc=boris.brezillon@bootlin.com \
--cc=eben@raspberrypi.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=petri.latvala@intel.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox