From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: Eero Tamminen <eero.t.tamminen@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tools/intel-gpu-top: Only link against igt_perf.la
Date: Tue, 26 Mar 2019 15:56:33 +0000 [thread overview]
Message-ID: <aea48eaa-35e2-fde6-cae2-021f52d7cd8a@linux.intel.com> (raw)
In-Reply-To: <20190326132801.5216-1-chris@chris-wilson.co.uk>
On 26/03/2019 13:28, Chris Wilson wrote:
> Fix the meson build to not link intel-gpu-top againstt the whole test
> infrastructure; it's a tool not a test!
>
> Reported-by: Eero Tamminen <eero.t.tamminen@intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110249
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> tools/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/meson.build b/tools/meson.build
> index 79f36aa95..5d00f2e3c 100644
> --- a/tools/meson.build
> +++ b/tools/meson.build
> @@ -98,7 +98,7 @@ shared_library('intel_aubdump', 'aubdump.c',
> executable('intel_gpu_top', 'intel_gpu_top.c',
> install : true,
> install_rpath : bindir_rpathdir,
> - dependencies : tool_deps + [ lib_igt_perf ])
> + dependencies : lib_igt_perf)
>
> conf_data = configuration_data()
> conf_data.set('prefix', prefix)
>
Pffft, it was only keeping hip in the age of Mesonization -
https://www.phoronix.com/scan.php?page=news_item&px=Fedora-Mesa-Meson-Debug-Build.
;)
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-26 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 13:28 [igt-dev] [PATCH i-g-t] tools/intel-gpu-top: Only link against igt_perf.la Chris Wilson
2019-03-26 14:04 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-26 15:56 ` Tvrtko Ursulin [this message]
2019-03-26 18:56 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aea48eaa-35e2-fde6-cae2-021f52d7cd8a@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=eero.t.tamminen@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox